Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 21 Jan 2022 18:40:51 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Network Development <netdev@vger.kernel.org>,
        Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>
Subject: Re: [net RFC v1 1/1] page_pool: fix NULL dereference crash
Message-ID: <20220122024051.GA905413@euler>
References: <20220122005644.802352-1-colin.foster@in-advantage.com>
 <20220122005644.802352-2-colin.foster@in-advantage.com>
 <CAADnVQK8xrQ92+=wm8AoDkC93SEKz3G=CoOnkPgvs=spJk5UZA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAADnVQK8xrQ92+=wm8AoDkC93SEKz3G=CoOnkPgvs=spJk5UZA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mMtSS6OdGpKEDmE4XiM9Styg2lhHcGKOUtrM5lEthT/Om/idK1NyP1UF6o4U?=
 =?us-ascii?Q?ydyAV4cmcLbAphyCL2MQFpK0paN/LuNFQaStkwMMhqgJSB+bTgFDTrEkAie6?=
 =?us-ascii?Q?j2LmgUXxUjed81Zcqq3nvtvGOKfajTrN8/LJkFHBJ0cx4KcHbDQ+smH33onM?=
 =?us-ascii?Q?SrFINbVb9MZykcNqK3er6PK8BDUDluzFongQ2Hrmedy8WD4b2iDKRVznI5cV?=
 =?us-ascii?Q?QSrAysCg66KzBjjZzga6S5U17EhP99epUlQ0qvrfUQnZViSGkWg/RxlJYcqF?=
 =?us-ascii?Q?2RZxgSfVh9fCH4tvN73PHM26yNrHCEEqwC1HEXNkzrUh2UmdCRKKfQEzZl22?=
 =?us-ascii?Q?tGF3Ec2RmNRhNtOoSoQvKPchuUDmYU5GXjC6eJIDdfc25fzCu0XZAt5Cbx8t?=
 =?us-ascii?Q?arjC7ngf4uq41oQUCEEfmZa6pXi4bDC8yyw/Kdft6hCC852OHa5ZPpUZ/SY1?=
 =?us-ascii?Q?bN7uV+snG6qRnH0AlXrmZUjJA+ITC59S9/MaCnwZzYCWI9+hZz3gidRBcupm?=
 =?us-ascii?Q?vpCfvmkgGLZTgSIou/9V8Lo9Ple1eYR41T2jXLrBksnPM96q9BgJr92mvong?=
 =?us-ascii?Q?szPyyjFozQuCKeljpQSXw926QFxFeQmed1P9d9Ox7mXJgJTgvedVUCc5fyGu?=
 =?us-ascii?Q?emSjdr/+gYeq8J8Mhoyh6pAunhOI3r3FAwlbTLcMim1h2uQUoJfHn7kim+tS?=
 =?us-ascii?Q?hXgoUeRt6SZwVWQ9IWVoBy1ERDfbw7z6XjpvEVFebPkaUOonN9bk+loRG6X1?=
 =?us-ascii?Q?JxQamM44Jy8cmx3CLLeIez21W8ZSGviS3XWJGesSQfuk/vHhz9c9SV66U5a2?=
 =?us-ascii?Q?o6ie9DgUnJNhimtBqTEgy0Tc5W/tfUdKb4NCIq2Mqi2Z/XnZdyDg+cmglXz4?=
 =?us-ascii?Q?ijAh5VDcHtrWhA9b4MJWe0EzGr5Ky2M2YYDUvyGuSLnb+t1KHluULdaZcntb?=
 =?us-ascii?Q?45Dralu+VSl8j0u2Ok40EQjVP5R5NeOaPIvinBkE+ojm3odLWV5CnnkQ7ucX?=
 =?us-ascii?Q?x/xx3CRyewDjqR+HE3vTk2tqQ+t+Vh6b7i2As4vc98eWzoQQ/y43+VMs7YQ0?=
 =?us-ascii?Q?4RC+5vQ3y+9CogZGM80z22nlaCmPTORgkmKSf1QRg2/kcrFmbDfBb+qbmgLJ?=
 =?us-ascii?Q?BYeRRlTmVJoAao/tzsKyEx9gDmJMcsdkswpL38nykkjtG8m7vd8AWRowlja+?=
 =?us-ascii?Q?wj2LVzlFvWd8xbRhv5isQ36bvdrUoNilJcc+tgSiUrvKhONkGxkItTcJJmpF?=
 =?us-ascii?Q?u/mCNhbccCl5tdogOv6Nj99IDQNpP8Ax+RjosC0EvQNYs+Vcd2YViSFA5Mqb?=
 =?us-ascii?Q?DMiFAjIkYlpNAlDR2kxORxnfirvuDhDG+sl2a7om3qC6leS6pk9jsgnuqBR/?=
 =?us-ascii?Q?SBGXXSiTdgI/eABI/8kP7ZxiQ01laiagCBRhcrRYIUQo75FoPzqEEBvRdoLn?=
 =?us-ascii?Q?ChWmmXrlk5efz0Z2O1voumoX0LSIYMY7EOwhJXkRR961hdkPTcNrbglah2GW?=
 =?us-ascii?Q?P01R4rSNMRrux6PTXHKDOaxQUQYB2/CTHle69b9+XwOLnuExcGuguUUEBeY9?=
 =?us-ascii?Q?YOBZuopp5Y6BwrOxn0HV7qNzbl2sSaoPmQrwz93NNSI7ToWPV9Jt3gK77XHH?=
 =?us-ascii?Q?glerE2V1NY2uNLyGrLyHo9H1TYxUS/ImX64cNHUZdVPll78+f7DzDnL6WQ1s?=
 =?us-ascii?Q?B1vyt7QcLpt9joTbwgSiRgahS9c=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66dbdd6e-d597-48b4-6dc2-08d9dd509eef
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2022 02:40:58.6530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qZTknn6VO8FZ7XNfwZLzbFGohNxR6ad9jdLVfvWb5O8Hsz8Qu9RbOHvhR/Mjl6rGLUd0yGrmKbiyb1LSeA2y7KRTcKq1DPriF/U3zmaDfNA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1596
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 21, 2022 at 05:13:28PM -0800, Alexei Starovoitov wrote:
> On Fri, Jan 21, 2022 at 4:57 PM Colin Foster
> <colin.foster@in-advantage.com> wrote:
> >
> > Check for the existence of page pool params before dereferencing. This can
> > cause crashes in certain conditions.
> 
> In what conditions?
> Out of tree driver?
> 
> > Fixes: 35b2e549894b ("page_pool: Add callback to init pages when they are
> > allocated")
> >
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> >  net/core/page_pool.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> > index bd62c01a2ec3..641f849c95e7 100644
> > --- a/net/core/page_pool.c
> > +++ b/net/core/page_pool.c
> > @@ -213,7 +213,7 @@ static void page_pool_set_pp_info(struct page_pool *pool,
> >  {
> >         page->pp = pool;
> >         page->pp_magic |= PP_SIGNATURE;
> > -       if (pool->p.init_callback)
> > +       if (pool->p && pool->p.init_callback)

And my apologies - this should be if (pool... not if (pool->p. kernelbot
will be sure to tell me of this blunder soon

> >                 pool->p.init_callback(page, pool->p.init_arg);
> >  }
> >
> > --
> > 2.25.1
> >