Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Harry Austen <harryausten@hotmail.co.uk>
To:     linux-f2fs-devel@lists.sourceforge.net
Cc:     jaegeuk@kernel.org, chao@kernel.org, linux-kernel@vger.kernel.org,
        Harry Austen <harryausten@hotmail.co.uk>
Subject: [PATCH] f2fs: fix fileattr_set unsupported attribute handling
Date:   Sat, 22 Jan 2022 12:59:03 +0000
Message-ID: <AM6PR10MB2838873D61CE1C0DB91EEDB9FA5C9@AM6PR10MB2838.EURPRD10.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: 7BIT
Content-Type:   text/plain; charset=US-ASCII
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 04641f32-9a1f-4562-b91b-08d9dda72207
X-MS-Exchange-SLBlob-MailProps: mBRmoEB1kyIDyj55spNzzZ0EJ7K7ysKeR+bYmYtegQd5R3Cnw9k8mH5LlUVF0NFx+jtjQnxCJDMv4TI93VyHxMgggD1P1c3rQzsm0Xw3asW7L5AELp4kmE8spnD6AQFV8q8NSHhfq/DJk0u4GaiVB3arq/pxT5+EFEXZpj6fRQ2p3ztXToJpdLKGDEPssrbx8ZoxEpvPn40N307QBGPrkTWhrVIPOaLOJ9YeqIHfJwG5JjLoFCGS3pRlg6okAAQlBfHN4y1lSrMWJHNUA0A3+bLQsOhov0BoXqlZrbwK36DSqb/Fzz49xVQ9vKh+6xwD+nJWMgt/zXg8PhZOma/ZybVzjW83ZwDWtSbW/bcZw/v26+Hl2XoKpLoSngg65sii8hwLk7zo+oLENV7u0rDcQxKOr3DWqw7y+vlB/yQGHe2gHCm5h9y1M6IcsYkyVv4/6m9iEAN/CUXpJfY4QUUXwG6g+3ru2iDyWFSQ+YR7oP1oFgPF15gAc+PCbys/ZM8LxBd9P3XFwb6ZBfs91E96fQ/4BDuXDTz8wYU4I8GR/pZczrQ9sbYFJjpOonBx0IBBynt5LUDf5U1krjpFeSBDu9QE3JX40m5Ev+6hoOxW+O0ZsZuDekqkwpVQBCnhhGCBpY3TC8/jxUvrvOeFTq6UI56ao5xBupZsDn59fLUq2Z5zc//DrORdAUyoPJGJGDFpJECRU+gXN9c67OF/7bTbfZ41SUp0Y41dNIOk3dj4eQIkfmDi6UCYgYloJ3wqSAaxWhlzBytmZYE=
X-MS-TrafficTypeDiagnostic: AM0PR10MB3364:EE_
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: sk2+lQO8vkE8xTUQ/x0Wwrti/XUG77m5q921JKfRX/XVYFO7hozWMx3f/jq4QdXFbqb8NEPTeQqZLkzr1yI/XLclyo77OEUuXB+ctZhOJxBuR0C7uPb8TIx0Tpq40E5/PVJ7needQFhtOk8P/2tdNmRLSvAzFeW/UPoVOYnwuGOaXPJ8T9RG+JYwFx0aUbTgDyd5JVIcAJMALaM2MTdGvJqOv3bjG1k2+Y1UzZdZ9/UPV3iHrLaqQqSnypieTvf7K6vpMY3wmmLhNqKqNBHhaop2uasVSMcg0caMI1/0IvJNK4iGD88rhYD0rQCpz9tG5bKHkjAHTVtdI4fdZLfyNF5L1T0UDo3Q0+/9fyhsvn2vP5Qf5AXxBzxdslwqZuJaTx6p1owpw/iquCJ0St8vnw55ziqu/0YIerXmfQzMqVGKLzyCP0tx/mbDE3i7owWOVKPEqSWkX3jMSlFauK0Q1Qtcq5TmFYGC5EGsa8966FP/aoyOwlwyB354ijbfxE+00yWcDmON2+0XjzX/Vc1QQiajvIQL7hJ9DMYyeuPSMvNOhBPUKh5EdACAAXQHqxyNIYDN1OhBMGpZ5b3hGPMWgA==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yCG8s0Eh9l7HEK9LSrIpy7KXYpGk3kwGY54Z93oeNRRzloVFq0NRH0RRb3GJ?=
 =?us-ascii?Q?I2F2h5FHdJDCiN5BBsW4Kla+5oeB0Wn5pIPIMaSA2VQUmOOGWQUDTO0jfgkM?=
 =?us-ascii?Q?aB3MwYnzZjQM9O+7mAt+FtSfkC9b0ar/DN3sMdDH8nQS6S8S8VTEmmc8vkxJ?=
 =?us-ascii?Q?cswC++fnT8afVIhZ8EmkWI8ZlBXWwRUAl5/ZSDG7UxpbHWccAJYvofk15UU1?=
 =?us-ascii?Q?gwPnAslmJ25epCIKm0DmZP0ZYtKPndkf9dHJkpVM2YsonRtRH0e+9VR68Ul0?=
 =?us-ascii?Q?gJwee2zoVykhWl9PE+n++7NTia2x74Te3jH531PHI/O9+LntIw0PgkwvdOgf?=
 =?us-ascii?Q?o1fy4Y7Z2eltd23picE4E5PZgWv01kEReYrGSiqC58XEJPwC3OJHp2PndYCH?=
 =?us-ascii?Q?1kfryiCSnO886Xae1TpLLdbl4w213dbjFaYNbExFsFunQTtDAqLhqTqYGorS?=
 =?us-ascii?Q?NSxb6zVkrTFYGTB2zNtAupZwNws2xUfk5u5Szsrg3hrXZXDBqUUlZd9psydY?=
 =?us-ascii?Q?Zv3v9Nn3DlULjV9x3VeaLk/PpH49yHwD1jl+gbBkKQI517fbzN4IEPY+VlbE?=
 =?us-ascii?Q?VfREcuyyhc3GmaYU7fx54N7J28FZkJqnfQl71HErD09afcjXsrgYpKdynnMV?=
 =?us-ascii?Q?0a/zy2S2hCSQ6MyjklTp62b/6roiEBZY8zV3xfgV5ETMNF1VZD3iZSzOj79E?=
 =?us-ascii?Q?SpL//Pgb/YPapR+itmFVw+0rGHzP+so9xzMzrre+vO4lOZEeRlz2YvFtHaZa?=
 =?us-ascii?Q?xpaZ2XZW2oxImnQFzHSHgdDargVdwG7Vzw8W84z+TAnMpkUIULQYgrRsYzuD?=
 =?us-ascii?Q?/QX+qzTP+92C6LO2Y+9HMbgqXTbhQzVuSFnkQMpe2cJz2W1iVkJmvfxKlVf7?=
 =?us-ascii?Q?6HDDbpszBAdJKxDybjm3AhYv6Jl9MAM0zDoLpZ1adqQHDuZsnWDhBmby36cw?=
 =?us-ascii?Q?MOG9/PolXbrdA9tqFYCMlw=3D=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-6b909.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 04641f32-9a1f-4562-b91b-08d9dda72207
X-MS-Exchange-CrossTenant-AuthSource: AM6PR10MB2838.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2022 13:00:15.2500
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3364
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

FS_IOC_SETFLAGS ioctl should return EOPNOTSUPP if the file attribute
(e.g. FS_NOCOW_FL) is not supported, rather than silently ignoring it
and returning success.

Fixes: 9b1bb01c8ae7 (f2fs: convert to fileattr)
Signed-off-by: Harry Austen <harryausten@hotmail.co.uk>
---
 fs/f2fs/file.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 92ec2699bc85..061bf35c2582 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3085,9 +3085,8 @@ int f2fs_fileattr_set(struct user_namespace *mnt_userns,
 		return -EIO;
 	if (!f2fs_is_checkpoint_ready(F2FS_I_SB(inode)))
 		return -ENOSPC;
-	if (fsflags & ~F2FS_GETTABLE_FS_FL)
+	if (fsflags & ~F2FS_SETTABLE_FS_FL)
 		return -EOPNOTSUPP;
-	fsflags &= F2FS_SETTABLE_FS_FL;
 	if (!fa->flags_valid)
 		mask &= FS_COMMON_FL;
 
-- 
2.34.1