Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Oleksandr Natalenko <oleksandr@natalenko.name>
To:     Eugene Shalygin <eugene.shalygin@gmail.com>,
        Guenter Roeck <linux@roeck-us.net>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Denis Pauk <pauk.denis@gmail.com>,
        Jean Delvare <jdelvare@suse.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-hwmon@vger.kernel.org
Subject: Re: [ASUS EC Sensors v7 1/3] hwmon: (asus-ec-sensors) add driver for ASUS EC
Date:   Sat, 22 Jan 2022 21:13:29 +0100
Message-ID: <2614116.mvXUDI8C0e@natalenko.name>
In-Reply-To: <20220120004540.GD3474033@roeck-us.net>
References: <20220118165316.412735-1-eugene.shalygin@gmail.com> <CAB95QATvQPZ-s4dCWeqKcSZ9Rfx9uK1AyoM9Kk3biPfvXh5r5g@mail.gmail.com> <20220120004540.GD3474033@roeck-us.net>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello.

On =C4=8Dtvrtek 20. ledna 2022 1:45:40 CET Guenter Roeck wrote:
> On Wed, Jan 19, 2022 at 04:25:41AM +0100, Eugene Shalygin wrote:
> > I did not read carefully what I committed and now two small
> > corrections are required (see inline). Should I resend again?
> >=20
>=20
> Wait for a couple of days in case there is test coverage
> or other feedback.

Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>

along with line break/comments fixes.

I'd also appreciate Cc'ing me on this submission.

Thanks.

>=20
> Guenter
>=20
> > On Tue, 18 Jan 2022 at 17:53, Eugene Shalygin <eugene.shalygin@gmail.co=
m> wrote:
> > > +       DMI_EXACT_MATCH_BOARD(VENDOR_ASUS_UPPER_CASE, "ROG STRIX X570=
=2DF GAMING",
> > > +               SENSOR_SET_TEMP_CHIPSET_CPU_MB |
> > > +               SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CHIPSET
> > Redundant line break.
> > > +       ),
> > > +       DMI_EXACT_MATCH_BOARD(VENDOR_ASUS_UPPER_CASE, "ROG STRIX X570=
=2DI GAMING",
> > > +               SENSOR_TEMP_T_SENSOR | SENSOR_FAN_VRM_HS |
> > > +               SENSOR_FAN_CHIPSET | SENSOR_CURR_CPU),
> >=20
> >=20
> > > +struct ec_sensors_data {
> > > +       unsigned long board_sensors;
> > > +       struct ec_sensor *sensors;
> > > +       /** EC registers to read from */
> > > +       u16 *registers;
> > > +       u8 *read_buffer;
> > > +       /** sorted list of unique register banks */
> > > +       u8 banks[ASUS_EC_MAX_BANK + 1];
> > > +       /** in jiffies */
> > > +       unsigned long last_updated;
> > > +       acpi_handle aml_mutex;
> > > +       /** number of board EC sensors */
> > > +       u8 nr_sensors;
> > > +       /** number of EC registers to read (sensor might span more th=
an 1 register) */
> > > +       u8 nr_registers;
> > > +       /** number of unique register banks */
> > > +       u8 nr_banks;
> > > +};
> >=20
> > Forgot to remove doc-comments.
> >=20
> > Thanks,
> > Eugene
>=20
>=20


=2D-=20
Oleksandr Natalenko (post-factum)