Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2539574pxb; Sun, 23 Jan 2022 07:54:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJzRfSAjLGMRFz0RaKo+C9uGKXOCYXitkNFXN22B1WtnYK6X/yQ6Uz1GvMnNkNMQleKNheMw X-Received: by 2002:a17:90a:d585:: with SMTP id v5mr9342303pju.124.1642953266486; Sun, 23 Jan 2022 07:54:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642953266; cv=none; d=google.com; s=arc-20160816; b=y+gE5/GULK8JWJ05WbMjh53MlOV5qLU5UPKqsh7syYARO78oILQrTGWkA1wIZaDwCI cZZQecyOcbULi3ZOL6tNiSMrZsrErR5G5zHWkGhOR59VWQqM5uejzMd/gO0peqhg3VBz FlPr4Y5qYT+7wCHtyB7l71YSIjq2IJSq1ljzATU/2hpJ+/9PiR2Okax+qNngHuFglyvy 3WAup0HL566A4tHDbbt+ukb3wzTRn8auNkvIdZPV+EpMqFFcoCLwll6lBQY2H+wipiVo W3/2zDD1x3Zdz7F64tuZzwHyAjTWSnJAvh4uvFg0vz7ZQU5hC9D4uc5MNQgBMw9V6KVx NtuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=fvjIHzoYjX2wrs+EpzMBjfsTjarifS+awxMyAGX77+c=; b=HhEyN/wiuoCRmOdgxslO+IAzQKxDdkS65zMVel6VodiT4zguRVlo7mUxh2Lx39CKbE tfjJTdytf3iFTUGIkVkDoGQNUUCYkq202jY86g178X4fvwgtglIJcG5SDhJBm8AXhk1l sSKG3M2sR4HOhTCYaIdZ/FPgjBX3qMXUkczCcsHIxu9HdHmZatdsowCl118oyORvB/vS yUOGtFjKEfmUmtjWc2TGz2ajrPpHnw5rB++Ffrs606bzhGgzcf49xmQA4h73mx9z6rxO mFlAE0dHtNZ9kDBdHpXCzDR2VhCvK5f718KZPpxZ77E/NbFCmtp8E2d58WwEIsjdmWTp i1NQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=icZbSbAm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n9si10273093plk.379.2022.01.23.07.54.13; Sun, 23 Jan 2022 07:54:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=icZbSbAm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232710AbiAWBBP (ORCPT + 99 others); Sat, 22 Jan 2022 20:01:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231594AbiAWBBP (ORCPT ); Sat, 22 Jan 2022 20:01:15 -0500 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE69AC06173D for ; Sat, 22 Jan 2022 17:01:14 -0800 (PST) Received: by mail-yb1-xb31.google.com with SMTP id c10so39469516ybb.2 for ; Sat, 22 Jan 2022 17:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fvjIHzoYjX2wrs+EpzMBjfsTjarifS+awxMyAGX77+c=; b=icZbSbAmMydOl2Lfh9/+QWimtCNVaKajeqB22HdXuG20nsP2qvlOHr0ZXqR12bQaRa 6THaCHTNdTiILsj8W2oMq/Gajn+J+3je19fwojwy376TurxKHscJ66fabnlY7GQPFwu+ IZdvBgTYHcw/UtGA8KuXyQis0rqVaXd3WWc+o5mkISfA3Gq+XYX98RNhE3H0XZD86FyT YhJcecRRdsqF4lc0d+33JV+kjrK0yenicrpHodrZ1DSmZ3JKR+cv5O/DPJHwx/Tp8vJT eYSYRuQGocZtmIrJ0kP9s3y+V+atWqx//BqvWTVrK44h0mX1rZtOo+qetBXVR5Kr8mQh Ul7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fvjIHzoYjX2wrs+EpzMBjfsTjarifS+awxMyAGX77+c=; b=DoVnpQVZdpyv2aQD9fYtyjP8O/mudZIHrHkmIwXPMdW+8IO2BKmsE1IODLUwgEnSju LH0tnlLnmjZTSlswzPmuWfimTaSlk/cpur2tldWbjIERFLmDy92KpkzqcWrR0eMPRqpz T38rPBqyDdBI86YiGGZ11Irvtf+UVzlWVtaguEi1cZmfXqfbuXVxBvz8XoRSGsETeGe4 KN7xOcFHGamQm2zsdR/kXgK6eE4RRYFaf8b+YOGJ6LkUpIguXS92vxtoA3qubT9gt97x uhNwxnblMVsUZC4u3CwUYGlqhPiDDpKeBffsG8VX7J/CWlYcZVmSMnPSgYKv4wz/wBVc GVSg== X-Gm-Message-State: AOAM532CCk5cLAg4mvmhC4Ja99WfsleYR6V4NZiYS8E1ANkHNU3dBIxh Gly7WoXKYh3ukBaEkFn1jiqAKM4h7mTJYk7wPgi3ng== X-Received: by 2002:a25:8e89:: with SMTP id q9mr16586053ybl.520.1642899673159; Sat, 22 Jan 2022 17:01:13 -0800 (PST) MIME-Version: 1.0 References: <20220120104654.3467-1-linmq006@gmail.com> In-Reply-To: <20220120104654.3467-1-linmq006@gmail.com> From: Linus Walleij Date: Sun, 23 Jan 2022 02:01:01 +0100 Message-ID: Subject: Re: [PATCH] power: gemini-poweroff: Fix IRQ check in gemini_poweroff_probe To: Miaoqian Lin Cc: Sebastian Reichel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 20, 2022 at 11:47 AM Miaoqian Lin wrote: > platform_get_irq() returns negative error number instead 0 on failure. > And the doc of platform_get_irq() provides a usage example: > > int irq = platform_get_irq(pdev, 0); > if (irq < 0) > return irq; > > Fix the check of return value to catch errors correctly. > > Fixes: f7a388d6cd1c ("power: reset: Add a driver for the Gemini poweroff") > Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Yours, Linus Walleij