Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3076177pxb; Mon, 24 Jan 2022 01:42:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJx87XUPigaRjujOwMotvvH5FXxqAXWuUOib3/k+3THIXJRliJ/0kqdKn3A9l6weQ4LkM8HN X-Received: by 2002:a17:903:2287:b0:14b:9a9:ff93 with SMTP id b7-20020a170903228700b0014b09a9ff93mr13949379plh.141.1643017356520; Mon, 24 Jan 2022 01:42:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643017356; cv=none; d=google.com; s=arc-20160816; b=sQnvlC85WwhSKwuWBBS7DmLa84r4AwazVaD1UM7MD8foKm1sqkEOfDFjGTTkJQH1E/ kxll5db2e3dOTcICSiaki7gNjDGnCBgLF42iGMUHh8NPZQn3AVv9woRdO9atjxmDxQ43 NYkwYRf2nJxz8V7wftz1KbK22loB6Qz2nBWcwPcUQZrJROvBDUKJuR/FQWczB5Zr+gRP 2oM8v60LfcYICuWWheeh+1aJVwsIF+1lK4nBtog1R/T/woZxTQ/6x4j2r5rHSmzYkGpF FK1T537NwNu04MhSpOBxNUHEsrBHve0I/HT6lMSQKyNjNoRG4Hbjvi7tdqR7Ioxeo2De TXZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=AUcyE5w1fmlw8/MXs/7Sn1t4G/rDhT8JDa1unr3pUXs=; b=TqME5yVDMvb1hQ5k/cgWzFEUu4yy8o5pjGQOW1CmP2rnkUqXPsuJT/ti9OFbb/6pCO bEpJCpVOSpoxKFukzIZkz+5WEuviBrJlE6AqRDkdh1gXY9DKoSHTq0pVt58YAzxZqnlL LMi04ArNQ2NLIG47TgThOnlofiwcRsV3Id7pmJ9BxSjcUdz/25G5//i7fX/oERMmjMjl rIFaKVpLuaYFteBv1D5lCN9kIShGXJZNG6SW3uCSi84w2Sjy2RwQmzJ03u8wyN9wF7w0 0wN6/xkN57m/UGak9bDXiIGp5uiuGpo6g6/IWJt63sz47tQlCUjONS/X1jWxtNiFmrWH /crA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j70si4212424pgd.57.2022.01.24.01.42.24; Mon, 24 Jan 2022 01:42:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237683AbiAWPbs (ORCPT + 99 others); Sun, 23 Jan 2022 10:31:48 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:53113 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237676AbiAWPbr (ORCPT ); Sun, 23 Jan 2022 10:31:47 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B5981FF802; Sun, 23 Jan 2022 15:31:42 +0000 (UTC) Date: Sun, 23 Jan 2022 16:31:40 +0100 From: Miquel Raynal To: Miaoqian Lin Cc: Paul Cercueil , Harvey Hunt , Richard Weinberger , Vignesh Raghavendra , linux-mips@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: ingenic: Fix missing put_device in ingenic_ecc_get Message-ID: <20220123163140.557a251b@xps13> In-Reply-To: <20220123152332.529757-1-miquel.raynal@bootlin.com> References: <20211230072751.21622-1-linmq006@gmail.com> <20220123152332.529757-1-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org miquel.raynal@bootlin.com wrote on Sun, 23 Jan 2022 16:23:32 +0100: > On Thu, 2021-12-30 at 07:27:51 UTC, Miaoqian Lin wrote: > > If of_find_device_by_node() succeeds, ingenic_ecc_get() doesn't have > > a corresponding put_device(). Thus add put_device() to fix the exception > > handling. > > > > Fixes: 15de8c6 ("mtd: rawnand: ingenic: Separate top-level and SoC specific code") > > Signed-off-by: Miaoqian Lin > > Reviewed-by: Paul Cercueil > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Pushed on mtd/fixes, actually.