Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 23 Jan 2022 16:44:41 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     kyungmin.park@samsung.com, richard@nod.at, vigneshr@ti.com,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mtd: onenand: Check for error irq
Message-ID: <20220123164441.4ac98b08@xps13>
In-Reply-To: <20220104162658.1988142-1-jiasheng@iscas.ac.cn>
References: <20220104162658.1988142-1-jiasheng@iscas.ac.cn>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Jiasheng,

jiasheng@iscas.ac.cn wrote on Wed,  5 Jan 2022 00:26:58 +0800:

> For the possible failure of the platform_get_irq(), the returned irq
> could be error number and will finally cause the failure of the
> request_irq().
> Consider that platform_get_irq() can now in certain cases return
> -EPROBE_DEFER, and the consequences of letting request_irq() effectively
> convert that into -EINVAL, even at probe time rather than later on.
> So it might be better to check just now.
> 
> Fixes: 2c22120fbd01 ("MTD: OneNAND: interrupt based wait support")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---

Applied to nand/next.

Thanks,
Miquèl