Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 23 Jan 2022 11:57:43 -0800
From:   Cong Wang <xiyou.wangcong@gmail.com>
To:     ycaibb <ycaibb@gmail.com>
Cc:     davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
        kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net,
        andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org
Subject: Re: [PATCH] inet: missing lock releases in udp.c
Message-ID: <Ye2zN0R/R9uKEUNa@pop-os.localdomain>
References: <20220121031553.5342-1-ycaibb@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220121031553.5342-1-ycaibb@gmail.com>
Precedence: bulk

On Fri, Jan 21, 2022 at 11:15:53AM +0800, ycaibb wrote:
> From: Ryan Cai <ycaibb@gmail.com>
> 
> In method udp_get_first, the lock hslot->lock is not released when afinfo->family == AF_UNSPEC || sk->sk_family == afinfo->family is true. This patch fixes the problem by adding the unlock statement.
> 

It should be unlocked by udp_seq_stop(). Do you see any real lockdep
warning or bug report?

Thanks.