Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 24 Jan 2022 09:45:43 +0900
From:   Stafford Horne <shorne@gmail.com>
To:     Kuniyuki Iwashima <kuniyu@amazon.co.jp>
Cc:     benh@amazon.com, jonas@southpole.se, kuni1840@gmail.com,
        linux-kernel@vger.kernel.org, openrisc@lists.librecores.org,
        stefan.kristiansson@saunalahti.fi
Subject: Re: [PATCH] openrisc/boot: Remove unnecessary initialisation in
 memcpy().
Message-ID: <Ye32t5ZccUwfa+ag@antec>
References: <Ye3keps4aHhkbYzr@antec>
 <20220124000249.4295-1-kuniyu@amazon.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220124000249.4295-1-kuniyu@amazon.co.jp>
Precedence: bulk

On Mon, Jan 24, 2022 at 09:02:49AM +0900, Kuniyuki Iwashima wrote:
> From:   Stafford Horne <shorne@gmail.com>
> Date:   Mon, 24 Jan 2022 08:27:54 +0900
> > On Sun, Jan 23, 2022 at 11:01:00AM +0900, Kuniyuki Iwashima wrote:
> > > 'd' and 's' are initialised later with 'dest_w' and 'src_w', so we need not
> > > initialise them before that.
> > > 
> > > Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
> > 
> > This looks fine to me.  I will queue this for the next release.
> 
> Thank you.
> 
> 
> > 
> > Just curious why are you working on OpenRISC?
> 
> While reading memcpy() variants, I found a nit to fix in x86 boot-time
> memcpy() [0].  While I'm at it, I just started reading all arch ones ;)
> 
> [0]: https://lore.kernel.org/lkml/20220123015807.45005-1-kuniyu@amazon.co.jp/

Got it.

Thanks again!