Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1642960861.git.leonro@nvidia.com> <8bdb652b01f2316bc57b456fb8c60bfbffe6cc64.1642960861.git.leonro@nvidia.com>
In-Reply-To: <8bdb652b01f2316bc57b456fb8c60bfbffe6cc64.1642960861.git.leonro@nvidia.com>
From:   Zhu Yanjun <zyjzyj2000@gmail.com>
Date:   Mon, 24 Jan 2022 09:19:26 +0800
Message-ID: <CAD=hENc7UV4er4b3MwFJPRuJCBpFv46aEbG8zbnEPdE3ORQLjA@mail.gmail.com>
Subject: Re: [PATCH rdma-next 08/11] RDMA/rxe: Delete useless module.h include
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Jason Gunthorpe <jgg@nvidia.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        Christian Benvenuti <benve@cisco.com>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        LKML <linux-kernel@vger.kernel.org>,
        RDMA mailing list <linux-rdma@vger.kernel.org>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
        Nelson Escobar <neescoba@cisco.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        Yishai Hadas <yishaih@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 24, 2022 at 2:03 AM Leon Romanovsky <leon@kernel.org> wrote:
>
> From: Leon Romanovsky <leonro@nvidia.com>
>
> There is no need in include of module.h in the following files.
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>

Thanks a lot.
Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Zhu Yanjun

> ---
>  drivers/infiniband/sw/rxe/rxe.h      | 1 -
>  drivers/infiniband/sw/rxe/rxe_mmap.c | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe.h b/drivers/infiniband/sw/rxe/rxe.h
> index fb9066e6f5f0..30fbdf3bc76a 100644
> --- a/drivers/infiniband/sw/rxe/rxe.h
> +++ b/drivers/infiniband/sw/rxe/rxe.h
> @@ -12,7 +12,6 @@
>  #endif
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> -#include <linux/module.h>
>  #include <linux/skbuff.h>
>
>  #include <rdma/ib_verbs.h>
> diff --git a/drivers/infiniband/sw/rxe/rxe_mmap.c b/drivers/infiniband/sw/rxe/rxe_mmap.c
> index 035f226af133..9149b6095429 100644
> --- a/drivers/infiniband/sw/rxe/rxe_mmap.c
> +++ b/drivers/infiniband/sw/rxe/rxe_mmap.c
> @@ -4,7 +4,6 @@
>   * Copyright (c) 2015 System Fabric Works, Inc. All rights reserved.
>   */
>
> -#include <linux/module.h>
>  #include <linux/vmalloc.h>
>  #include <linux/mm.h>
>  #include <linux/errno.h>
> --
> 2.34.1
>