Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <bd5a0d5ac47c4b139ef5eaaaa9dd8a4e5429516f.camel@nxp.com>
Subject: Re: [PATCH v2] phy: dphy: Correct clk_pre parameter
From:   Liu Ying <victor.liu@nxp.com>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        linux-phy@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-imx@nxp.com,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Maxime Ripard <mripard@kernel.org>,
        Guido =?ISO-8859-1?Q?G=FCnther?= <agx@sigxcpu.org>
Date:   Mon, 24 Jan 2022 10:31:48 +0800
In-Reply-To: <Ye3TbIj5LMvGVRIg@pendragon.ideasonboard.com>
References: <20220119023714.1498508-1-victor.liu@nxp.com>
         <Ye3TbIj5LMvGVRIg@pendragon.ideasonboard.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUxSaDFvVlBOYk1nTlpJcWRyZWZVV2RqbkVLYWFlR3JPMFI3Wi8rbHVHRnp5?=
 =?utf-8?B?UCs3WUp0OUtvVDlZajFJVDY5dWI0ZGxpdDVRMit5RGc2T2YwZlBoUndPanJy?=
 =?utf-8?B?aTUzK2VzMnBnVHdmZURocHlWaG0wS3lsT2lvQjNuUHVnTHlOVTJjUUhHMkN2?=
 =?utf-8?B?N3REMjVmcGFRZnlNRXhueWV5MEVRMUxYR2tMdUFzZmVMSjNYYkFjQlhqbC9D?=
 =?utf-8?B?TDhSNWFOTE5CSVJhOEdDUXB4a2xhbXVZbkZBa0JSZ0d0NnhKT2NkZWxrS0F6?=
 =?utf-8?B?WEtnSjEwR1VOYUFDRGcvSkNQSjRuNXV0L05rUTVISFFWeXVQMVJkaWhsR0hE?=
 =?utf-8?B?amJnYWFrZUZ5WUFtb2xhaGdjR1VjU3RERDg0VXpnN3p3WXdEb3h2VVBqVWRR?=
 =?utf-8?B?N25TdWJQb3kwdk9LUXB2WjFkM1ZOeG90ZEZLbThNdEtCeFFwczZyOWFOK1JX?=
 =?utf-8?B?cmFBbE84bEpBREEvT29wZ0ZnRmJCbXBxcEVzWGRrUDczRkxpVnBxRXpnYlhr?=
 =?utf-8?B?T256Qmdmb2RJcjhKMFR2TWVpbnNDbktodDFQN09KbGloRCt1dTh3Z2hzd3hw?=
 =?utf-8?B?LzVia3VXRkhMMlAwdElSUTdCVnR6c2JYbUJ0Q2JMZXUyNExYY2JUOGxEaUFP?=
 =?utf-8?B?U2dxUCsyd3hiemk5SXprZ3R4b0FubTFKK0pnYy8xWjkrQVQzUXFsdmx2WG9C?=
 =?utf-8?B?eFpHaFRnYW0vVHlkaWQ1Qi9TVXl5Y1dVOVF5Um5icUhFNDJrWTNocGZmS1dH?=
 =?utf-8?B?QWpCVHNOYlZxcitmYVlGKzJGdHZUTVRVSWJWUm81NHBHQWwyRTB0TlRaMW53?=
 =?utf-8?B?RUs5czk1emJ0WVo5dENVU3hjVUdNeHR5ZEFpVklMd3IwdmM1NnR2OFZUcHlk?=
 =?utf-8?B?QWRzeDQ1Q3l6OEJ4Ly8rVGRZN09NWTYwSUhrS2RyNDU5S0s1TzA1QmoyZ2Nl?=
 =?utf-8?B?T0lTV0lnYWFYZU9iRHQ0ZjJYcHpUcTdMOWU1ZlB2aDVwY1dGTERBMUluTEtp?=
 =?utf-8?B?WHdJeHN6SzE4YVZCamtmVEdHUVh2aDNBcU5Jcy9oT01ydmJRWm9hbXRhdzJy?=
 =?utf-8?B?MG4vTzVQbmJYbmxNV1Y5RVJvK3BBT1R3VTQxTWwwbytLOS9iR1F5SUVnWVJT?=
 =?utf-8?B?RUh6blVMRTkyeWIvcFdPcTVOTXIyekxFNnYrK2pWdkdJV2QxeEEreFlvaWRX?=
 =?utf-8?B?YVpMTGc2TVNCcXJ6TGZxVkYyaEpoMkpLeDRwYWx3TlI5ZndxbWNQTEdLSk5B?=
 =?utf-8?B?Z29VNlI0RnlESDAwZDF2TTU4ZlZLbGxodkhaOWUyaU5aN1NOYkNVT1J5c1gr?=
 =?utf-8?B?Q0JVYkViamZWV0x2M3RvVDZxaDQzb2sxUG50R2krR2FlY0ZDNmRpV0ZwWTQy?=
 =?utf-8?B?czhCdzBodE1BUUdPWGdMUDFkMlp5UThTV2JiVjNEYVVMNzdqNW8wWjVySVU4?=
 =?utf-8?B?M2trVEVCM2RqcU9WQjd1N3hCejByZktLUEloanY0QzNTSXlyRk41U2FiVCtX?=
 =?utf-8?B?RTdXeEE1WEh3b3F2VlNiOVFNS3ErcWx6YUNCS29kUVF1OHF0YnlZZWZTNGN6?=
 =?utf-8?B?dDZIM083VWtoN1VqMmltcFFFUmt5eHRZelZESnY4anJmcXlFTlBqRnFXMjVX?=
 =?utf-8?B?bjE0aTJiRjhPd2NPcmFhUFNaTVNoWUoxQ01PdGU5TGFpTmwwU0RFV0ljVG9p?=
 =?utf-8?B?WHVxeTQxZmM3MStKU2dLRGNpOVF3Q2prVlo0eDVqUVJFeDJKenNsQWtkTEpx?=
 =?utf-8?B?R0RqMDVyM0ovUHFXWHRHaUlYaTZTcHJFbzk3UzRaamxjUWRDUVdwdXEzSVh5?=
 =?utf-8?B?WHlFMFdubE9sVGU5OXlreG9QbVZVRXFINGRKU0M2Q2ZieVArRGdzcGRhWE9l?=
 =?utf-8?B?M3RTZEZYNWlLcXVwZ3h2Z2grb0k4eSt2ZkRUV1JlZGJkekt6SWk0b2pTbjVn?=
 =?utf-8?B?Rzg3YzZIZlVHWDVWWFB2TkQyRlEwNE4xdk9EMWxxVlhiS3lCejlDNmhCV3pp?=
 =?utf-8?B?ZEVSa09PajVMOGZ5cVZzcWtMZE1MNG8yK1F2NWRGeVdvZUlXMDY0aFh5Smt5?=
 =?utf-8?B?bk01QVA2MmlwbkZOaEV5TFN2Y0ZTVDdDdlZHUzFrM0o1RUo1eWVFV0h0MWtn?=
 =?utf-8?B?OWpDZG0zT2dXQmlMMDMzN0FseTAzbG1iU203RjFpNEs1QWtrL09iUmJxVTh3?=
 =?utf-8?Q?j4qPRy9s4x0bjuewAyKrV14=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f41d4da6-84b4-4fcc-eb3d-08d9dee1b390
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 02:32:01.3136
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XdzrtOtzOKrY1IZtC6UFe1MNxwE3muhqW2Hasmzp2nsLyAjhvgMBDxHfka1s95OvRgv4U/9dbCtB+yeQmqX+2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4925
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Laurent,

On Mon, 2022-01-24 at 00:15 +0200, Laurent Pinchart wrote:
> Hi Liu,
> 
> Thank you for the patch.

Thank you for your review.

> 
> On Wed, Jan 19, 2022 at 10:37:14AM +0800, Liu Ying wrote:
> > The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE
> > parameter's unit is Unit Interval(UI) and the minimum value is 8.  Also,
> > kernel doc of the 'clk_pre' member of struct phy_configure_opts_mipi_dphy
> > mentions that it should be in UI.  However, the dphy core driver wrongly
> > sets 'clk_pre' to 8000, which seems to hint that it's in picoseconds.
> > And, the kernel doc of the 'clk_pre' member wrongly says the minimum value
> > is '8 UI', instead of 8.
> 
> I'm not sure I'd change the kernel doc. Other fields that are documented
> as "Time, in picoseconds" have min/max values expressed in ps, so
> clk_pre, documented as "Time, in UI" doesn't appear wrong if the minimum
> value is "8 UI".
> 
> Otherwise, this patch looks fine to me. With or without dropping that
> documentation change,

I'll drop the documentation change in v3.

Regards,
Liu Ying

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>