Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3423204pxb; Mon, 24 Jan 2022 09:14:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJzqUAGIocOaQeT6nNj7rTZ0NJI6euXxugRmYlHKo9Ld2t7YPFDsMZFWUxCSNAGWP2WsClnm X-Received: by 2002:a63:6f4d:: with SMTP id k74mr12697953pgc.208.1643044457856; Mon, 24 Jan 2022 09:14:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643044457; cv=none; d=google.com; s=arc-20160816; b=wUmvhSqN94GoLgLYfoYXQjaWyteZW8L24asGDTu9As9lkNmo4/ocSXP8YgJo8ujm0s ogysy1KJuXFSA4Xd3pggfG9xGWiWIOo+mzwutXzuZzfBdFHDQuo4opKRzFb7nFtHiVDv 1jVVE8FuAxau+4idGhQ/JmU/bf92d9+0+QqODd1OI4OL/+wR2+I6Dht89+XUZr1hNBgm EEMGpyUJQmzV/UmzAevtWNFeCAoOa4qTH20tboLGkrQt3ckxlaJLFX7fNpbRQzn3/36s Y4Jbz6znDk5Ix22a7G+AtoTgS+Xfkrr+TDlVqRLkGDnZA/QLVeqoJhfwnxcuqQm4PYSb uqtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=MIM60s4tAiF9UDbYw7wCR9aHp3ge6T0H7rnBJQUDjhA=; b=l8SLPNs6IOwIYxlJMjecr4JUjOUnVNJ6Ok1NkIgxi6lCjAk/swEH8dR8idgFwOk626 2lvK5ZvWWXiAMWjnuaLNW2M0MkZnfR8EVWKaR+xYmvY4SS9m+OQcNxhJohLsIM+IKS97 87GNQYsfI1AHApoKTF/DqPan8kHPVTMH8ggWnnVwzLEkaUSm7JInAGLlNPR6O5SG3dOA GdfchCrdu/E3fDSh/zUIqT2Uzdkxt6vBHIpacuvzJus5rPNUBK08n3aSWSOjLP3bEfMR emsqA2kRFOnBDzf1jPvkjxz0D6PWllfHXrzqyjxdhC1MmpQAAZyzWC+QcC2mV0nJ7O92 j1uA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a1si2216584plp.572.2022.01.24.09.14.05; Mon, 24 Jan 2022 09:14:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238780AbiAXFUp (ORCPT + 99 others); Mon, 24 Jan 2022 00:20:45 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:52406 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229505AbiAXFUo (ORCPT ); Mon, 24 Jan 2022 00:20:44 -0500 X-UUID: c5fbe735f43a44eaa7e4570e7da97fac-20220124 X-UUID: c5fbe735f43a44eaa7e4570e7da97fac-20220124 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2101492939; Mon, 24 Jan 2022 13:20:40 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Mon, 24 Jan 2022 13:20:38 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 24 Jan 2022 13:20:38 +0800 From: Miles Chen To: CC: , , , , , , , , Subject: Re: [PATCH] clk: mediatek: add unregister logic to mtk_clk_simple_probe error path Date: Mon, 24 Jan 2022 13:20:38 +0800 Message-ID: <20220124052038.6242-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220117090030.13064-1-miles.chen@mediatek.com> References: <20220117090030.13064-1-miles.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, > Stephen pointed out that there is no unregister logic in > mtk_clk_simple_probe() error path [1]. > Fix it by adding unregister logic to mtk_clk_simple_probe(). Chen-Yu's work [1] already addresses this problem. So please ignore this patch. [1] https://lore.kernel.org/lkml/20220122091731.283592-1-wenst@chromium.org/