Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3507619pxb; Mon, 24 Jan 2022 11:01:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJz29MlaDB0lWud5CcytpMdScW5HDrIUzo+m8QHYjSjMAk4HPQ/eRXy3MdUpXZ6i9oP7I5SW X-Received: by 2002:a63:e60c:: with SMTP id g12mr12703245pgh.98.1643050893612; Mon, 24 Jan 2022 11:01:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643050893; cv=none; d=google.com; s=arc-20160816; b=CEW0afkRWMBFbA94PgKodZlGZqNAtBBbAomy2lBTXcK9vsXkRedQeaEidmcIIN+I08 R5Ih16BYBRJOfQI4PHmc/FlUdFNTCxsrCLeoB8a6Q2BToJDOOMd79RZYXlE+zvNdx69j vBc8cMYvRWOlHz/NtydDcQrnTFloCa8lFd2/GDWY32r+IuRXCASX6Fw29iTf7tJBGSFA Ia4C22NYcE5dhQRIZXXevZPXWs2/NCFwgpdjjm91YqDeVMxKuXZ4Yskwd1ofQLZ8Fki8 OKYnIt2BY6eBRBdO9oDqStbVrIwd4Mf4yIibKDHmJpM5595ZIwaIoItoC9jisfkjzNaI aKlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ozch8HrX4C1bhjgWt6yLLsNfPoxAFoky3u5sMNeaHFU=; b=fe/N4wCOR/da3tihgEC+ptuiavsDNhKGVsley+toYM1LLPbl5nL2Z1EQdARhBB0GIz R6BRBuGCTf3dBQB6CkvZwFFxkVcfLkTSMFZ/jEqaAOH5gaPEdWtzkIoNzfq0cChkZqEr KaZHUPmnAfgAxvP/9Fpaizm5Q3tQnjootqMvpOeOaSxASrqAp5q8pGn4wGH3fughnPI+ 14EOjD4bqd8hM2pc31lLykSIijkPcdZelr+xcHSx0qyjN8OeWUN2+pT2/6DaSIRyg1WL 38TU0T5I6QEGIvaiQWPn+OFvRSzLaoQYhivMEOH1GFbXcjtfEoAeNHe55maiTzDmIKCm MMbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n18si15219321plh.508.2022.01.24.11.01.18; Mon, 24 Jan 2022 11:01:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236878AbiAXJ4O (ORCPT + 99 others); Mon, 24 Jan 2022 04:56:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234706AbiAXJ4M (ORCPT ); Mon, 24 Jan 2022 04:56:12 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85ABAC06173B for ; Mon, 24 Jan 2022 01:56:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 20DDA61251 for ; Mon, 24 Jan 2022 09:56:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03F97C340E1; Mon, 24 Jan 2022 09:56:08 +0000 (UTC) Date: Mon, 24 Jan 2022 09:56:05 +0000 From: Catalin Marinas To: Evgenii Stepanov Cc: Will Deacon , Mark Rutland , Ard Biesheuvel , Robin Murphy , Jisheng Zhang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: extable: fix null deref in load_unaligned_zeropad. Message-ID: References: <20220122023447.1480995-1-eugenis@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220122023447.1480995-1-eugenis@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 21, 2022 at 06:34:47PM -0800, Evgenii Stepanov wrote: > ex_handler_load_unaligned_zeropad extracts the source and data register > numbers from the wrong field of the exception table. Could you please also include the stack dump if you get one from the null pointer dereference? > Fixes: 753b3236 This should be expanded: Fixes: 753b32368705 ("arm64: extable: add load_unaligned_zeropad() handler") Cc: # 5.16.x Thanks. -- Catalin