Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3508955pxb; Mon, 24 Jan 2022 11:02:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJz/TbqtWsxBR6xvd6t0n8+cOinFhKVQ32AMReive28iYMGh5Z2uimoi4alb/tJs1XZX45w7 X-Received: by 2002:a63:575c:: with SMTP id h28mr12426021pgm.171.1643050976680; Mon, 24 Jan 2022 11:02:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643050976; cv=none; d=google.com; s=arc-20160816; b=dYvUyz+OnLSnb+axdcbLPPLQ4Prn8YPVHiw0AraKaqmgcUsKm9BRrS0owa8TqksWTF vPGph48nZD0y/9duQktA5/K9q0XDD4V72nG2UPap0aK6GyB8vKkYObLCUNceownVPdlX zw7lIdjLdfJhaRW/2DbL6TaIgHhFgEyQjPf8KtoUYDBGxU1UZhsDJXh7KUl9qrBvGpbr WyzozstJpKsBDsWIMNSgGnK4iFMNamcMbq2p09dHfhSaO1M579EgD/6/h8wWh8bQz9rh XiNv4Sc19Qx88kT7ANxtNXaKb7BIoKjbfVCvEIbQmRFbxDqtsmwBxEwnCtYBtGrVEM1T NF4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BMEd9rbFZe/L5t9dVkX24nilGNsAVv7tpeWV7JNZjrA=; b=a6TzhNxGrQWiE8NbzW//N9gZ597QayfM9ibChsLxme8ZA9QBk33XQFHBZCQu0yK54W DT/7+X2gFpg4Xinerl4T2oXfwrRi5G2nN/z9YVoUaQhb7DGP4VsHXvwgj31+i17xL+FZ o/z8Tp2Od+hvvgow8bzSJ57dh+NYeaaWrh/K9y3UmcCubAd436HspYbOlASNbkXOCAq0 yuaRoZrxo/ctC71ZjvGyGUvo9RzJeYbgsobdBGVbjpa6v1/Ko8t5ce1KolIseWptUX47 /vzqpQwKxy0zMFb3o65roNnY696KtuTAMUqfJtiCFSaVEjZxo8Sw55vhOSdQwxcBG5RE viJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=Ej24pEQm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x62si5866148pgd.439.2022.01.24.11.02.44; Mon, 24 Jan 2022 11:02:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=Ej24pEQm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231280AbiAXK2G (ORCPT + 99 others); Mon, 24 Jan 2022 05:28:06 -0500 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:55362 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237091AbiAXK2B (ORCPT ); Mon, 24 Jan 2022 05:28:01 -0500 Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20O6jNgh004848; Mon, 24 Jan 2022 11:27:59 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=selector1; bh=BMEd9rbFZe/L5t9dVkX24nilGNsAVv7tpeWV7JNZjrA=; b=Ej24pEQmJI6rtNtRKMDgEQbsLjA6NU7ED3w/50RJCtGUGbf8xJ759bTZNl1brJhPLSIo W1IiwCb+6WoCT0JnTB1rgcYOVwVkq34YHUAslknTZ8LOVkxbjoHVd5YyGbDEb4BPoVqg aHL2Rc5Q7jFzreqwSw8zgyTCAaeHbzYMnxBmzaex+3uJGyUQhtzSGc7cSKw1q17fwutV lwP6vaSZYsiS6CSE8wZGBdV2Ndd8xY4VzNPOHdvn67k14JtSQN/yda8BLlEsqRtofjUC GhTQG0FJBzD3cJ8fCZ0WqagFpCmjJ868stMpeYZkuV1VTuJ/zHOLM6WX3ZADDgj08YLO gA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3ds9v1kcy0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Jan 2022 11:27:59 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 41454100034; Mon, 24 Jan 2022 11:27:59 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 38A4A2128C2; Mon, 24 Jan 2022 11:27:59 +0100 (CET) Received: from localhost (10.75.127.44) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Mon, 24 Jan 2022 11:27:58 +0100 From: Arnaud Pouliquen To: Bjorn Andersson , Mathieu Poirier CC: , , , , Subject: [PATCH v9 11/11] rpmsg: ctrl: Introduce new RPMSG_CREATE/RELEASE_DEV_IOCTL controls Date: Mon, 24 Jan 2022 11:25:24 +0100 Message-ID: <20220124102524.295783-12-arnaud.pouliquen@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220124102524.295783-1-arnaud.pouliquen@foss.st.com> References: <20220124102524.295783-1-arnaud.pouliquen@foss.st.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-24_06,2022-01-24_01,2021-12-02_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Allow the user space application to create and release an rpmsg device by adding RPMSG_CREATE_DEV_IOCTL and RPMSG_RELEASE_DEV_IOCTL ioctrls to the /dev/rpmsg_ctrl interface The RPMSG_CREATE_DEV_IOCTL Ioctl can be used to instantiate a local rpmsg device. Depending on the back-end implementation, the associated rpmsg driver is probed and a NS announcement can be sent to the remote processor. The RPMSG_RELEASE_DEV_IOCTL allows the user application to release a rpmsg device created either by the remote processor or with the RPMSG_CREATE_DEV_IOCTL call. Depending on the back-end implementation, the associated rpmsg driver is removed and a NS destroy rpmsg can be sent to the remote processor. Suggested-by: Mathieu Poirier Signed-off-by: Arnaud Pouliquen Reviewed-by: Mathieu Poirier --- drivers/rpmsg/rpmsg_ctrl.c | 36 ++++++++++++++++++++++++++++++++---- include/uapi/linux/rpmsg.h | 10 ++++++++++ 2 files changed, 42 insertions(+), 4 deletions(-) diff --git a/drivers/rpmsg/rpmsg_ctrl.c b/drivers/rpmsg/rpmsg_ctrl.c index f43b5e4dbb4c..107da70fdbaa 100644 --- a/drivers/rpmsg/rpmsg_ctrl.c +++ b/drivers/rpmsg/rpmsg_ctrl.c @@ -43,11 +43,13 @@ static DEFINE_IDA(rpmsg_minor_ida); * @rpdev: underlaying rpmsg device * @cdev: cdev for the ctrl device * @dev: device for the ctrl device + * @ctrl_lock: serialize the ioctrls. */ struct rpmsg_ctrldev { struct rpmsg_device *rpdev; struct cdev cdev; struct device dev; + struct mutex ctrl_lock; }; static int rpmsg_ctrldev_open(struct inode *inode, struct file *filp) @@ -76,9 +78,8 @@ static long rpmsg_ctrldev_ioctl(struct file *fp, unsigned int cmd, void __user *argp = (void __user *)arg; struct rpmsg_endpoint_info eptinfo; struct rpmsg_channel_info chinfo; - - if (cmd != RPMSG_CREATE_EPT_IOCTL) - return -EINVAL; + struct rpmsg_device *rpdev; + int ret = 0; if (copy_from_user(&eptinfo, argp, sizeof(eptinfo))) return -EFAULT; @@ -88,7 +89,33 @@ static long rpmsg_ctrldev_ioctl(struct file *fp, unsigned int cmd, chinfo.src = eptinfo.src; chinfo.dst = eptinfo.dst; - return rpmsg_chrdev_eptdev_create(ctrldev->rpdev, &ctrldev->dev, chinfo); + mutex_lock(&ctrldev->ctrl_lock); + switch (cmd) { + case RPMSG_CREATE_EPT_IOCTL: + ret = rpmsg_chrdev_eptdev_create(ctrldev->rpdev, &ctrldev->dev, chinfo); + break; + + case RPMSG_CREATE_DEV_IOCTL: + rpdev = rpmsg_create_channel(ctrldev->rpdev, &chinfo); + if (!rpdev) { + dev_err(&ctrldev->dev, "failed to create %s channel\n", chinfo.name); + ret = -ENXIO; + } + break; + + case RPMSG_RELEASE_DEV_IOCTL: + ret = rpmsg_release_channel(ctrldev->rpdev, &chinfo); + if (ret) + dev_err(&ctrldev->dev, "failed to release %s channel (%d)\n", + chinfo.name, ret); + break; + + default: + ret = -EINVAL; + } + mutex_unlock(&ctrldev->ctrl_lock); + + return ret; }; static const struct file_operations rpmsg_ctrldev_fops = { @@ -125,6 +152,7 @@ static int rpmsg_ctrldev_probe(struct rpmsg_device *rpdev) dev->parent = &rpdev->dev; dev->class = rpmsg_class; + mutex_init(&ctrldev->ctrl_lock); cdev_init(&ctrldev->cdev, &rpmsg_ctrldev_fops); ctrldev->cdev.owner = THIS_MODULE; diff --git a/include/uapi/linux/rpmsg.h b/include/uapi/linux/rpmsg.h index f5ca8740f3fb..1637e68177d9 100644 --- a/include/uapi/linux/rpmsg.h +++ b/include/uapi/linux/rpmsg.h @@ -33,4 +33,14 @@ struct rpmsg_endpoint_info { */ #define RPMSG_DESTROY_EPT_IOCTL _IO(0xb5, 0x2) +/** + * Instantiate a new local rpmsg service device. + */ +#define RPMSG_CREATE_DEV_IOCTL _IOW(0xb5, 0x3, struct rpmsg_endpoint_info) + +/** + * Release a local rpmsg device. + */ +#define RPMSG_RELEASE_DEV_IOCTL _IOW(0xb5, 0x4, struct rpmsg_endpoint_info) + #endif -- 2.25.1