Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Message-ID: <trinity-263c703e-80d0-4663-9a42-21b9b7cb57e5-1643024983188@3c-app-gmx-bs10>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Sascha Hauer <sha@pengutronix.de>
Cc:     Frank Wunderlich <linux@fw-web.de>,
        linux-rockchip@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Peter Geis <pgwipeout@gmail.com>,
        Johan Jonker <jbx6244@gmail.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Aw: Re: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Bananapi R2
 Pro
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 24 Jan 2022 12:49:43 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <20220124110331.GZ23490@pengutronix.de>
References: <20220123135116.136846-1-linux@fw-web.de>
 <20220123135116.136846-3-linux@fw-web.de>
 <20220124083102.GW23490@pengutronix.de>
 <trinity-2e9cf5db-4c9b-4ad7-b684-74541e639edf-1643014505272@3c-app-gmx-bs10>
 <20220124110331.GZ23490@pengutronix.de>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

> Gesendet: Montag, 24. Januar 2022 um 12:03 Uhr
> Von: "Sascha Hauer" <sha@pengutronix.de>

> On Mon, Jan 24, 2022 at 09:55:05AM +0100, Frank Wunderlich wrote:

> > took this from the 3568-EVB (like the most parts, as the board is
> > mostly the same), and in linux it's the same and working. The switch
> > have also phy-id 0 on mdio bus #1, are you sure this is invalid?

just to clarify: in linux dts only the basics were taken from evb and chan=
ged if
needed (like iodomain, regulators).
mixed this with the barebox submsission where i mainly used the evb dts.

should i add a note in head that some parts are taken from EVB and vendors=
 dts?
As this is my first new DTS, i want to be sure the legal notice is correct=
.

> It's not invalid, it's just the broadcast address to which other phys
> might answer as well. Anyway, as long as there's only a single phy on
> the bus it's probably okay.

ok, on mdio0 there is the rtl8211 phy and on mdio1 there is the rtl8367rb =
switch,
so only 1 device per bus. I was not aware that 0 is broadcast.

regards Frank