Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3517330pxb; Mon, 24 Jan 2022 11:13:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwFp4cOh+EY7T/fqAi8pYh82feXgiYtJzOi+qr0mYfTatW81hgTjwDADuliC5JXNlas67OB X-Received: by 2002:a17:90b:1103:: with SMTP id gi3mr3346980pjb.177.1643051580235; Mon, 24 Jan 2022 11:13:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643051580; cv=none; d=google.com; s=arc-20160816; b=iTlVLLFqFWpN9q+7mp06tAlPtn0s5/6WFcTFXWeLBGe3axOybXTUGyoTW15AV9iwZy PZfZbfaaXsgesZZtQG/lpB/SDh3c7iJj2OJzJKtQzvlyXm7iIz3Zy/TrSAMaf79D55vs WT5E0XxOvKJi41gO256CI7HGMzHGjbU7qlP/7n5YUeCCU6vwbQpio3buQIv1UbAs5wMJ 6RZXKbbK2H5bhgZZ0vvLncHhusyuEcHqZBvDno1wonYYUEHXgP+651rcamNzZCtvDAsp xHbMMKxKxIJk4y+Bq+MtEA++ClxdsJpu7rp50imlxWyOhJjAtYcWQnlUxUoTZUqjGQ8l Lr5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IbHTPLPHKOYCbcyVROJGgzAPAFeL2yNA4XHtT8dzIss=; b=hbLQ2+oV5TBcFg0JDn3S8euB1MMY/jGHpIZLFUlgyFfPXwDLR7XOsmoqG1aOHwFCWi ku1NZjvGqfWdO6d6tONRlJQ0yy1eCHxQPlqXa+RFZC8+YYbAatQB0eGW0ouySim9dUiN KGlAqYykk3eMYUfoBBW/Gv91tEc9ri8oMvUs/L5+FvDbGKJIdGIz/qhXlN/ktUNN9yWS tuOXJtJH5C1fVJBn5IsVNxoqVE41uOenpjsR9SC09NzKK7sXJangSO/bqE1ea9DZJsMW fS8u0+JMkvnRhDDwJspbbhkqudfNB8ZtIenqdf6Sco6aTwnhDgPRVvFIO00YGpMj125Z eeFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=VgDBa8Mo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j5si149795pjy.137.2022.01.24.11.12.47; Mon, 24 Jan 2022 11:13:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=VgDBa8Mo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239405AbiAXM24 (ORCPT + 99 others); Mon, 24 Jan 2022 07:28:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241058AbiAXM2z (ORCPT ); Mon, 24 Jan 2022 07:28:55 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C99CCC06173B for ; Mon, 24 Jan 2022 04:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IbHTPLPHKOYCbcyVROJGgzAPAFeL2yNA4XHtT8dzIss=; b=VgDBa8Mobdswrma4rOB/+beByN 1hbVBymHCUWWIYIwcEdJVU2Jk2sbb6vZjEw4URDJtioZ0v09lm8oiIq++yjnfywyPv6eC5uSn47cV 1BGoOcehpVd2+xJxNrauEJ3uGg56aA1ZfoiC2o7/TDPla2nX6fIRcxUMW0oXPQzmLX9HLZ/D01ETx mjfBdszvAQLjq9zge91Bsr/swMonOBOa/oO2uMBhY7IWdjQTBLfF6y09M3bqn+I7dhqnf6UFRH2xR tEBjlpIJjROfrx8Bk2Ddb9zUy6qCMgtj+GVtMJykI7rvZ2eGM0o7jhRJtF1vy3PiAVX97ED1Pba5s RMua2nQw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBySr-003HBY-Gw; Mon, 24 Jan 2022 12:28:53 +0000 Date: Mon, 24 Jan 2022 04:28:53 -0800 From: Christoph Hellwig To: ira.weiny@intel.com Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] highmem: Document kunmap_local() Message-ID: References: <20220124013045.806718-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220124013045.806718-1-ira.weiny@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 23, 2022 at 05:30:44PM -0800, ira.weiny@intel.com wrote: > + * __addr is often an address returned from kmap_local_page(). However, > + * this address can be any address within the mapped page. It does not need to > + * be the exact address returned from kmap_local_page() > + */ I'd word this a little different: > + * __addr is often an address returned from kmap_local_page(). However, > + * this address can be any address within the mapped page. It does not need to > + * be the exact address returned from kmap_local_page() > + */ * @__addr can be any address within the mapped page. Commonly it is the * address return from kmap_local_page(), but it can also include offsets. But documenting this definitively is a good idea!