Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 24 Jan 2022 15:45:30 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Alexander Aring <aahringo@redhat.com>,
        "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        kernel test robot <lkp@intel.com>, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, David Teigland <teigland@redhat.com>,
        cluster-devel <cluster-devel@redhat.com>,
        linux-sparse@vger.kernel.org, rcu@vger.kernel.org
Subject: Re: fs/dlm/midcomms.c:913:22: sparse: sparse: restricted __le32
 degrades to integer
Message-ID: <20220124124530.GS1951@kadam>
References: <202201221028.YKA8kSdm-lkp@intel.com>
 <CAK-6q+h_hb94J3DSXPk=E44kCxiwZ+BE3kMJe09iShRzMb=vzQ@mail.gmail.com>
 <91901e7b-7d82-116c-aaf2-c74c6a6b999c@infradead.org>
 <CAK-6q+j2jc3pBmbvQ-DCmxveC-UMV75SFc2nC1zwXKe9wm4YPg@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK-6q+j2jc3pBmbvQ-DCmxveC-UMV75SFc2nC1zwXKe9wm4YPg@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qtNMAB34ubxmFQwNy6RDw9ntOFp9bTidUXsSdAleVJ1RcDzamM4kX7SqardS?=
 =?us-ascii?Q?eS09aZ6omzRvSPK/zAV53B1Nbs0/suIkyP/ayCcvnIQA5AvEXxQ0B/swm4pw?=
 =?us-ascii?Q?1rNB6ft0ACY+TURHxRyUm6kUeODKzrjFgr6Ug0BUZ891Q2Gypi60HcXkbaNq?=
 =?us-ascii?Q?IJ/laKes8grwQFR5UQliBa1GdXUZYpJMrBHD9Mocc6n5MFfCLCDP6HLaqw1j?=
 =?us-ascii?Q?xYt1bgpoH73GuDPNatuy3lFKLvvHCbl3xWMZJPjv6NEFW8MPHsIumQ28lNPr?=
 =?us-ascii?Q?2j5bL5C1hPMjTwj+W6ZGys5B7zOTTDB+C9N311ChOLpnSz1SnYhSZV48tgyq?=
 =?us-ascii?Q?Trbdt4a1kmYt7uuTBT57HANBD2Itp8YgllYCQ63fLCr4OoajVPnsMY7ZDv6V?=
 =?us-ascii?Q?69LGQPA7W7c/9fVEMRJzBnrnixEFmm+A32A76onlcC0JF81CbmLXIUfQvlZM?=
 =?us-ascii?Q?TDTE3ojrE5cgtq6V8A2mQpdKs3mgmSO3Rp/gqQf73Qrh9ncEUMkltPBQv3SY?=
 =?us-ascii?Q?b2qJkIIe1KBjMK802D03yaJtoUa5BcQmjH/bx5Og5UdeN3v5mz6XTkTmZnOb?=
 =?us-ascii?Q?mhkBGrKB3HKOtHb/ulQ8VQDG+6vy81eRI0XaqfrAoojVkZxrVdaP5tLIIUH2?=
 =?us-ascii?Q?TOLQ58bH5Je1fdd2cvjjIfMArVzY7tDXM02tyG+GNq4W6QkZktx675IOfYTe?=
 =?us-ascii?Q?fDSTomrtCegzduFt5OPRj5GuYzZG0DINzvmI5XBAhDVNLbMnpTgtaAMtT3OY?=
 =?us-ascii?Q?2AA6ql3NUQrfq8FWCm4qwp1Flm3XMW8jHESy4Y4fg/M8gqQ9ivAAhLDYmk3t?=
 =?us-ascii?Q?WiDyl3c4QjjSI/9dJbEQh0dPEjqCVVbpLh8/PZ+n+GLgKgvu0bVKte7HL2Y5?=
 =?us-ascii?Q?g+4v4zTtO04GKJOTmqBVubiS6Qe/8SBOvws5tGib4/qZFsudyoZOq8k8RRTe?=
 =?us-ascii?Q?2BE9IeRqyjUjJ3l8SO/jRY5RwReZc7C99nr1S+hA/exqpYQBiwYGOMg49Yba?=
 =?us-ascii?Q?XUrksA3OrR0UsILlcJqtWfib4JFTAfgFkUB7yES+vrDVuRx6GC0BjFZ1yV+Q?=
 =?us-ascii?Q?fhwjYwKou4vkdwtOcxkU/dNaVNb3AZpNK31JqtpTjWytWPA2ToVPBUcCBJpZ?=
 =?us-ascii?Q?obFh4YQvOj7IRzkKl5fg6sqUHXRgq9uLF0ht6Ej9+3qKB6aWcmwJgcqYKonQ?=
 =?us-ascii?Q?gWkHJaZcUlFChwRQORdu9tIDNSHzxFiddpC0tFzqpusGNxbkvq87k+/DcfMx?=
 =?us-ascii?Q?Wss9RpGrmu2/5gV9cgVdQtugBrtj+7igR2s/hep+WZOJjTze05xeSqsZ0u7M?=
 =?us-ascii?Q?2t/u4T9xnnErhhDONePJ3JrJ+QN9Bpi0g1xPVDMvnr7GjHFuGmPhuCrtwxJf?=
 =?us-ascii?Q?Tgr0mbtJl4J9uskTVKjzKIFp8fHidYCUmW+97vJYduszjJN/QdQ23P1pHIG+?=
 =?us-ascii?Q?ZLgCeKxupbkDmFcV6+HJl+/UCIZ45/ezZ6LuMuoSVBTmzKpLRgAUL+IkIOgh?=
 =?us-ascii?Q?nuWkqGlWNdtejBoG1Yl3cuJIkvA9Ae9sgGvM2Cx0BEvzCRuzEf2x+3MMq3qz?=
 =?us-ascii?Q?6QImTQm8zLcEfxMTMduVl8TpjSw5xjbF1n4ncoiC1hLIhxX2m4itVpDEVTfm?=
 =?us-ascii?Q?NmkEw1em5Jb3FAxmD9wxRGt+iKaMKpOfBlP++4sy0aQqgrTRWcaUlZUHxJCQ?=
 =?us-ascii?Q?X2ySLJyO4duaUMi+jPSbGc/o6fM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0eeb727b-a0e7-4042-c179-08d9df37782e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 12:45:58.9816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sL9540FA3GJEeH3vD/1PPykg4qvuXRBs5ugr9U2mHpBTTBryz8xmk4RZ0VQrm4WBQtoAYJhTo3YBql1tXHDfVfe2+Mah1NeviWv0KfKoSvM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3367
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10236 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0
 spamscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201240084
X-Proofpoint-GUID: NjJ2FSWQDrppWJl_4tVn3WS7nwGKclI9
X-Proofpoint-ORIG-GUID: NjJ2FSWQDrppWJl_4tVn3WS7nwGKclI9
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 23, 2022 at 01:41:52PM -0500, Alexander Aring wrote:
> 
> I see also:
> 
> fs/dlm/midcomms.c:213:1: sparse: sparse: symbol
> '__srcu_struct_nodes_srcu' was not declared. Should it be static?
> 

Why not just do this?  (Untested.  Maybe I don't understand?)

diff --git a/include/linux/srcutree.h b/include/linux/srcutree.h
index cb1f4351e8ba..a164089abec4 100644
--- a/include/linux/srcutree.h
+++ b/include/linux/srcutree.h
@@ -121,7 +121,7 @@ struct srcu_struct {
 #ifdef MODULE
 # define __DEFINE_SRCU(name, is_static)					\
 	is_static struct srcu_struct name;				\
-	struct srcu_struct * const __srcu_struct_##name			\
+	is_static struct srcu_struct * const __srcu_struct_##name	\
 		__section("___srcu_struct_ptrs") = &name
 #else
 # define __DEFINE_SRCU(name, is_static)					\