Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220124093912.2429190-1-Qing-wu.Li@leica-geosystems.com.cn> <20220124093912.2429190-3-Qing-wu.Li@leica-geosystems.com.cn>
In-Reply-To: <20220124093912.2429190-3-Qing-wu.Li@leica-geosystems.com.cn>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 24 Jan 2022 15:03:18 +0200
Message-ID: <CAHp75VfC7UzKx1i0aTRTZO2REe=PET3turKzH_iuUzWvTJZOtg@mail.gmail.com>
Subject: Re: [PATCH V1 2/6] iio: accel: sca3300: Add interface for operation modes.
To:     LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Tomas Melin <tomas.melin@vaisala.com>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jan 24, 2022 at 11:39 AM LI Qingwu
<Qing-wu.Li@leica-geosystems.com.cn> wrote:
>
> The acceleration scale and the frequency were set via operation modes,
> the scal and frequency are both non-uniqueness,

scale

> this leads to logic confusion for setting scale.and.frequency.
> it getting worse if add more different sensor types into the driver.

It gets
if you add

> The commit add an interface for set and get the operation modes.
> the following interfaces added:

> in_accel_op_mode_available
> in_op_mode

Please indent them by let's say 2 spaces.

> SCA3300 operation modes table:
> | Mode | Full-scale | low pass filter frequency |
> | ---- | ---------- | ------------------------- |
> | 1    | =C2=B1 3 g      | 70 Hz                     |
> | 2    | =C2=B1 6 g      | 70 Hz                     |
> | 3    | =C2=B1 1.5 g    | 70 Hz                     |
> | 4    | =C2=B1 1.5 g    | 10 Hz                     |

...

> +static const char * const sca3300_op_modes[] =3D {
> +       [OP_MOD_1] =3D "1",
> +       [OP_MOD_2] =3D "2",
> +       [OP_MOD_3] =3D "3",

> +       [OP_MOD_4] =3D "4"

+ Comma.

> +};

...

> +       int mode;
> +       int ret;
> +       struct sca3300_data *data =3D iio_priv(indio_dev);

Here and everywhere else, can we keep reversed xmas tree order?

       struct sca3300_data *data =3D iio_priv(indio_dev);
      int mode;
       int ret;

--=20
With Best Regards,
Andy Shevchenko