Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f23b9a9d-8d37-9863-50cc-0e0c4befafdb@redhat.com>
Date:   Mon, 24 Jan 2022 14:54:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] KVM: remove async parameter of hva_to_pfn_remapped()
Content-Language: en-US
To:     Xianting Tian <xianting.tian@linux.alibaba.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220124020456.156386-1-xianting.tian@linux.alibaba.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <20220124020456.156386-1-xianting.tian@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/24/22 03:04, Xianting Tian wrote:
> The async parameter of hva_to_pfn_remapped() is not used, so remove it.
> 
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
> ---
>   virt/kvm/kvm_main.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 9a20f2299..876315093 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -2463,9 +2463,8 @@ static int kvm_try_get_pfn(kvm_pfn_t pfn)
>   }
>   
>   static int hva_to_pfn_remapped(struct vm_area_struct *vma,
> -			       unsigned long addr, bool *async,
> -			       bool write_fault, bool *writable,
> -			       kvm_pfn_t *p_pfn)
> +			       unsigned long addr, bool write_fault,
> +			       bool *writable, kvm_pfn_t *p_pfn)
>   {
>   	kvm_pfn_t pfn;
>   	pte_t *ptep;
> @@ -2575,7 +2574,7 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool *async,
>   	if (vma == NULL)
>   		pfn = KVM_PFN_ERR_FAULT;
>   	else if (vma->vm_flags & (VM_IO | VM_PFNMAP)) {
> -		r = hva_to_pfn_remapped(vma, addr, async, write_fault, writable, &pfn);
> +		r = hva_to_pfn_remapped(vma, addr, write_fault, writable, &pfn);
>   		if (r == -EAGAIN)
>   			goto retry;
>   		if (r < 0)

Queued, thanks.

Paolo