Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <9beb041b-b757-311c-5ea1-1b9fa1d63074@amd.com>
Date:   Mon, 24 Jan 2022 19:52:49 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] drm/amd/pm: set min,max to 0 if there is no
 get_dpm_ultimate_freq function
Content-Language: en-US
To:     trix@redhat.com, evan.quan@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch, nathan@kernel.org, ndesaulniers@google.com,
        darren.powell@amd.com, guchun.chen@amd.com,
        Arunpravin.PaneerSelvam@amd.com, andrey.grodzovsky@amd.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
References: <20220124135259.1057828-1-trix@redhat.com>
From:   "Lazar, Lijo" <lijo.lazar@amd.com>
In-Reply-To: <20220124135259.1057828-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEVPM0dXOVJ3UnUyeTlFcWFpckdnRURZbVJzWHJmN2E2cEsxZDJONm56MGRN?=
 =?utf-8?B?OXRpcVEyOTZYbWhWZzUxY1FpM1JZcHZKMlBTTDdDVHRSTm1WMVYydmhvNFhy?=
 =?utf-8?B?RjUwTFo5R3BuSU1kemx0MVovRm0zdGNEeitMamtGQzNmQ1lSajlNcnNDb1F5?=
 =?utf-8?B?T2FQenBtRE5hdnBYNFBkdi9ka09JRk5PYUxQTld3NTZWNGZDTllkTGNiOVJR?=
 =?utf-8?B?VDN3cEZtTU0xeExOVTMwMmFuWldPcmFCU2pUME1NeVUyVXBFZE1oWVpVb2p4?=
 =?utf-8?B?c3RBOHlUUEQ0VEdLQlQzdjQxNnp2dTE2L2VWSFcreHN0dnNoU1JVcTV4SS9C?=
 =?utf-8?B?UlNWODhidytOVXdpV3QzaG0zQnFWbGN1elJOSk5FWldDVlZBeVhneVNlQlN5?=
 =?utf-8?B?N0VDa3ZsWUdOeVBDMG5iMW9UTStaSWh0Q1FNUENnUFd5YVpQWFBwbitjblY1?=
 =?utf-8?B?L3JRVE1EU21VS280SWp6eFpBdzFobXN2cURwUWo3Tms4VkZhT3JCS2ZTWjN2?=
 =?utf-8?B?cjJjS0hlUzBpS1JMUHVSZyt2MVEzQ1g5Z3ZEcUtNYWJqTFhQb3FTM2lGQkZo?=
 =?utf-8?B?ZnZXZmprNUNmSDNyWmtxa04ydWxWbHZVL2ltUEZkVEZZcGFuOWIzRG5ldGpL?=
 =?utf-8?B?TkVuVGsvWTgwUWZXMEZsWTFhbC9aRUpnNUFkcXZiZnY1SURpc1B0c2k4VVAr?=
 =?utf-8?B?WjZaVEROQlFVSmJRbDFYMlI0TURsZk9LdjhvQ04wekVWb095QjBXY3ViSWQ5?=
 =?utf-8?B?RHFrU3FkbFEwbFhud2JTVWg4RGI2UDVWYWhGMTEwRWlPaitlemxjVFYzbmts?=
 =?utf-8?B?UmxoT2R4NHRrcjhocWF3Q05pdzVBYVA2azdveWo0QTl6RWZ0NDJ1NmZIZ3BX?=
 =?utf-8?B?TEM2S3E4Mm5teUR1cXUzSnJ1aEYwcU9Pd3dPUFZQQUlLYUdkaFRmbDNMdEpm?=
 =?utf-8?B?U3h6WDdieXBGcFJ3RDZDaHV4QzlDb2F6RGFkT0V4Z0N1bUVUdHRNTEY3aks3?=
 =?utf-8?B?YW1HNlJJS0c0VVVWZ2ZlN2F1T2ZqZytLTVF6T095ZzA1YlhwQzVKc3hGcFN4?=
 =?utf-8?B?QWl4UUxndE44Vm5KdUR0US9MRFZCR05ZcFh3bGxYb3Jhbk1OTGZScGhUYU5T?=
 =?utf-8?B?YStzc08vejRmU1IzN3NKUFZsT3prdW0wZlFtaHpoKzJIdXpDMS9BMC9vYStx?=
 =?utf-8?B?cHdIbzlCVXFrS3AyM1l4NDBDSUJLYnN2NzNrVHYzYkN6OTc2eGRyUjh6UVNq?=
 =?utf-8?B?NGZibGE1V2lVeFlNT3cyWkF6dTlEMHQwSzQ4OW9rbGdMOTNsZmtxeUJ1cmFN?=
 =?utf-8?B?eHhaTFl4Tk82YVpwdk5henhtSFM4MVFBd0hXd0pkK0FxQk9Lb0swQndseDVo?=
 =?utf-8?B?cEQ5SFlscno1Q1p0RWROYW1kUEZtaG5ZRjZMdXBJek9zeFJLTUdMeEJweTBx?=
 =?utf-8?B?RVMzOGVuSzlLcTNNdkhvWWdROS9CNG8xY0VsSW5uUnV5MjNKRGFna2NuazhB?=
 =?utf-8?B?dC9FYlN3bWo3WTRWNWhXdzhUcWNxZkdQMGJGMy9mYUllMFRSeitRa3hja1hC?=
 =?utf-8?B?NU9CS1BzTG9mZ2VCa01YeHVtMG9LajJldmErQUoyS1FsL1R5enNqd21vTTFo?=
 =?utf-8?B?UVlydVZQbW5zVUtmN3BPSlY4MHZwcitTN3Avd2ZWSFRvWTdzaG9vZ2FIL1dM?=
 =?utf-8?B?YnJXUnUyczNFUTF6R3MyTVRicXhjVTBJTU9BSE52UWZ1UmV4Tmw1U0x3dDZY?=
 =?utf-8?B?UVZnVU0vL1loU3M3Z282dElBTHZpcWFRTDVTaTBJS1hqd3cvT3JJNHFzV0ht?=
 =?utf-8?B?eHNFUlF3SmVoWloxamowbVZaR29vZlI2eEQzbjlkQWplQkQwczZ6blNSMEtG?=
 =?utf-8?B?ZHJDUkhud3NtTGFFSVd5cFpVeTcxamZYaGorditOcnh3TUxXaWQreStHK3Z3?=
 =?utf-8?B?cWxWdmJva3M4YlVTaG9pL0paUlFNQ0IvQWo0NWt4NmdtNXhyaFhsVWx0M2hL?=
 =?utf-8?B?aW56WnZaMzMxWEhFZGR5SU16U0RaOW45eGpGQmhrVUFXaVVSTHk1RkNHeXkv?=
 =?utf-8?B?S1UxQzlyeitocm1iVlF5UmpXQUpuR1NubnF5V3JQME9TaXppQ1UvNjB6UkFD?=
 =?utf-8?Q?ZE+I=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dca88c4-015f-4ca3-56c5-08d9df450c36
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4614.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 14:23:10.3698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GFxQ8sGxT0x6tEAuvASp/Y9vZM5T50iMTNO21OZe+czXaR/TE1EYNSxu/45cG7DK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5059
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/24/2022 7:22 PM, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> clang static analysis reports this represenative problem
> amdgpu_smu.c:144:18: warning: The left operand of '*' is a garbage value
>          return clk_freq * 100;
>                 ~~~~~~~~ ^
> 
> If there is no get_dpm_ultimate_freq function,
> smu_get_dpm_freq_range returns success without setting the
> output min,max parameters.  Because this is an extern function,
> set the min,max to 0 when there is no get_dpm_ultimate_freq.
> 
> Fixes: e5ef784b1e17 ("drm/amd/powerplay: revise calling chain on retrieving frequency range")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> index 5ace30434e603..35fbe51f52eaa 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> @@ -121,11 +121,17 @@ int smu_get_dpm_freq_range(struct smu_context *smu,
>   	if (!min && !max)
>   		return -EINVAL;
>   
> -	if (smu->ppt_funcs->get_dpm_ultimate_freq)
> +	if (smu->ppt_funcs->get_dpm_ultimate_freq) {
>   		ret = smu->ppt_funcs->get_dpm_ultimate_freq(smu,
>   							    clk_type,
>   							    min,
>   							    max);
> +	} else {

return -ENOTSUPP; would be more appropriate.

Thanks,
Lijo

> +		if (min)
> +			*min = 0;
> +		if (max)
> +			*max = 0;
> +	}
>   
>   	return ret;
>   }
>