Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <fca36168-d66b-c914-a5c6-fb8d495238ad@amd.com>
Date:   Mon, 24 Jan 2022 10:25:18 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH -next] drm/amd/display: don't use /** for non-kernel-doc
 comments
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc:     kernel test robot <lkp@intel.com>, Fangzhi Zuo <Jerry.Zuo@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
References: <20220122012343.32540-1-rdunlap@infradead.org>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20220122012343.32540-1-rdunlap@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eThTZXBFd1daV0Q3aE5aTmNwcWZVUk0rVitnamErMnR0TE9hcjhaVW5VRm8v?=
 =?utf-8?B?dHowY29kSkUyNkRaVWg5UDRMMzRjNzQrcTBWTWNaTUE2cWU0bW10ZnpOTmRG?=
 =?utf-8?B?S0szN3BobW1XK2w0elVMUGhGanI3MG4wVG5tUThyaXFGSE5TeHJtSUtwb29o?=
 =?utf-8?B?UWJ1WEhodjBEZkQxQmwvbEJUR2RYZ2F2L1QrdGZSbzNqUmxudXdiUzc4TCtu?=
 =?utf-8?B?Rkh0OUVnaHhZVWlDdTRNWlVsLytyTCtDekcxaEF2YXp3dGFwY3FZdWNzK25M?=
 =?utf-8?B?ajFOM09mQXAyTDIwa01hKzgyLzhoeG5wVXlIZ1hacW1tVlFOM1R4NzVPRWdH?=
 =?utf-8?B?ZGhuMXc4OXhCbWRtZ28wQ0RBSjMxU2NXNXRoSEs5OGl3ZWtKZWI5Uy9nUzl5?=
 =?utf-8?B?SmV2UVBpVEw0S3NDWHdRVUxkalJJLzdTaTQzZnpjUnZEbEpMMjhPbGpTK0Zq?=
 =?utf-8?B?SWFSRjhnZmxpRjBHMUZzK1lJYnpWUUFROWF5ZHByazI3VDZHeXBEWUlaZWR1?=
 =?utf-8?B?RUtxc3kzTzZhWGphY3NtRUpUNGV4TSsyREszRWYra3krUkdsR3V3YWNKb0x4?=
 =?utf-8?B?Z0JXR0h3YUc2anh4RkRoQlFxOFVOb2ZLVTRnd3MwL3cyYjQ5YnNnS0dTMlM2?=
 =?utf-8?B?a1RMcVpHODhVU1pVSmlnN1RvNzlBVURvZWJhR1NHTnFHSzBSNTZ0Z3ppMDdD?=
 =?utf-8?B?NUYzbWpQZ25aUjZreWRsM0pSbXdYek9yeXRuRmtTVXllckd5aGpoUFhySDVD?=
 =?utf-8?B?Z05kZGxpK0JpVnlMT0pJTDFNU2xmaGVTb3JsSTlyOHpleDEyRXdSVWUySEpC?=
 =?utf-8?B?Tk5ocEUxNk8vSWdJdTJHUzVtRzNoajZBUUN2Yy9NM1VhL2hyeGd2S3BNTGpu?=
 =?utf-8?B?aDJ6VDkvUCtOQ0lFYVgyWSthcGF4S3RpaGh0OFNodEM1SnBWSzhQQXVtRCt6?=
 =?utf-8?B?cGpzcE5RSVhHZjFIdmtsLzB6b1Zqd0l1T3lpS28rczBRMHhKbjcrTW83WjdY?=
 =?utf-8?B?dCtDM2ZmcEpVQ2QxUkxORnk3YkhOakswYUk2bWNzSnRacVZVL1hSU0JaTDBn?=
 =?utf-8?B?QTZrbDdiMkdkaWwzdzJyTDYzM3d1S3h1V05BWXZHMWFPMHgzeXpLaVJWamJt?=
 =?utf-8?B?UHZXamJORHlVUThuNUJ0K28zQ1hOeHpFREUxK0gxRHFNSWQzdFBRamtib2VT?=
 =?utf-8?B?WmdEZmRFYjJrb3d0SDMvbTJEWlowbjBpUzdiekxDaTlkOVlPd1ArcllUdDdO?=
 =?utf-8?B?cStWbHJwUlNPWkYzUTBvV0ZFYzhoUW1iaVU4ZEIreFdFemJMMkdzajJUbGd6?=
 =?utf-8?B?RW5CTFpRcEhZakRHV1RzczhBb3lIaXhWd0U2U2w1SXhUdGtDanZqb2xiVjhH?=
 =?utf-8?B?TnV2clI4YUFsRWs3MjFleXQ1QklZdmkzYzlQRXFBcy9oeElvQmVwMDlmSy9h?=
 =?utf-8?B?c2ZiTEZwR3hGVWdQWDFDeWVlR1Fjbm9yV2FoakdlUWM4bzRoU2tSeVBvMm1E?=
 =?utf-8?B?VnJ1TFFES2xCLzFIelhBVjN1RlhqbFNuOGo0bkZDMEhpb1VMbWdvRk9rK1dN?=
 =?utf-8?B?REgwcU9pWk1mak5BT0xpTHg2ZFNLZldFdzV2RWhUdUJkQzFaakpHNWdVS0JC?=
 =?utf-8?B?VGJ6NnZQR2ozR3ZCaEhPNTR4ODFFTDJGcDhRYUxTN0xuOHltNllzZnV6WkRP?=
 =?utf-8?B?d2pIL2NJR0VxdER6Zk5aK1lOK3V4VDZaOFBZc2tlcDgydDI2QjVnekpBYzk3?=
 =?utf-8?B?YzBTcm12TWdySVhGTndHV3NPTW42TGRNZ2IrSjU3aDM3T3pobHRMcCsxbHBV?=
 =?utf-8?B?bG1JTEhoNlFra2l4bjVaQkE0cUVSRndhSFArUVBvUCtRRllsQzU4cW9SZXds?=
 =?utf-8?B?VkIrNE81UzhJZ2VaMUVYLzJ2Zlpnb1Fha0pFdmdjZURiVHg2U3gwSDM0bUZq?=
 =?utf-8?B?dXdRRTNsTTZKYXJEMjllRnZwc0E4aStRcFVFYXRFdnhmUnhscUpvSS91TU5u?=
 =?utf-8?B?OHJGL0VwWk5FNnVRU0FjYVFwQzFsWERPUGd4ZnFyVGF0T2hJd215Mmk0RmU4?=
 =?utf-8?B?amFZejdJUXFjNzZhSlErdlBlRm9uV3h5c2x2S0UwWEZ1czFFSGRVQ3NwRVNO?=
 =?utf-8?B?WXpYOVBYUDJJTDQwSlVEUEFFVWNsd2tFOWk2M3pzeDFKa1pJU2lJc0xpYlZp?=
 =?utf-8?Q?YsWov9bcfwew1ItetDhZXKE=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1388f763-a0f5-414b-60b6-08d9df4dbd38
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 15:25:23.2668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c3ewidIdpFitJ3BySwd9WfvVLQwcE1JEDDE729fPD3MF+u4pXkXHP+0+8ikbLnItTQaQumYfps6r2JLtXuct9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1433
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-01-21 20:23, Randy Dunlap wrote:
> Change a static function's comment from "/**" (indicating kernel-doc
> notation) to "/*" (indicating a regular C language comment).
> This prevents multiple kernel-doc warnings:
> 
>   drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:4343: warning: Function parameter or member 'max_supported_frl_bw_in_kbps' not described in 'intersect_frl_link_bw_support'
>   drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:4343: warning: Function parameter or member 'hdmi_encoded_link_bw' not described in 'intersect_frl_link_bw_support'
>   drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:4343: warning: expecting prototype for Return PCON's post FRL link training supported BW if its non(). Prototype was for intersect_frl_link_bw_support() instead
> 
> Fixes: c022375ae095 ("drm/amd/display: Add DP-HDMI FRL PCON Support in DC")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20220121.orig/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ linux-next-20220121/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -4970,7 +4970,7 @@ uint32_t dc_link_bw_kbps_from_raw_frl_li
>  	return 0;
>  }
>  
> -/**
> +/*
>   * Return PCON's post FRL link training supported BW if its non-zero, otherwise return max_supported_frl_bw.
>   */
>  static uint32_t intersect_frl_link_bw_support(