Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zi Yan <ziy@nvidia.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        duanxiongchun@bytedance.com
Subject: Re: [PATCH v2 2/2] mm: fix missing cache flush for all tail pages of THP
Date:   Mon, 24 Jan 2022 11:07:33 -0500
Message-ID: <1F326ECC-9F85-40CA-B731-0945BF071FBF@nvidia.com>
In-Reply-To: <20220124051752.83281-2-songmuchun@bytedance.com>
References: <20220124051752.83281-1-songmuchun@bytedance.com>
 <20220124051752.83281-2-songmuchun@bytedance.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_25E49A25-621D-4FC0-B37A-8E9EB4A44DDC_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hVQEzROl+8o/hBQQCZY2TKzR+bB4+WMJZybuLmLn7TaEgwrMs4kw4HSR5r34?=
 =?us-ascii?Q?Ka765j0N9jRIWdaOkdG2l5ZbKmo6KmslAIvMD5rUD9SPLtjEe/XaYRCvaZzj?=
 =?us-ascii?Q?CjOw4KzVO2tWw3PCNRqpOCoMC9kKK3zzc1RKmEuxvyViLCDvdaaleK8Ca4lg?=
 =?us-ascii?Q?ziaACpAyucG9EQ3nJOwnMrE+iluszvWNuQWZlEU0xdU0ZtMiLx3IXNycmesF?=
 =?us-ascii?Q?VX+KWbTAJI8vayyye+8orgPcshVHkfTyaOTdLKL5V4FbrorVeLQaHATlLakK?=
 =?us-ascii?Q?KDOb7pdIDTHG8c4FfCgImKhOEnJInPxs1SFxz9kl3qYMV3oOPI9qOWin7QGJ?=
 =?us-ascii?Q?q1BbyWU3exEpmxuFEvXcPg9d/f62RmtBK0Q+Epu8IwHEK/pTVuSxW+pGeQ2E?=
 =?us-ascii?Q?OmZiSlUZuLD6pt8H6o+F8aLjN5VEK0m/j4S+UvrtvXfCyWY0uA1hopkxAL3F?=
 =?us-ascii?Q?QTCVUmPiyP0GrDlDp1kS+h9EnqsJ3e1ApIeW/c0DHI4aM9bIgvzFo50g0ij7?=
 =?us-ascii?Q?ppzmuhgYmDRp/+j3LCwDrA9biApcCiS8neTW3s0F6J/fkwqb7Fr2OdU7EKko?=
 =?us-ascii?Q?pMANKgPyyGl7IIlZwEdxuSQBzJQRhQqzcr2JnAFzGcCNtKwI7gYT7ODIelzx?=
 =?us-ascii?Q?ooR7ToC3szqz8mXNWi+GLh3g9SDSJ/a3Wcu7FoPFS10JO9+cYYjrcYjXsvxr?=
 =?us-ascii?Q?+GjbM+Jkd51/xnxx5cXjrb+FFZmstti3GnBJSrSt7OO+MskLeqURdoqZZJ7C?=
 =?us-ascii?Q?1DDe1uGBoBu0vIOLr+5Xy3xoZwxCMmHfHGcC8oP1XNVIL4z4riNgYR3QsUYG?=
 =?us-ascii?Q?I50hJz9CpTQlHjxCrr6iSkUP4OUPmNKRZqERP2kUe+iqiX3R+xje8jqqHJ1C?=
 =?us-ascii?Q?pE6eAhJmYjG/59SI3mO5EOl7DDhPEPtqPdkma2QzyyAmLNRt4PmrcWjBOKhM?=
 =?us-ascii?Q?9kiMNtBUbakypv+igrA3Zxe/Xg756cvZ9fWlkCwAbIW2TeEwbLnXQxwbb+/v?=
 =?us-ascii?Q?iy3dvSL0tG/Q1XvCprD54uxslPCss8GJKnIJnhxuewxm5GoUKA+ST70OxnxK?=
 =?us-ascii?Q?mG8RHeiWqpOyZ9LNKtrf6aJydU3aJs/JIhtm6DnQYuv0gqAjMJrJbD0anwrz?=
 =?us-ascii?Q?Q90rmn6h14hwFgYl9Du8l33PHNQU5kOqcD//3wU9FYq7CWFyEpkQcwVB0v8r?=
 =?us-ascii?Q?umpCUaNZjGzLPQx90u6QITnF5pE9mCi7CoIewyfEYyyN1m3DCyjYvdMApsSn?=
 =?us-ascii?Q?qbzYxsNttb0vslGNASGXhj3KxT8EVyU+WaXYBGXLwFdlO/L6/7BGsHsGMNn5?=
 =?us-ascii?Q?ilW/Rs3m1yezpU311GVaNv2J8/JPaGDlqn/K66jRYJCt8Mm2Kc9N3MO1i6G9?=
 =?us-ascii?Q?35QpNtcrvo0XDY1qndH31pIPSzm/r2ODGd7/+4Ssmayh4uAaz3Ar3zhoi2Fv?=
 =?us-ascii?Q?m8EjbcpmUTyJQToTl7PXDgIoekxPuG0RtaafbNV0KKarT21I8S4v027NpBB+?=
 =?us-ascii?Q?w8i8JZIE7/a3rXKCwn3DRGHv3hW1Edr68IyGj/dNCqGEH/Lm0HK/SmYrsKka?=
 =?us-ascii?Q?FphwgNxXxfoQH8P1imM=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 758cb33a-5c3b-422f-2a55-08d9df53a2c6
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3823.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 16:07:35.8779
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fJifXROLIuITBGGHhUCTLWvmYOzPTKw4R33Li+X8aHFnxhVxTekEV9+o8qxNaotu
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1905
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_25E49A25-621D-4FC0-B37A-8E9EB4A44DDC_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 24 Jan 2022, at 0:17, Muchun Song wrote:

> The D-cache maintenance inside move_to_new_page() only consider one pag=
e,
> there is still D-cache maintenance issue for tail pages of THP. Fix thi=
s
> by not using flush_dcache_folio() since it is not backportable.
>
> Fixes: 616b8371539a ("mm: thp: enable thp migration in generic path")
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> Changes in v2:
>  - Using a for loop instead of the folio variant for backportable.
>
>  mm/migrate.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index c9296d63878d..c418e8d92b9c 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -933,9 +933,12 @@ static int move_to_new_page(struct page *newpage, =
struct page *page,
>  		if (!PageMappingFlags(page))
>  			page->mapping =3D NULL;
>
> -		if (likely(!is_zone_device_page(newpage)))
> -			flush_dcache_page(newpage);
> +		if (likely(!is_zone_device_page(newpage))) {
> +			int i, nr =3D compound_nr(newpage);
>
> +			for (i =3D 0; i < nr; i++)
> +				flush_dcache_page(newpage + i);
> +		}
>  	}
>  out:
>  	return rc;
> -- =

> 2.11.0

LGTM. Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_25E49A25-621D-4FC0-B37A-8E9EB4A44DDC_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmHuzsUPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqKdbYQALGOgrnDoIpBetzqBP/KGKbtF2o/DwQfjwto
VE7wgckZvcW1m0ZiWkEOI6ja3kChUYjoQw0rsZghPJjY1pQdv7MJLmNfofbFi5H2
E4mE3efv/AHZQaBODnvrylBOGoL1x8cSI4BADZNWpY7QC8dnjswCjD196NrgJ8kz
ZGVPcF36N5oGtXto3Bs0bnbLRBA36xwq4d4RHjSjr3sk2Y9nWa3g6iZ3sTJpdwY1
wfEJyXGKZ+F+68Jc4XWZyRarM5Fw2UzDVW7Fkf9WM5nvVVcAeQU/Fc2RIKE5wPid
RoJ1vQTOFha74a00aZOY0iQdKBTFAUCLvHGHRUqKLQR1yAtfRPvborxynR+AsBSE
ugDEBfiuaZazpAFrdOEY/RHPA/xHt06ZHPrvJDaK6XR6xOwusU8TPOKpkIXxeVTS
KzV34o+XdrH5Cr+rVYtAZdNOtzK7PId8bMoeq0Sih2TYLxTgDzaJKwgcx/fMtjRg
naLpGDIlxkcFt1dj27e3BO4V2WNDRFHMUh0OGuoWICQp1mkmWNeA7zi16DwCHW4Q
x/vtidqYlf1x2ZMTgAiEHCkjGT5Is7GGU9UutDM3Be7SFvwCRxdqDyHQef13uv+k
iswHDPdR0KAgpSNdQAuM8edhmBkf9PgZZDNr4WD+M3ACvcQbTO7x/dQys9nJWFVW
eSLgyKaa
=znuF
-----END PGP SIGNATURE-----

--=_MailMate_25E49A25-621D-4FC0-B37A-8E9EB4A44DDC_=--