Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <562d9627-fe34-fbef-e908-d06a1cdd7cb4@gmail.com>
Date:   Mon, 24 Jan 2022 09:09:41 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] net: dsa|ethernet: use bool values to pass bool param of
 phy_init_eee
Content-Language: en-US
To:     Jisheng Zhang <jszhang@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Doug Berger <opendmb@gmail.com>,
        Joakim Zhang <qiangqing.zhang@nxp.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Bryan Whitehead <bryan.whitehead@microchip.com>,
        UNGLinuxDriver@microchip.com, Byungho An <bh74.an@samsung.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        bcm-kernel-feedback-list@broadcom.com
References: <20220123152241.1480-1-jszhang@kernel.org>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20220123152241.1480-1-jszhang@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/23/2022 7:22 AM, Jisheng Zhang wrote:
> The 2nd param of phy_init_eee(): clk_stop_enable is a bool param, use
> true or false instead of 1/0.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Nit: for future changes, if your patch spans multiple 
subsystems/directories, just go with the top-most subject prefix, for 
instance here "net: " would have been sufficient. Thanks!
-- 
Florian