Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 24 Jan 2022 13:17:59 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Ben Skeggs <bskeggs@redhat.com>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] iommu: Add iommu_domain::domain_ops
Message-ID: <20220124171759.GD966497@nvidia.com>
References: <20220124071103.2097118-1-baolu.lu@linux.intel.com>
 <20220124071103.2097118-8-baolu.lu@linux.intel.com>
 <BN9PR11MB5276BE30652988271878E78C8C5E9@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN9PR11MB5276BE30652988271878E78C8C5E9@BN9PR11MB5276.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8E6U9U03D03tFvJDwT9kXSRXHfDMNDYSEgo3+R4rPjs+Wzd0/jkEJpbJxjf3?=
 =?us-ascii?Q?JoJuK+enTGyZUrtfDbSTaW5hGtF/xYezeDBEpwSA3IVRULFajNBQdQQ/oajh?=
 =?us-ascii?Q?yOnPIcEOkMYFhldLrpnZAa1tFYpDACeABDUf//6a5EWF4RuOW/3ivg46O7Nd?=
 =?us-ascii?Q?oVHHlSlUMt0hl4if9cVwOgstfLuowDkL8uvTuFS5DiyvDHeSadXaT7fNMYLo?=
 =?us-ascii?Q?qPRtiBbCruV5v/3EkB/0K3O/uJp+z9z9QW8eaAe31pLz6y5khAwD6EX3YiXu?=
 =?us-ascii?Q?7P1eVPIsqsk/WqBHOmHjdnp3OKxpUIElHVSasF9T2XnxhUB6oEI4m2mfliLR?=
 =?us-ascii?Q?2MnUbM2wNtxif5YJsjIoOfh3UAqj/7fzPHVFKQf3ydDuSeG8JuimTlLCptov?=
 =?us-ascii?Q?4EXmBQbYBQVVYu8uDnxLsXmbnbr7HnuJUXi9lg0Q4kX2xv+t/z81f0GPxVC1?=
 =?us-ascii?Q?tNpYr6SktuRRCa5y++rb/tGq7pGbIGmvKW6+uqnUsQTe+pOL4Wq10cdk5Mep?=
 =?us-ascii?Q?jdVM77/4AKb5hh852TkT1lLcJ1PV98s5uFD9uVVLRkiDJeAoLEsxuaxLhfFk?=
 =?us-ascii?Q?XU1hYTCEQl46Dhk2RYztPy2lZ7gh/WYIhAc+Z1KSMhLmhJ/pJk92DU4nKpqt?=
 =?us-ascii?Q?r3DYJgLvEA4oWRlRMbUV7cklBR02Vs3H0L2E4VJm9LEpDnqc8COgnSJfO/Du?=
 =?us-ascii?Q?Zoy1E0V1/Rq7QEUcx1wf4mTKehPfzgmrUfbAepY2kcmhEiadI+Yx0HXfxzug?=
 =?us-ascii?Q?nwIH6/JmVsdBoc2FAAxqTIoCKopDuerBb4Ap9hmqbDcc0YtDZ5iMVuPI6bNr?=
 =?us-ascii?Q?FU3Y5gmgRgzcVS2wH4s5JZrXboxJZTNIuoC8CihZHJ6uD17w8gxjAnMfgnz1?=
 =?us-ascii?Q?qqRqneQ/QJJqI4RpMFCWSNq+GRZ9E8KNwE49P8ytkB6z8kxR7dEFKezt+Zg5?=
 =?us-ascii?Q?lvDgEQe8V2TPp+Fh/mpiB42z6eYAeUtgty9YgI3Asg/gVjkGVRpvR3sX2+7x?=
 =?us-ascii?Q?+PiF+WkcePXXLBB9jhdocd2scc8Bx5YfXyQ0lxSnWuXBHGOEqoFoxKsWaP7b?=
 =?us-ascii?Q?MftSe6eyHhruxohFelQ5sDN2aR2RMSbbTbaxHAp9iv6178SGqhNiS40iSCBW?=
 =?us-ascii?Q?xuqWdW3TdPswjd8iGEt7IPBhOuOn/Rj5vC45fCGuhho+aqPrWRnf3OBAAU8X?=
 =?us-ascii?Q?GqT3tOwXk2yDwXmJ5QBJknrhKdYTFojcXAZp+I6JIoPbd/S2gnBo1Idb976z?=
 =?us-ascii?Q?NEHbeUIQCwaIrugj9uppuxzWp1EInQUhCZjHdpcF/AV1ySN47JvaiE3k1cH8?=
 =?us-ascii?Q?qm/oZDyEzyillMEpzzWiYpk+Sdl48l/tmYiRtYoa8CTVEZbgz3xWaoA+5s1H?=
 =?us-ascii?Q?+9L6z7PUozubFOzRE3lIZhrSYoA/941bMcr87cdZQDZLCB5EakcWdsw2229G?=
 =?us-ascii?Q?gU098shx6g69ER5nZc+dXdsao1eXZhciBR4uSItZ5zuzbRStU93aqeMZA2Xi?=
 =?us-ascii?Q?JDwuxEEeb3lLKzupH9O7uVax9QWllKbgqiUjsUNBdfvfhN0npEjoxxjqYVcO?=
 =?us-ascii?Q?xkLKtKAZeW/lwqx3pHA=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9fd6ade-63bf-4343-345c-08d9df5d78e5
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 17:18:00.7717
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zzwA3CA6Dd0rMR966bWievsR1EGzhXoW4gzPQUNViGFeILRajI6kKjy/UOpjC0Yf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5114
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 24, 2022 at 09:58:18AM +0000, Tian, Kevin wrote:
> > From: Lu Baolu <baolu.lu@linux.intel.com>
> > Sent: Monday, January 24, 2022 3:11 PM
> > +/**
> > + * struct domain_ops - per-domain ops
> > + * @attach_dev: attach an iommu domain to a device
> > + * @detach_dev: detach an iommu domain from a device
> 
> What is the criteria about whether an op should be iommu_ops or domain_ops
> when it requires both domain and device pointers like above two (and future
> PASID-based attach)?
> 
> Other examples include:
> 	@apply_resv_region

For apply_resv_region the 'dev' argument is really selecting a device
that is already attached to the domain, so it should be in the domain
ops.

> 	@is_attach_deferred

Only two drivers implement this and neither use the domain
argument. Remove the domain argument and keep it in the iommu_ops

Jason