Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 24 Jan 2022 13:24:18 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Ben Skeggs <bskeggs@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] iommu: Add iommu_domain::domain_ops
Message-ID: <20220124172418.GE966497@nvidia.com>
References: <20220124071103.2097118-1-baolu.lu@linux.intel.com>
 <20220124071103.2097118-8-baolu.lu@linux.intel.com>
 <Ye5zUapC/YcZs7kl@infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ye5zUapC/YcZs7kl@infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?br1stUBLBkA2qTRq5ldePaan0FKdhfiDz8XV55J64VId9U2MXwV44ExAvFPC?=
 =?us-ascii?Q?tnJbiSdfOa1runOuWZ5/bw+LVSILTtyGLwL7YbgI+e4htPpJzIr5qBCiBapg?=
 =?us-ascii?Q?tbdL33aFtEnK0ZyPxCfc3K/l4CvLkvmHtdelJdKnr5LxDR9FpFc6MtLIZBGI?=
 =?us-ascii?Q?J6yIwF3zWkpJzcy+F6epvE0E/8HV+ugw8u8JGdhCimLOLTj8zvgEQEIqh+kO?=
 =?us-ascii?Q?6kUp56+26wvuwpcKp/e8+xFJgE1/38XJhbMRFl95k1kupXk4WT7RXAnpK3in?=
 =?us-ascii?Q?QVIsxIKDqNpcx+coN1YAW4gZq7uE6aUwxRFIWPrgsnTi79THbEIlVv2/tPeh?=
 =?us-ascii?Q?UwCI89jK7n4SyH2dHdiIv1ZVJksVecSiHPPs21+RkC4qGEmufgnsFBFCddOB?=
 =?us-ascii?Q?37Md8LyYQh1QLoTZ95U83EmhzFzJrbY74ou9aHNjsytV7FpiDr9HW11O1/Ua?=
 =?us-ascii?Q?TdASYXr0fhnRRwBZoNu1N3WocKb10j4cRx8SkV34ymGrC7B8gEvh3qZXm8WG?=
 =?us-ascii?Q?iomt/7NKq54iOly3olbZ52G65DntCMnfTcyGoEc08Hd4laRieVq69i1LbO0E?=
 =?us-ascii?Q?4ixRyouN0RK86um31qbSzZCCGR+b7xHcJhHC5QEXOuyWRPvajMSn+LHxYPtu?=
 =?us-ascii?Q?8mSa1takZueKuhuKHod9/qdW3EjtimdNmUE2ayJ/0ng2F5qGzBWQ+cRLX6UM?=
 =?us-ascii?Q?KSiCH+7rX6S01JhY77ZWkmJ75ndQhdeGpWaKSjLtyV/RQMi8GM3EZgaeRG1o?=
 =?us-ascii?Q?6oCtjyfc+hixBy05iHgUaZE71BXZr1bE6nd2X8ocVS0/nUQ3FdLeP0/TzQdw?=
 =?us-ascii?Q?SXVyRKh/T/zaa7RHaizmgCMAhzUMlHk3m4M8famyKOmvRft7xB2fiy4pbnhR?=
 =?us-ascii?Q?vlW5u1RhdzPN2TKr736xYBrH0A736nkokf9XNyEFyB9m6eabMhDcDQBc7ocS?=
 =?us-ascii?Q?I77L9jXSQZ3MetCDKYKuzFpA8E0up7cvwPUUmrNDNKqUsy9tI1zmIynU9rp3?=
 =?us-ascii?Q?n7y5H5FY5h4of+QLPdsqOZJHDV3XcfTEn0204PKO8cHAwk8hk+EsoSWkKrNR?=
 =?us-ascii?Q?E1Cv37Lw0S6FKWeES/0TrRQ2epIFgvcd9cQ+4zN9t+DM2JThfeMXSTN5IOfo?=
 =?us-ascii?Q?2XmGRbyhS3DgH6LqiQfyUNRjGoTdTMW0acC4YQR6kibN82QmkAOQqdvear01?=
 =?us-ascii?Q?+UHScJ7r5ztnrwGtJhUW8jRbQevFpdufSfdDEvisNtNvTJW3P6UgRrsSWE6F?=
 =?us-ascii?Q?fgoL5U5bYGOa2+Pjj6qyNnIC0GM/Zediz+cFiljmpDQcKstQhJ0U55+etk+J?=
 =?us-ascii?Q?ZcvEo/XTFXt6L1gI2Mwu9ORtGEvteo5tsGGE8iRqYcSxrS1AwpEBe8rMLDkj?=
 =?us-ascii?Q?ngJaKWDIhhmgewxA3Ermef8f53U/A5fmyQaDzjhplRpJzB+6e6Cl7Ubwe7iR?=
 =?us-ascii?Q?naNqqxL0e4ft2HBahXItJJAK2aAAmKQio6DHrk4ZDC0rN32lUWQRqnTZxj9n?=
 =?us-ascii?Q?aucchczvkyfZbKI6q4yVAkJ4q5qwmz7Du12fb75AK0efDAF6OrcA2Fqzc+Qg?=
 =?us-ascii?Q?5R65H3aUNsTSfiKb5jY=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30e420db-3d3e-4d41-168b-08d9df5e5aad
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 17:24:19.2254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sr4VQ8dJww962FJnJFgQ5IznWfeCOeZZB7fjfRccgx8Ner0Zk56N4WAR6UHAf7pi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4553
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 24, 2022 at 01:37:21AM -0800, Christoph Hellwig wrote:
> On Mon, Jan 24, 2022 at 03:11:02PM +0800, Lu Baolu wrote:
> > Add a domain specific callback set, domain_ops, for vendor iommu driver
> > to provide domain specific operations. Move domain-specific callbacks
> > from iommu_ops to the domain_ops and hook them when a domain is allocated.
> 
> Ah, that's what I meant earlier.  Perfect!
> 
> Nit:  I don't think vendor is the right term here.

+1 please don't use the confusing 'vendor' in the kernel, if you feel
you want to write 'vendor' writing 'device driver' is usually a good
choice..

This whole series is nice, the few small notes aside, thanks for
making it!

Jason