Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 24 Jan 2022 13:44:04 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Ben Skeggs <bskeggs@redhat.com>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/7] iommu cleanup and refactoring
Message-ID: <20220124174404.GG966497@nvidia.com>
References: <20220124071103.2097118-1-baolu.lu@linux.intel.com>
 <BN9PR11MB52767F46CC13601306001B9E8C5E9@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN9PR11MB52767F46CC13601306001B9E8C5E9@BN9PR11MB5276.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x9c+b0dqvPgWhBcN2ETYktYqf5eZgjHWToXBZV47GSyb5h4J18tPgIEAZl1K?=
 =?us-ascii?Q?i0qQDFo4Sm8PXn51RzSTt3QzYbZuynD9Ur7PmnNDSU7YMB8KaX00hb4mXSED?=
 =?us-ascii?Q?p6yEtC9w7LB3iHRpP26ccZUvjvGDqMFajRGE62hD3x3sRFbkRM3++FeFCAKh?=
 =?us-ascii?Q?vV8FfzqnXbmVxKCx9RBJ4K8IkNXVFiJlODMXFyUbBdCu6uZ7RiQ9C4zPsjF7?=
 =?us-ascii?Q?ZM5Or54EFdHt0xF5sB8RMNpM+wGk9PcK2177BIK8oeX+sBlnniWDWjifjBLr?=
 =?us-ascii?Q?QFPt1JsfmWtwsefeOIEiO6NkhmEHa1x3p+eXcNLv0MmcfWWq6xloy+hgz3wS?=
 =?us-ascii?Q?TTxQxENqzJyvWibDxiq/azT95EIRjWgiYGBXflNWPFOhEwqxj8lj4zx2ox1h?=
 =?us-ascii?Q?pulLpBss+uSRkjGMnNi9FgMtTsbyvzZVxUHu9E9uw2qGc7lgItp0PjQlbEzb?=
 =?us-ascii?Q?mxfIsWOeeTAlkpEvtrs72O2ufwVSlaGGAgQn2bYsr4EM4f01HVk6n65sB1zE?=
 =?us-ascii?Q?U6ty7PAS9AWk8XEcL46sHl4Utx5niOP/95uYxcqpBTXj/rkGQOEVEq1Pml7b?=
 =?us-ascii?Q?qPvI48A+wA9/tXNs9QCHgEJzrMRSHFEo0rTVizEFCau+F77QTifQTg2f3Eli?=
 =?us-ascii?Q?X21qhrrzXknkD3AKRJjrZhEXQzBNKQtX5lFnYVr7Qh4CJue0XIvfgB5kldsx?=
 =?us-ascii?Q?uL/q18RyHEr3ZrxhrSv3AMQWGm+xsjw3QVY0+mGB/2lVX48LilItOG9AV/XW?=
 =?us-ascii?Q?Dq/KJ5Uvv1rUhL6DQeeuOC5wmKjT4iEpzKPX7QNHp2txpFXKdHxwCYTRs0E0?=
 =?us-ascii?Q?jcpgnF220hmtZladQkTvpuzTjyPsE0N+5OAsf7GdBrW+n3O+yp1mhJNsRBA3?=
 =?us-ascii?Q?EOthghz0kewsqS3O49V1W/cB8lEnioJU3I4wa4HvWjm5SNiKh2Zy9VHvtt7X?=
 =?us-ascii?Q?PfeE8KDMmR7oZHG8r0jX4ez+iiQ+LD3bM5/9TAEx8e4Tp9QGOzeK6/UcWBkZ?=
 =?us-ascii?Q?sLukC1H19WDTGv39k7UBugfiVvaOC3h6NbC1og8fJaIjy4XSJ1XRPoqiwsWS?=
 =?us-ascii?Q?uMWyBvvpkd8dWVk2TSUqqtN6uw46LWv8RYuiOOwQq72wu3JsXfOtDWjIYez+?=
 =?us-ascii?Q?t+B93QjIOu7tSyds61C62on0T6ozLQgiYTVgo7nXQe7zAdDW7pxoJllp04a/?=
 =?us-ascii?Q?EuLRIqV6vJGd8zq4KqyL00bj9Yr4rQPRDh8hPRYqfFHgYAvuztf7u4RiJ2Ze?=
 =?us-ascii?Q?KiTld2W8/jtbkKmmsforRq9F8NDbSsHghB7GMR8eq4GX48I3gdat3IbQbK97?=
 =?us-ascii?Q?Gs44KBRllZhRBumGoTVkNDuzZ89pwLSO7HfjEwFWiQ2SX0DXNB5jD1lhWmSK?=
 =?us-ascii?Q?fgxLh/ItiiGtljJznW/e5f49VJOlaT5Y8Kvp0E6yDkgx2l3ckBgKiP1fXEWY?=
 =?us-ascii?Q?3ZPHpIHtwnoylQnB6KQRa4bnt93TL495RJJChGZSMVOXpEDsuPPfqrAfWdd+?=
 =?us-ascii?Q?OPLDLtGeWJzH1X1NlEDGWK6KPntAHu6t3Ve65wZ+dKM37Yl3zwVvM3m041qB?=
 =?us-ascii?Q?iiE9r+nogw+Nqi4ksik=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 337d52bc-b07f-46ca-f55a-08d9df611e04
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 17:44:06.0285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VJ/2QZf5FB7Q6+KU8w0nvgxJnsMojVHwxxoJdnpm0EiL3X2Up1ErbP/QWEEmBJS3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1414
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 24, 2022 at 09:46:26AM +0000, Tian, Kevin wrote:
> > From: Lu Baolu <baolu.lu@linux.intel.com>
> > Sent: Monday, January 24, 2022 3:11 PM
> > 
> > Hi,
> > 
> > The guest pasid and aux-domain related code are dead code in current
> > iommu subtree. As we have reached a consensus that all these features
> > should be based on the new iommufd framework (which is under active
> > development), the first part of this series removes and cleanups all
> > the dead code.
> > 
> > The second part of this series refactors the iommu_domain by moving all
> > domain-specific ops from iommu_ops to a new domain_ops. This makes an
> > iommu_domain self-contained and represent the abstraction of an I/O
> > translation table in the IOMMU subsystem. With different type of
> > iommu_domain providing different set of ops, it's easier to support more
> > types of I/O translation tables.
> 
> You may want to give more background on this end goal. In general there
> are four IOPT types in iommufd discussions:
> 
> 1) The one currently tracked by iommu_domain, with a map/unmap semantics
> 2) The one managed by mm and shared to iommu via sva_bind/unbind ops
> 3) The one managed by userspace and bound to iommu via iommufd (require nesting)
> 4) The one managed by KVM (e.g. EPT) and shared to iommu via a TBD interface

Yes, at least from an iommufd perspective I'd like to see one struct
for all of these types, mainly so we can have a uniform alloc, attach
and detatch flow for all io page table types. 

If we want to use the iommu_domain, or make iommu_domain a sub-class
of a new struct, can be determined as we go along.

Regardless, I think this cleanup stands on its own. Moving the ops and
purging the dead code is clearly the right thing to do.

Thanks,
Jason