Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 24 Jan 2022 13:55:42 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Ben Skeggs <bskeggs@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] iommu: Add iommu_domain::domain_ops
Message-ID: <20220124175542.GA987164@nvidia.com>
References: <20220124071103.2097118-1-baolu.lu@linux.intel.com>
 <20220124071103.2097118-8-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220124071103.2097118-8-baolu.lu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rvyUoPF6AfJuvGK8CnZkQBcefhC+sNYgHvMM0mdMhvlS/VE+WPszV+7xkref?=
 =?us-ascii?Q?5F/6qm7gI+Ap6CpCb+PDqRA1WmXWxTXsbDbH0z596WdUjvCooyFHvLjzJ/2B?=
 =?us-ascii?Q?TmMlmdum8XhcCWH0flQNDERN1qnESvFddCOz8Cd1ZaF5PiCfad75GdB3nV0z?=
 =?us-ascii?Q?/+PzTGUFiliOTsSwUBM3p5eeF+e/G/upEH51hEU1yxWIpcZyn6XxLGWqx8o6?=
 =?us-ascii?Q?/dz8ls7OGynntcNzpfpjobeL3je2bgUgUwcOxUhiH6cKeNvniI5VP1/0YbnD?=
 =?us-ascii?Q?GlC+5fTZxnLENu0lsshOOtijTxNwqLYv0lg5QrLz0r29yKeACFbjAvd0LyY2?=
 =?us-ascii?Q?ELNmjAcylWan8ZBl1RLU8NuNvRp8GXZLuJ/AfJnwppu0kq6TKOjCByGOM6Fg?=
 =?us-ascii?Q?kmePSZHUYeqZJvvdDR2eE/9H6pc9W2SwFMTSryCS7DNyl36swH82bYHYMUrO?=
 =?us-ascii?Q?PrVRIsgz+KKSN1uau0i7qg9ywta4fO+w5vlsJBUPr60AvJMgB9HdWlzzhRkL?=
 =?us-ascii?Q?4lithRJBPS9ZVwG8e0Eork5c3AplNXZD1AajeHoPG0Xe7+QLWdtru1H1xfHh?=
 =?us-ascii?Q?8MgGKrrHvIfpWsFJOWwG8nxh68DJic0CO1oxZPr9m1mxCVPiXDOtrH0jGm8S?=
 =?us-ascii?Q?fiX9l8XT2y1qJ2OWaq2064AIuUxmL3SY0FrI9iHJLkmjfsXtx42aJhTvUx48?=
 =?us-ascii?Q?AyKb0yHwfaetLpPrqXAlnPkGOYZK8Ki+WrMcDKFKhv/PjH8JATikO2q1J7N3?=
 =?us-ascii?Q?JTZ1HLWMy+YnW0qCmdTnY9SlDIlb8V76UlRIioTp4pK58v+VG1Obq981w/HA?=
 =?us-ascii?Q?/XtJDjw93rg5yiY8KbAFLGS+SB4Hq8pp/X13wY0pvNOWxEc/4ZR/3Bbqg/l/?=
 =?us-ascii?Q?k/rvdql0zBgROyT758PgMtKdOdKOnmBhrmAMxlKiuw2R328zWWRiQ6SqlPy8?=
 =?us-ascii?Q?szKPHj+7eG/etMEEony64WLgkyaNYXlcIZn2kDKcCs9T3Xdfsjp9Jmfe62+l?=
 =?us-ascii?Q?QVN7Aqey+s+z9wAoV1YQItzyG6Ku/N+w4oxznLCPJcW1TT6yLOOXKOJvbNvH?=
 =?us-ascii?Q?B7LuferNJMOe9uE9SBmhXFQW2zHAmTZqucRAgBYHBnkbKkUpEAex+x9YRosU?=
 =?us-ascii?Q?2JU2NK+XNNlu8cyRnsQFv/exFnC97JbuAVvJP+BulTj9lXfvKV1cn7hGzJlT?=
 =?us-ascii?Q?pdnhSVSvCP1As2BIkZjKX7yfQff/MeDCtIhf8t+WwcTaCDl5ASiuJfQ9F0e7?=
 =?us-ascii?Q?8wqFSB1Lqb3yJfYSZy1x0ZSNzEYLQr/uGeHdwPM0PDgjbAzlhRFyIGpTz8v3?=
 =?us-ascii?Q?SlYF6c0O1iqrLF0x47W1GXFH2EVMpW+l3HhLhT+qFfVaEaS0lkI/XL+/Sg0O?=
 =?us-ascii?Q?6ZO5FUDX9AiIfYJHPDbAOFbo4FSc8XONQWDnbhc8k9iDWc4Ow+G5NkRB5GSc?=
 =?us-ascii?Q?P0z3ZlX4PKhsMNLvwGRB6f6hSH/rsE909nyZw07marX8DdKMR3U611SexdhG?=
 =?us-ascii?Q?3OXOxUfUZgidMSbWlUb1pTqlqGvhINZ7ughMOdwgi6cjlLSI/1MrVq51FRhK?=
 =?us-ascii?Q?VOcFrhlAQ1lmtzE3Y/U=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6042e2c9-4291-4bb7-8deb-08d9df62bdd4
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 17:55:43.5186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ypky8X9pPdJvyQSm+1BWgVP9u26peq4ddkmRnSpNKg8jAzBaF5kIBk4xMN9gx1R/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4306
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 24, 2022 at 03:11:02PM +0800, Lu Baolu wrote:
> -	int (*enable_nesting)(struct iommu_domain *domain);

Perhaps for another series, but enable_nesting looks like dead code
too, AFAICT.

Or at the very least I can't figure how out VFIO_TYPE1_NESTING_IOMMU
is supposed to work, or find any implementation of it in userspace.

8 years after it was merged in commit f5c9ecebaf2a ("vfio/iommu_type1:
add new VFIO_TYPE1_NESTING_IOMMU IOMMU type")

The commit comment says 'which are nested with the existing
translation installed by VFIO.' but it doesn't explain how the newly
created domain knows what its parent nest is..

Lu, there is an implementation in the Intel driver here, is it usable
at all?

Jason