Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3544185pxb; Mon, 24 Jan 2022 11:52:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzI+IIj7d96AfDVZsctaFTu3s0zFueZSNHHP8s9VOMrbmhLL8MGdzQLnNEJgn3FCk5DObvZ X-Received: by 2002:a63:2b03:: with SMTP id r3mr12818696pgr.201.1643053934929; Mon, 24 Jan 2022 11:52:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643053934; cv=none; d=google.com; s=arc-20160816; b=UOtCY3KRkRulsCykAuuixSfUGd2w5LBRZSEYhklE3UGAd7m9BrF+j3xx7fpLxYw5G7 1VMUogKi6TR/0cbBUwk/2FZTYlQCKpzmaPTSSPUgmvj/YYsf5+5/GDVr0rxF8MED1qDI twwOUgXcoKjvLpX0DVmzbfIam4rykPBZcGyEHLAYhezZnq2/F9Zqvz9+rEdpns6oNhI/ B2Ud9StSLKijSk5bYHTXUoXfVLLbv9DSbdboUBl7xjsDS4g0EW+mmFnrSf15qZxJ9IAt 2SA3AppoBn/gExs98n9HfY7jbLe8Ut7UOHjCsi17VITYUw+agdRTa2LZbWEUGmww+KQV 0uoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=dD7dOLXb+YQYq589HrH7forsalWY8+LJ4rBHpm/SHRw=; b=Ykp261IX8D9kHMS28UOd5LKclg5TNcW3qfevdlGo7yFgInI/gb+1H5yVrzbK3x5yMO /imvcg9XixRmrEItWkXw5SKjMilD6hJqm6BARcSIAgQnf9vb+fMI6OCFWR0EIdZYdX9X IcL7qxldV/RepZze8hKDZgEsralWBNdVViNqT6XDEFCwiplEp0Oxm6lChJFfIxGCCu7p /5J8Ixu/5eojBm0Is217TijogEO7WsFMM9bcPkvA1f3k7CoejvQVb7i2YDKSUnwqAdOG /3/xWJTgwAGmuB/HB0belDOmFGuGosA1k+0hIraxdDc9dS8gtNE7qUKhfilAy3ju5GcQ TJGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=gRTdqJHK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q199si14989658pgq.643.2022.01.24.11.52.02; Mon, 24 Jan 2022 11:52:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=gRTdqJHK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245212AbiAXSUf (ORCPT + 99 others); Mon, 24 Jan 2022 13:20:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241869AbiAXSUX (ORCPT ); Mon, 24 Jan 2022 13:20:23 -0500 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4121C06173B for ; Mon, 24 Jan 2022 10:20:22 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id x37so12822543pfh.8 for ; Mon, 24 Jan 2022 10:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=dD7dOLXb+YQYq589HrH7forsalWY8+LJ4rBHpm/SHRw=; b=gRTdqJHKCLMkSZ3bmFhgUlfkqnsGok83Bdw5ohbB+I4EGKL6koKg7mnrTsh5YuMBLa GKVPoF7oCPhLtG/voaI0hrXtEDgvwdvX9ISnG4Co2a5itSLEAKDL4E6DmN8zOpsfwmNq c+RR9Pzr/NoDUNdSUiTg3T+GaucTB45uBXKpK7LHeRF2sDhEkjwk6UcdD4kB4221HScc V1Sfw3DzXLotVi01fh06jyDfTnUzIJ9DmoO/4r7Gh0MvqQx3wsDe7Mw9xj1KK9JEqhsB GH9cThxBfs6YAdrp63S8R3uwKE4MIutDdJa0hJSb5kYB7fuNcyX7gcbggWsNZgCM8AH2 n/Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=dD7dOLXb+YQYq589HrH7forsalWY8+LJ4rBHpm/SHRw=; b=o2taO6/lu9blQ2gutKypT99yAtYQ///9zaHKwnwUyOyDw3yRm3rQEP94RjXM5n/LdR be0o5gatm4+40Tz5OoSTwGRXOY2amOCeS98w2r2wV+imCsUAfTCjdx4aWQ+tlqQrt8OZ vgQdWN/LFA0r/OGgDsoWini99jujOcXZvcmN8wQOj7e8ijfNd4xV7v2GzEX0cJWQkvp3 93nFOYlLWtuTZJQ4qy4/PzYJywWyj7e2VQaLOBzFWlMfEa5Fmg+O5XieEOIcG0BsAyMG gXYKN0EM0Wy5Wkj0GzkPIBaOMXilrWw6oYYUBuZxF81VEjY19ZlNfmzfrk3tePr1IUE9 e5Cg== X-Gm-Message-State: AOAM530U+OitkstZAV8OilWci9bpC7yYEPkgvihsqngHntWWUoZetSwP lZC6Uod6/4obbM5hxwvBGxallA== X-Received: by 2002:a63:ea51:: with SMTP id l17mr6080241pgk.450.1643048421931; Mon, 24 Jan 2022 10:20:21 -0800 (PST) Received: from [2620:15c:29:204:1f99:bd65:fcbb:146c] ([2620:15c:29:204:1f99:bd65:fcbb:146c]) by smtp.gmail.com with ESMTPSA id x12sm12678911pge.58.2022.01.24.10.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 10:20:21 -0800 (PST) Date: Mon, 24 Jan 2022 10:20:20 -0800 (PST) From: David Rientjes To: Baolin Wang cc: sj@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/damon: Remove redundant page validation In-Reply-To: <6d32f7d201b8970d53f51b6c5717d472aed2987c.1642386715.git.baolin.wang@linux.alibaba.com> Message-ID: References: <6d32f7d201b8970d53f51b6c5717d472aed2987c.1642386715.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Jan 2022, Baolin Wang wrote: > It will never get a NULL page by pte_page() as discussed in thread [1], > thus remove the redundant page validation to fix below Smatch static > checker warning. > > mm/damon/vaddr.c:405 damon_hugetlb_mkold() > warn: 'page' can't be NULL. > > [1] https://lore.kernel.org/linux-mm/20220106091200.GA14564@kili/ > > Reported-by: Dan Carpenter > Signed-off-by: Baolin Wang > Reviewed-by: SeongJae Park Acked-by: David Rientjes