Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3545156pxb; Mon, 24 Jan 2022 11:53:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJx7JhH3xJSPMKtL2FxhB4LIAbsitN3F3LuxUFiIvZ25xwL6m8DJWonrNNVvLNAKlIof/Dhy X-Received: by 2002:a63:87c2:: with SMTP id i185mr3359647pge.75.1643054025781; Mon, 24 Jan 2022 11:53:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643054025; cv=none; d=google.com; s=arc-20160816; b=en1nzFRyPmn+uCLFFtM+OqRoiNbRNlGIHCVA0M6anGFTZZjPaZsYtCN7Hge8Bi3qpF f98CU3aMUxE5ThE5y9ctBs031WxS5yb2LBttQUYlO+Hne6jZTNcV2pZkFCC/Ozmb68pD JT93wzNsChdhpzFBRf7j/i7un5quREvA0P2W1ijKFFkng1pPLetKMZaLBAheJVUMyoWA fg7u5ZewBGkkcNAigeUTVJyxFNniILCAd/k56t1rzQl6HHEJrWjA5qdee4gjXKa6Pr1C 1jY0tLofe3rl9a7GyrCoMkCTER7F2hp6fVlJD/EyVEATqhB/C5t9MTINOSDsDfIgb7Sp mgYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=DXDAZKplR4NbvesCUYu5vvO3sZJFrebgqy6TrizYOJw=; b=u20le4oyK/7a7yF2TGSt1hH0qV59YI4yJsExEcfRXo2zGVYS4ft4plTM91EMWliVXn IFbrwgQXoHla6sOCk+2Mj+hZ50QcJ35xWNXKT9FY6/WVkDTraF5T9Q8+sDtmppo+Pscp e6nrjehisvpVTAUMEtMjhDEZwXyETxrLwAT2KCLWksq+RgQK9f+5agOFJ6c2nrLpB9NB ugp2ACKNSfbGHdtpLl8b6wdJmVf1xDlCuenNIRzYtFtVuIEdp721TI3W6mNoV/hRasFS Fkma4vTqQ4jRNd/9Wycr4Aqr2975T3TzB11ljPHYpy+vyWSXonjKlBYF87DMrWB0avqt wplg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UCfBDbor; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rm9si244494pjb.26.2022.01.24.11.53.30; Mon, 24 Jan 2022 11:53:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UCfBDbor; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245064AbiAXSnz (ORCPT + 99 others); Mon, 24 Jan 2022 13:43:55 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:45316 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230499AbiAXSny (ORCPT ); Mon, 24 Jan 2022 13:43:54 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1CE99614D0; Mon, 24 Jan 2022 18:43:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F03F6C340E5; Mon, 24 Jan 2022 18:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643049833; bh=fjJSY7FugE5Gp1KTxk0Zobf8q54Y/LM7PG/4KE3Tjb4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UCfBDborgjCRg9qTZ252s9MeFIaljnltkwv73lPNL5IDOBRJRNujJaZuSgRc4mbMG Xa0zNzG/X9lqY5RF4Nk273KuNDvTD7cUsbW7F6EcmHi+g5e6xvcoezUCb9bNmDmAL9 X4VK6HcYU6JgH3x6u+nF5Snh4+868bjkaKeI3V39m/ByQAZ5DGfPxxkm0/lCgr0Oq7 cc3Ln3jEKVpF6mCHFSeixXap8HeV+LVZjnt0APiJ2BWiDisFipoRtdp1h9GqTn0LGb Ot91vltjJd38nPLkBsIyKcwnmGgmBTKAZncplUAc352I6aCDDMDajSE7BDOpWlF8G7 rOiwv+e5EilZg== Date: Mon, 24 Jan 2022 10:43:51 -0800 From: Jakub Kicinski To: Jisheng Zhang Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: dwmac-sun8i: fix double disable and unprepare "stmmaceth" clk Message-ID: <20220124104351.2d5cab46@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20220123132805.758-1-jszhang@kernel.org> References: <20220123132805.758-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 23 Jan 2022 21:28:05 +0800 Jisheng Zhang wrote: > Fix warnings on Allwinner D1 platform: > > [ 1.604695] ------------[ cut here ]------------ > [ 1.609328] bus-emac already disabled Reading Samuel's feedback it sounds like the change will have to be reposted with a different commit message (either explaining why the fixes indeed works or as a clean up not a fix). Marking Changes Requested in patchwork.