Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751606AbXBFI2u (ORCPT ); Tue, 6 Feb 2007 03:28:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751596AbXBFI2u (ORCPT ); Tue, 6 Feb 2007 03:28:50 -0500 Received: from smtp.osdl.org ([65.172.181.24]:55050 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbXBFI2t (ORCPT ); Tue, 6 Feb 2007 03:28:49 -0500 Date: Tue, 6 Feb 2007 00:28:39 -0800 From: Andrew Morton To: Nick Piggin Cc: Linus Torvalds , Hugh Dickins , Linux Kernel , Linux Memory Management , Linux Filesystems Subject: Re: [patch 3/3] mm: make read_cache_page synchronous Message-Id: <20070206002839.f02a47bc.akpm@linux-foundation.org> In-Reply-To: <20070206054957.21042.18724.sendpatchset@linux.site> References: <20070206054925.21042.50546.sendpatchset@linux.site> <20070206054957.21042.18724.sendpatchset@linux.site> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 23 On Tue, 6 Feb 2007 09:02:33 +0100 (CET) Nick Piggin wrote: > Ensure pages are uptodate after returning from read_cache_page, which allows > us to cut out most of the filesystem-internal PageUptodate_NoLock calls. Normally it's good to rename functions when we change their behaviour, but I guess any missed (or out-of-tree) filesystems will just end up doing a pointless wait_on_page_locked() and will continue to work OK, yes? > I didn't have a great look down the call chains, but this appears to fixes 7 > possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in ecryptfs, > 1 in jffs2, and a possible cleared data overwritten with readpage in block2mtd. > All depending on whether the filler is async and/or can return with a !uptodate > page. > > Also, a memory leak in sys_swapon(). Separate patch? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/