Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3564604pxb; Mon, 24 Jan 2022 12:19:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQBTiHF5EezkT87Lu9ufY25AUuVhj4/s7uhvQOEV0ozLMOP064GSUrFWz2cfSfS8TyVXLp X-Received: by 2002:a05:6a00:9a9:b0:4c1:c43e:75e4 with SMTP id u41-20020a056a0009a900b004c1c43e75e4mr15135741pfg.83.1643055476716; Mon, 24 Jan 2022 12:17:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643055476; cv=none; d=google.com; s=arc-20160816; b=MgzcRjdQhjv6lGlrG5NqhIFGZTUpBu/JgB0sfnZOh3/9Lbp1Pbg2IhE28SbTSkDihs 8gmyQueHvYTonsEYkKoOQdDUcRFHDoXZTPsjb3+Ex+VHHGeg6EY5ZSHnE89GiAvrTkbe e8CxC92QJmGJ2+dMdpSVOIwxo7xln3VU6qAC3qMsNgdsAVg2DpI20jZ08p4pgwBBVdfC pUahAxVubzHOLGLiCQsWSE/pwJ7FUDTD18iMMl6++C8Z7SnKMJfc65vwgjxHZ3BgkZEX fKC1BewTrMQVDHlOiIquugLhuSstL4PckOyQF3BlwYrV3mZv65UPRIc0jZD1ad4Kf2TD crYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Avc6wSGHT0jiyvUpjtgthv2hE97JirzWCpEXrtj7seU=; b=GmVhEh5tSjgAvAIQim0kL8P0VGqpeIGfa8xlbh/pKZ6aEe7DsYeRnrt2aHk9srgLS4 loXn+Ten8qJloJvZqYAm4MmA9HvcvptNOukfcFTUiRPtruDxeI9fHILa6v6kcmUnLikJ dVm0kJrPHOiNC0gRfRol4NXSOCtVvmxEc6Xzi+76iCXizRcggTH12cgIiqQw77Zf7I7W x8pfLW9X2SVjqfJb7ALI1vDxheVl/KsWUcO0NS6QHEx2eK2dz+4DR2iw1VOFjgiFAeQO KZujeE+pAUHrh1cGjJ1c213WvGeH+YDdASRoL9K8gWjct//Wzq1uhQlZU2K25WsRg453 x6fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xOpxhdFy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a7si14115104pga.785.2022.01.24.12.17.42; Mon, 24 Jan 2022 12:17:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xOpxhdFy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348818AbiAXTTp (ORCPT + 99 others); Mon, 24 Jan 2022 14:19:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345928AbiAXTLm (ORCPT ); Mon, 24 Jan 2022 14:11:42 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3E2EC061A78; Mon, 24 Jan 2022 11:03:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 71A61B81229; Mon, 24 Jan 2022 19:03:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DDD1C340E8; Mon, 24 Jan 2022 19:03:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643051004; bh=cmFmKzQla0TJ2W/zQcixIPDxHSs1U3Adar1ZY5DbftU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xOpxhdFynWf10SmWbM/o/rK2szg6ISiakTh2ZlaF+EwURPQ8PZxHgwj1Nwa/3dbG5 fefbw6vyoJIRQaMcl8o2t2/GZBXJpAMtQ/piZvm16PeWTeIZXS4xKD2jLTxUWgxd/u PQCbG9a2XOqTizpQgD+hZ0QhNbNfGqahtOgDpd5g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 4.14 023/186] media: em28xx: fix control-message timeouts Date: Mon, 24 Jan 2022 19:41:38 +0100 Message-Id: <20220124183937.865495483@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124183937.101330125@linuxfoundation.org> References: <20220124183937.101330125@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit d9b7e8df3aa9b8c10708aab60e72e79ac08237e4 upstream. USB control-message timeouts are specified in milliseconds and should specifically not vary with CONFIG_HZ. Fixes: a6c2ba283565 ("[PATCH] v4l: 716: support for em28xx board family") Cc: stable@vger.kernel.org # 2.6.16 Signed-off-by: Johan Hovold Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/em28xx/em28xx-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/media/usb/em28xx/em28xx-core.c +++ b/drivers/media/usb/em28xx/em28xx-core.c @@ -94,7 +94,7 @@ int em28xx_read_reg_req_len(struct em28x mutex_lock(&dev->ctrl_urb_lock); ret = usb_control_msg(udev, pipe, req, USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE, - 0x0000, reg, dev->urb_buf, len, HZ); + 0x0000, reg, dev->urb_buf, len, 1000); if (ret < 0) { em28xx_regdbg("(pipe 0x%08x): IN: %02x %02x %02x %02x %02x %02x %02x %02x failed with error %i\n", pipe, USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE, @@ -162,7 +162,7 @@ int em28xx_write_regs_req(struct em28xx memcpy(dev->urb_buf, buf, len); ret = usb_control_msg(udev, pipe, req, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, - 0x0000, reg, dev->urb_buf, len, HZ); + 0x0000, reg, dev->urb_buf, len, 1000); mutex_unlock(&dev->ctrl_urb_lock); if (ret < 0) {