Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3580768pxb; Mon, 24 Jan 2022 12:44:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJgrYNCEBavx/0H1c6MW1pZCywq82WR4wVSDoiU2GWxZEOIV0G/zAPjGEHMROWVxWMk3Og X-Received: by 2002:a63:bf48:: with SMTP id i8mr12771227pgo.368.1643057045024; Mon, 24 Jan 2022 12:44:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643057045; cv=none; d=google.com; s=arc-20160816; b=FgMwYkWSsHb0xuH7lQJF/DAgkQftFqOpy5s/JzPKFV1eGfvDyxyo0sjyXmZA5ndohD OwvdEx+Emq0FSgoelJhjgt9LYYxDeUrPxstxTF7OkPe1i292f49qMS89jeekgvpFsgqB jodyRjvPtrQleilTBYers2tL6r0HqCW/ZO/ggXFYqZNEIug3jJ5Syv4SG32Gdsgy0E16 CNBOEuvOv3N5ZpOdeV9QjcZ2oUbc/TPMkGpAX4JRrfHUrj+0SjUDmIb4rrq2ytDV+Y19 xxGKdzu5s/lJlM+xbFRhFOZASkmIf1LoxWLYsnxv5ue8WrXC0/o/K9LWaNfYM7aUT+HN iClw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/ScmnfgDsvAJ9ajvpfCzFgC83TCPYaeCDQsvU2ER+6o=; b=EW5KzZ48cGApvxImU08EXXUHVz2HWGSEW21JdUJbcGDdaIpkc3PmghGlcogBG1Vphw K1eQiPXCih7lGVikgaTo38at1W/vjRhGy9ai4KVjLko4tzQZluhWXXySrOBN0N71BLcc 4iLnFpMYUZEeSm73utZMbYivOFTEPrInS5BDKQ3kNtz0S4iC0XSfjLAPTjWjjWzAYU2F a9Qab3/MuoqceSoDbmXnxXnh/7b9U/rW29ns3IZyTBowH09ESczOwbZEBtocXhWl1Jsm UqE+l7+zZF3kQyvke8gpKXZeDrq9YWs3Y7BL0x7aZ47BCjTTFAwV7nT2y8/4bkEH+y14 sRMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gTSI4QUX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 138si14717848pgc.498.2022.01.24.12.43.36; Mon, 24 Jan 2022 12:44:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gTSI4QUX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354066AbiAXUCA (ORCPT + 99 others); Mon, 24 Jan 2022 15:02:00 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:34570 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354648AbiAXTg5 (ORCPT ); Mon, 24 Jan 2022 14:36:57 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9ED0D614DA; Mon, 24 Jan 2022 19:36:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A507C340E5; Mon, 24 Jan 2022 19:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643053016; bh=FYe4UVnzYe2hrRUNg/CIzkMESrbopJBXhiXreviRkXM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gTSI4QUXZuWz/KJXvqsSWmZjMiOL90u6I6NmppcCuk9K+vc5hnd+SYR12HlGoya77 RNP2RTHWri8WerEpwIITf9SESWJY9FYKepnU6EsdXrnWt8Hm0eP9txNoFE69leJKsA /LChZdcWFOX1OhGCaMtV+lHlpEiB7XW2/w2Vw3Zc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Petr Cvachoucek , Richard Weinberger Subject: [PATCH 5.4 249/320] ubifs: Error path in ubifs_remount_rw() seems to wrongly free write buffers Date: Mon, 24 Jan 2022 19:43:53 +0100 Message-Id: <20220124184002.460673837@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124183953.750177707@linuxfoundation.org> References: <20220124183953.750177707@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Petr Cvachoucek commit 3fea4d9d160186617ff40490ae01f4f4f36b28ff upstream. it seems freeing the write buffers in the error path of the ubifs_remount_rw() is wrong. It leads later to a kernel oops like this: [10016.431274] UBIFS (ubi0:0): start fixing up free space [10090.810042] UBIFS (ubi0:0): free space fixup complete [10090.814623] UBIFS error (ubi0:0 pid 512): ubifs_remount_fs: cannot spawn "ubifs_bgt0_0", error -4 [10101.915108] UBIFS (ubi0:0): background thread "ubifs_bgt0_0" started, PID 517 [10105.275498] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000030 [10105.284352] Mem abort info: [10105.287160] ESR = 0x96000006 [10105.290252] EC = 0x25: DABT (current EL), IL = 32 bits [10105.295592] SET = 0, FnV = 0 [10105.298652] EA = 0, S1PTW = 0 [10105.301848] Data abort info: [10105.304723] ISV = 0, ISS = 0x00000006 [10105.308573] CM = 0, WnR = 0 [10105.311564] user pgtable: 4k pages, 48-bit VAs, pgdp=00000000f03d1000 [10105.318034] [0000000000000030] pgd=00000000f6cee003, pud=00000000f4884003, pmd=0000000000000000 [10105.326783] Internal error: Oops: 96000006 [#1] PREEMPT SMP [10105.332355] Modules linked in: ath10k_pci ath10k_core ath mac80211 libarc4 cfg80211 nvme nvme_core cryptodev(O) [10105.342468] CPU: 3 PID: 518 Comm: touch Tainted: G O 5.4.3 #1 [10105.349517] Hardware name: HYPEX CPU (DT) [10105.353525] pstate: 40000005 (nZcv daif -PAN -UAO) [10105.358324] pc : atomic64_try_cmpxchg_acquire.constprop.22+0x8/0x34 [10105.364596] lr : mutex_lock+0x1c/0x34 [10105.368253] sp : ffff000075633aa0 [10105.371563] x29: ffff000075633aa0 x28: 0000000000000001 [10105.376874] x27: ffff000076fa80c8 x26: 0000000000000004 [10105.382185] x25: 0000000000000030 x24: 0000000000000000 [10105.387495] x23: 0000000000000000 x22: 0000000000000038 [10105.392807] x21: 000000000000000c x20: ffff000076fa80c8 [10105.398119] x19: ffff000076fa8000 x18: 0000000000000000 [10105.403429] x17: 0000000000000000 x16: 0000000000000000 [10105.408741] x15: 0000000000000000 x14: fefefefefefefeff [10105.414052] x13: 0000000000000000 x12: 0000000000000fe0 [10105.419364] x11: 0000000000000fe0 x10: ffff000076709020 [10105.424675] x9 : 0000000000000000 x8 : 00000000000000a0 [10105.429986] x7 : ffff000076fa80f4 x6 : 0000000000000030 [10105.435297] x5 : 0000000000000000 x4 : 0000000000000000 [10105.440609] x3 : 0000000000000000 x2 : ffff00006f276040 [10105.445920] x1 : ffff000075633ab8 x0 : 0000000000000030 [10105.451232] Call trace: [10105.453676] atomic64_try_cmpxchg_acquire.constprop.22+0x8/0x34 [10105.459600] ubifs_garbage_collect+0xb4/0x334 [10105.463956] ubifs_budget_space+0x398/0x458 [10105.468139] ubifs_create+0x50/0x180 [10105.471712] path_openat+0x6a0/0x9b0 [10105.475284] do_filp_open+0x34/0x7c [10105.478771] do_sys_open+0x78/0xe4 [10105.482170] __arm64_sys_openat+0x1c/0x24 [10105.486180] el0_svc_handler+0x84/0xc8 [10105.489928] el0_svc+0x8/0xc [10105.492808] Code: 52800013 17fffffb d2800003 f9800011 (c85ffc05) [10105.498903] ---[ end trace 46b721d93267a586 ]--- To reproduce the problem: 1. Filesystem initially mounted read-only, free space fixup flag set. 2. mount -o remount,rw 3. it takes some time (free space fixup running) ... try to terminate running mount by CTRL-C ... does not respond, only after free space fixup is complete ... then "ubifs_remount_fs: cannot spawn "ubifs_bgt0_0", error -4" 4. mount -o remount,rw ... now finished instantly (fixup already done). 5. Create file or just unmount the filesystem and we get the oops. Cc: Fixes: b50b9f408502 ("UBIFS: do not free write-buffers when in R/O mode") Signed-off-by: Petr Cvachoucek Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman --- fs/ubifs/super.c | 1 - 1 file changed, 1 deletion(-) --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c @@ -1835,7 +1835,6 @@ out: kthread_stop(c->bgt); c->bgt = NULL; } - free_wbufs(c); kfree(c->write_reserve_buf); c->write_reserve_buf = NULL; vfree(c->ileb_buf);