Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3585362pxb; Mon, 24 Jan 2022 12:52:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJwRuZrn2hoQ3jFzD9+Uq5vr/VkLInEy4PYY/Xf+/L/G1MsuWGiNY15ge9hHXQVuwZQDx6LH X-Received: by 2002:a17:902:c407:b0:14b:6f06:6143 with SMTP id k7-20020a170902c40700b0014b6f066143mr1104173plk.47.1643057522713; Mon, 24 Jan 2022 12:52:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643057522; cv=none; d=google.com; s=arc-20160816; b=OwoqbzUl6J03temxibxbfAbetHxunxUel6qNo7Db/klcQ1Qmmlz8IfQSfAjVt7PJSA Lj5JpoPy1NVDZj6Ta7fyLLAic2cbgrr2cAnnv4OHniDhnT+UCfFP2z09ZB2gLZumjy5D zjGmlO4q5s+bXil85YPAs01fgl0XMWZXnIrQM7VnI9FDsX9TLGzFyMn6CWGecEpRboE2 WsLOKc0E8LwAbmstaG7CYMTDX4uQX/WD0xP2DnjPt2SjQH7bIEVy85EF4BTTi8wJh0RD Haoy0omQWy+hk6hVKhIG+PyJ/OWfL9Khr0PRzmt+Ymo+cVIEkL1MiSuyRiObDdeR3NXc OvIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2dZpo2CIOLN2QCmG7HEDO0MKAsY8iH1J9mbCqdDzIng=; b=pz68OH/+hda0ICeY4Y4JZ04iS65fYhHzEmFibfxdof2yZl2ChKOzXq3wB+qUFMAJqY 52bDtOfn7DYtbe2PqkbWo272cOfUbmyfWuDGXSOSN3zZg2XGVTM1WVHmSXkaf0OzDIM3 OIqz8WrNA7lNNepJtTVekfU9Y50ZiT3Pn22BtAanrm9pyZbcucYDA/nkZtOklmo1i30q 2dYv3tH4FnMNtAnQlpi/AOerfIFv2l4dUDBNN63XMYMuBEA06laHXc/HkiGQ2TP3DuEB xtK+Z0Qkv8JxJUcCHWuS+9YXvspk08doeNLGRc2+YvhrXLU7CjdmaY1HlaPlM8tOhunB rw2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KYT7yEsa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h6si13317212plt.457.2022.01.24.12.51.50; Mon, 24 Jan 2022 12:52:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KYT7yEsa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377528AbiAXUFf (ORCPT + 99 others); Mon, 24 Jan 2022 15:05:35 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:44854 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356961AbiAXTrp (ORCPT ); Mon, 24 Jan 2022 14:47:45 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F2F916131E; Mon, 24 Jan 2022 19:47:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D28F9C340E5; Mon, 24 Jan 2022 19:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643053663; bh=CK6VH06TPdfkCC62W0JQK2cm9ehLj5Fn/1ycjcQy56A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KYT7yEsaYx1I/rEOAu6v3yqkqdooAt9xf3LR2cKnbH2M5DkXjITWEXijryNpuWZnI XJCZgBPG5kFVThPz/ksZcrW/4OBHA4zPsjWQrjt7GsJooZbDHKaIDeUoSGku/zvW67 0nrLhtvuiUZWVDT/d98y0Vkh/iDZ8/2EEI5WyoXE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , Sasha Levin Subject: [PATCH 5.10 136/563] bpf: Adjust BTF log size limit. Date: Mon, 24 Jan 2022 19:38:21 +0100 Message-Id: <20220124184029.099971589@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184024.407936072@linuxfoundation.org> References: <20220124184024.407936072@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexei Starovoitov [ Upstream commit c5a2d43e998a821701029f23e25b62f9188e93ff ] Make BTF log size limit to be the same as the verifier log size limit. Otherwise tools that progressively increase log size and use the same log for BTF loading and program loading will be hitting hard to debug EINVAL. Signed-off-by: Alexei Starovoitov Signed-off-by: Andrii Nakryiko Link: https://lore.kernel.org/bpf/20211201181040.23337-7-alexei.starovoitov@gmail.com Signed-off-by: Sasha Levin --- kernel/bpf/btf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index aaf2fbaa0cc76..72534a6f4b96e 100644 --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@ -4135,7 +4135,7 @@ static struct btf *btf_parse(void __user *btf_data, u32 btf_data_size, log->len_total = log_size; /* log attributes have to be sane */ - if (log->len_total < 128 || log->len_total > UINT_MAX >> 8 || + if (log->len_total < 128 || log->len_total > UINT_MAX >> 2 || !log->level || !log->ubuf) { err = -EINVAL; goto errout; -- 2.34.1