Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbXBFM0b (ORCPT ); Tue, 6 Feb 2007 07:26:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751827AbXBFM0b (ORCPT ); Tue, 6 Feb 2007 07:26:31 -0500 Received: from colin.muc.de ([193.149.48.1]:2374 "EHLO mail.muc.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbXBFM0a (ORCPT ); Tue, 6 Feb 2007 07:26:30 -0500 Date: 6 Feb 2007 13:26:28 +0100 Date: Tue, 6 Feb 2007 13:26:28 +0100 From: Andi Kleen To: Zachary Amsden Cc: Linux Kernel Mailing List , Andrew Morton , Rusty Russell , Jeremy Fitzhardinge , Chris Wright Subject: Re: [PATCH 8/11] Add a CPU KHZ calibration function to paravirt-ops Message-ID: <20070206122628.GB47229@muc.de> References: <200702060353.l163rNP7000763@zach-dev.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200702060353.l163rNP7000763@zach-dev.vmware.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 19 On Mon, Feb 05, 2007 at 07:53:23PM -0800, Zachary Amsden wrote: > Provide a paravirtualized way to get the CPU clock frequency; this allows much > of the code in tsc.c to be shared between all paravirt implementations. Is this really needed? What worries me somewhat of your patches is that you seem to be quick at adding new hooks. But I would like to keep paravirtops as minimal as possible with new hooks only added when there is a very good justification. I don't see it here. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/