Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3589951pxb; Mon, 24 Jan 2022 12:59:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJzSqCRKDLm4ZZ5n7U2IpqrPpqYPzNkjqgv8cxFWlMk94MkwPKGeZmzXl9aAkKq1yBisQkwL X-Received: by 2002:a17:90a:7c41:: with SMTP id e1mr105979pjl.9.1643057957162; Mon, 24 Jan 2022 12:59:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643057957; cv=none; d=google.com; s=arc-20160816; b=0a+lcjl8+a2KlT5h6QB/aofLtDYVsqsab/2RZnY3H+7zG+OToX8Z1x2aKF1mHMK1an ZPdC8U6QnfVlzWkiNyqOH7WMcJ85QSaqaFmc6I+O7NrA+AECQi7OjfKSCcmPyVHULN7g QRJ6Ouey6o72m8oQ7fshO/Vd/E/vI8O/h5uMqnpLFBnEVLjLyo+hqd3hIyIDwwMKacR1 wXvvCvVOCC8/6N3+FP0Jx/2/bE5Zw4bQTPlbalV5BuLcpzPCc5udxNot9vdxhvMxiIvo o8S0eXCZtesSOC9hZ6e6ZnhbqX3UEKMs6g/BZjpD5MZ3A3LH/f0WdwIGMhxFYxW6zuHU U80g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TgSVBYP2HdPltB+iuH7nZyRPgyRvGO86R56aFB3WuZk=; b=vogMIAnXkCBYMHCkeEnVsojTJWBhwPOt1bbG4OGP9lOi+bypyg2FD6VsK5Cl1AW60/ KpCEEdbNaKDGLq3vTHHPZL/2YhXE16QmgpUUuxzveK9rry5Imc5GODgGwRKa3hT09Tz5 BoK69irQRiiFA3H6cDic5RjH7MDp1QFF7GeaFb5peDiBVsyVjtC3XVIJXp1fh0SoYQA+ ycTDRdxbDUWKjjT7RaIqW8JiRylyfaMYAwbZn66cK8aNwY43K3nzTNt1Wk2Skaf1o8le OFfokLa/BI6RVzcXDjd/sUHC1IMO8qjOpACag26jZ5yTYRfO29OJwvMGKdbFBuKJRPS2 g8Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bB4AhEl+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c8si18014356pgq.661.2022.01.24.12.59.04; Mon, 24 Jan 2022 12:59:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bB4AhEl+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354022AbiAXUY2 (ORCPT + 99 others); Mon, 24 Jan 2022 15:24:28 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:49206 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357770AbiAXTvq (ORCPT ); Mon, 24 Jan 2022 14:51:46 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C2295601B6; Mon, 24 Jan 2022 19:51:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93A27C340E5; Mon, 24 Jan 2022 19:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643053905; bh=zYvhXmgk5raJcaWJoqoTorEjCgspp2OTg+ecp5a6CF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bB4AhEl+8eQuy7HCEyDEQ7mwvUpZAjTw0YTmHsVVOBjr089i5Kk3RZY4TUjRcEmQx yk2iN7IvGFcpYr2f4N2wzdehzcqqQj94Bd9z8yEsH+rtFc+0g+KMeDepXTUgnmGj+5 sRbECibJ0ccO/ilp3Uf5V4UTNBqxvQrFC4FgTN9k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sergey Shtylyov , Martin Blumenstingl , Ulf Hansson , Sasha Levin Subject: [PATCH 5.10 182/563] mmc: meson-mx-sdhc: add IRQ check Date: Mon, 24 Jan 2022 19:39:07 +0100 Message-Id: <20220124184030.714161210@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184024.407936072@linuxfoundation.org> References: <20220124184024.407936072@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergey Shtylyov [ Upstream commit 77bed755e0f06135faccdd3948863703f9a6e640 ] The driver neglects to check the result of platform_get_irq()'s call and blithely passes the negative error codes to devm_request_threaded_irq() (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original error code. Stop calling devm_request_threaded_irq() with the invalid IRQ #s. Fixes: e4bf1b0970ef ("mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host") Signed-off-by: Sergey Shtylyov Reviewed-by: Martin Blumenstingl Link: https://lore.kernel.org/r/20211217202717.10041-2-s.shtylyov@omp.ru Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/meson-mx-sdhc-mmc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mmc/host/meson-mx-sdhc-mmc.c b/drivers/mmc/host/meson-mx-sdhc-mmc.c index 8fdd0bbbfa21f..28aa78aa08f3f 100644 --- a/drivers/mmc/host/meson-mx-sdhc-mmc.c +++ b/drivers/mmc/host/meson-mx-sdhc-mmc.c @@ -854,6 +854,11 @@ static int meson_mx_sdhc_probe(struct platform_device *pdev) goto err_disable_pclk; irq = platform_get_irq(pdev, 0); + if (irq < 0) { + ret = irq; + goto err_disable_pclk; + } + ret = devm_request_threaded_irq(dev, irq, meson_mx_sdhc_irq, meson_mx_sdhc_irq_thread, IRQF_ONESHOT, NULL, host); -- 2.34.1