Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3602415pxb; Mon, 24 Jan 2022 13:16:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJzEIa9HcIPp1pfJDm1WuUREf/Lc6ndBorBzfD6O1THr96gAJ4A7zELicql+/I/4sdIURfFS X-Received: by 2002:a17:902:6502:b0:149:1162:f0b5 with SMTP id b2-20020a170902650200b001491162f0b5mr15813149plk.126.1643058976650; Mon, 24 Jan 2022 13:16:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643058976; cv=none; d=google.com; s=arc-20160816; b=bJ4+mouLEfes3Pe7E6n7b0f8GqScx3ZqByaWS23siyo2MgFtaJpDg/4cWXuRyW9+r6 dqva6SV63dYJdjyaHOmv6cLAa+7ipeKuKuELmPHnjQzaXiX+smWWj9L5gJRRZDt2W6g7 C8JtnqAw+KvXStPPid/AlyPGxRrX0OlEEIXVqEm66bBJAXrdnpker2dlWt3DLPnlcO/H KPalj97RFWkmZMFMWWQaGWUTxHGGwujgd4cQAGro/5gNcvYxlSWM4GtKHGmkyxwIKd3V wE3AA94QRhsd9hIE5yei2GJFKUO0Omvyw9+c/ucKozC7ybHBhmFVWUuHOZVchtQ0fv2s jnLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cQ76vWYpPRaCth/RuBhXUyUJJFLiHpXcNUDGw9en+vE=; b=YDm97YBSDtjmARtZSON7cMJMbQ2jGC8exn7yaiCkXusRHP5LcZikU1x7opDxmXQ1L/ sTj8ZZetM28Zwv5OTJxyrc8jt+T2ht6GR393ZaDIkKON7YXnxF7XYQjE1F9wJkJZhbBR 2srX2PXCht9Xrommago61Q3Ur+fyJxudA4IRreXdLkwf5ZshZERuN/rr56xJWVDpp9g0 bdE4wFDbzqcPFwSlU4Oo+CvKVKHwJNCTj3dpyqiTS1lzHJde/xI+X6M5MgNdQrN6MEZ/ 6x4BYHxwp5GA3ynL7sCK7sYl+XuCfF7fgaLsw8Nudxnq5o5/qHiBH1taKhd6GcrJ/HK+ /QrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GLpdK5Vg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si16865778pfh.196.2022.01.24.13.16.04; Mon, 24 Jan 2022 13:16:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GLpdK5Vg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1390540AbiAXUpn (ORCPT + 99 others); Mon, 24 Jan 2022 15:45:43 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:48710 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383111AbiAXU0u (ORCPT ); Mon, 24 Jan 2022 15:26:50 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8CF02614ED; Mon, 24 Jan 2022 20:26:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 432E5C340E5; Mon, 24 Jan 2022 20:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643056008; bh=Cjk0iECMYt+AH0oHj+3Brzmx0TeIkzhg5vvVcqRICNY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GLpdK5Vg6e9gHP9paqMU02p1GLCp55tcbsQWSf3gDbkRiSldOlUBYY+b22lm5eQG8 BBi1cjhNElnCkrnhwHasoVU/siux78T0TpZOYOdDHlLAn8Co80SGweMPIxfH3MCa9x +1dyuoaxv31Xh38KA12/Ma8xug35bqO7SMdFRfdw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aya Levin , Gal Pressman , Saeed Mahameed , Sasha Levin Subject: [PATCH 5.15 340/846] Revert "net/mlx5e: Block offload of outer header csum for UDP tunnels" Date: Mon, 24 Jan 2022 19:37:37 +0100 Message-Id: <20220124184112.644560437@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184100.867127425@linuxfoundation.org> References: <20220124184100.867127425@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aya Levin [ Upstream commit 64050cdad0983ad8060e33c3f4b5aee2366bcebd ] This reverts commit 6d6727dddc7f93fcc155cb8d0c49c29ae0e71122. Although the NIC doesn't support offload of outer header CSUM, using gso_partial_features allows offloading the tunnel's segmentation. The driver relies on the stack CSUM calculation of the outer header. For this, NETIF_F_GSO_UDP_TUNNEL_CSUM must be a member of the device's features. Fixes: 6d6727dddc7f ("net/mlx5e: Block offload of outer header csum for UDP tunnels") Signed-off-by: Aya Levin Reviewed-by: Gal Pressman Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index baa0d7d48fc0c..a0bf3d386b708 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -4485,9 +4485,13 @@ static void mlx5e_build_nic_netdev(struct net_device *netdev) } if (mlx5_vxlan_allowed(mdev->vxlan) || mlx5_geneve_tx_allowed(mdev)) { - netdev->hw_features |= NETIF_F_GSO_UDP_TUNNEL; - netdev->hw_enc_features |= NETIF_F_GSO_UDP_TUNNEL; - netdev->vlan_features |= NETIF_F_GSO_UDP_TUNNEL; + netdev->hw_features |= NETIF_F_GSO_UDP_TUNNEL | + NETIF_F_GSO_UDP_TUNNEL_CSUM; + netdev->hw_enc_features |= NETIF_F_GSO_UDP_TUNNEL | + NETIF_F_GSO_UDP_TUNNEL_CSUM; + netdev->gso_partial_features = NETIF_F_GSO_UDP_TUNNEL_CSUM; + netdev->vlan_features |= NETIF_F_GSO_UDP_TUNNEL | + NETIF_F_GSO_UDP_TUNNEL_CSUM; } if (mlx5e_tunnel_proto_supported_tx(mdev, IPPROTO_GRE)) { -- 2.34.1