Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3602450pxb; Mon, 24 Jan 2022 13:16:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJz2ucquduRuVJ0Z3glcRXEP5GVdrt4D//ILe4h6XlTjrU7L5XQEEZvn5ZnPIg6FiNzeFTPc X-Received: by 2002:a17:90b:1c88:: with SMTP id oo8mr171226pjb.218.1643058978345; Mon, 24 Jan 2022 13:16:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643058978; cv=none; d=google.com; s=arc-20160816; b=ES5m15r0p13WhkickkYuBcJKtV6fkWEaFoeua/Mz8rIi7bCmAASwuHlXRbGKoTYaeT ehn7UCQPH2gC80KWVMoHqRboB2FaYuHyv0wxLlyTUOK/KXj1oNvPqzi6Gz6JPYABU8U8 ZDUamesBgEzRQ5ZwB49+GVwhGJzXmWaKkx8CHYVmGIEpqytAP2cHe084yxNVwywrPLGI CEYPywVSMEtS0OGL9fKOlMKYTGtzHRqGTuXoW/nQGjr4gYlwXBR8wMG0peUpzsdC0tTD IaG6/wVjXoUNRRkBVCPdZhf3zNRpwR1uS+f9swM2MO6caQEQLrXP+rWPtKm0rEyyOVxt EQQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RgeL2bkP9EVTAe6U37ccMFrl4vGTQDwG/dcI3L+T/80=; b=zpnrlLVqvNWVa1Yi6gvUWJz6l5qz18vNxAMbHBdHZSz4F5an4iUlO4jnCdrf8Qhi2C lKWl8zbtI19BlcD1+q9wMafldUiWSYonUhln0CIKhCDOhT9qLxN4IqmQ1p2zi6SGOLjR Hu9x/DduLDTs/PL8lcmnHFB7F5mN05XSe3pw9XmTtJ4YsqZP8APB7ZajcDDMmvO3A52b S+AqmExXn9YSgBHMX0IOtCSUq2j6kw8jUu7NaIJWf7kPL9WZWnw5JyNYiWixpXnADXiT vPvVkX08AnLEf2HXpAhCtyhhEj+eQt6Y+Ifa4UX+L7YLH8ftKmzRe36S8SbyrX3n6vYC OFzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jrcrmInZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p7si5320835plf.530.2022.01.24.13.16.06; Mon, 24 Jan 2022 13:16:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jrcrmInZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359209AbiAXUtg (ORCPT + 99 others); Mon, 24 Jan 2022 15:49:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382143AbiAXUZP (ORCPT ); Mon, 24 Jan 2022 15:25:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37741C0D9401; Mon, 24 Jan 2022 11:41:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 00438B81188; Mon, 24 Jan 2022 19:41:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D60FC340E7; Mon, 24 Jan 2022 19:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643053265; bh=Hu92IHuIu7s4YMY6zsMPO0Pu53VdOmAY8WOxRWr2+s0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jrcrmInZ3HwJ1sjuuco4N097n5uHUEszy7cEd8AyT5GoW/sWOX45lSeBL+/zM0pcl NavxtRxMFYbjLzu7LLPVHqWU0DhXNWvxgcPDIL9uTmOJ/6B8UIOw5rTBINZ2CAs1KD tIsVTYUr/cRKJYvUObzPv0S+QVMcvwImkgnpq4to= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andreas Oetken , Miquel Raynal Subject: [PATCH 5.10 010/563] mtd: Fixed breaking list in __mtd_del_partition. Date: Mon, 24 Jan 2022 19:36:15 +0100 Message-Id: <20220124184024.772483033@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184024.407936072@linuxfoundation.org> References: <20220124184024.407936072@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andreas Oetken commit 2966daf7d253d9904b337b040dd7a43472858b8a upstream. Not the child partition should be removed from the partition list but the partition itself. Otherwise the partition list gets broken and any subsequent remove operations leads to a kernel panic. Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling") Signed-off-by: Andreas Oetken Cc: stable@vger.kernel.org Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20211102172604.2921065-1-andreas.oetken@siemens-energy.com Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/mtdpart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mtd/mtdpart.c +++ b/drivers/mtd/mtdpart.c @@ -313,7 +313,7 @@ static int __mtd_del_partition(struct mt if (err) return err; - list_del(&child->part.node); + list_del(&mtd->part.node); free_partition(mtd); return 0;