Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3602764pxb; Mon, 24 Jan 2022 13:16:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJxOWNlEXO/Jrgv9Ez21f3TsgWFEWBSp7pAbMSARlVhkgB3Xd/VOC2LpWIx6f0MoBhfm6BUQ X-Received: by 2002:a17:90a:5d8d:: with SMTP id t13mr209683pji.47.1643059001620; Mon, 24 Jan 2022 13:16:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643059001; cv=none; d=google.com; s=arc-20160816; b=LtWBQ5yvZRGAxFZjYn6GRYbhOt76ccm2U8ivzF7iMDow0ewuvPD3ZSU6BcoF1/x6x1 8aiXe6GyniuzQY+6MfJT72YgXVR3dVEYPXVKi70M3dNvrTuCP7u5OsCDbFV5xzaChsQV jaHrqTijNnAbtyO6AF1W1TbFVKLNImnFKBePgp48lCsHdpR6l6VAF30aUe2XLfIjHLDm jKnXeoAmajNNLRwIuOmN8tjz4Zb6sxmpTxXcMd9wRmv6WIbB6cvzXoaF3akw9XyD1uiI IuN17dC5FGwa+wl1mckFJ8iSLD2xbNW7n79QhGpkHogiJ2pU2s2BJH6bPhgmn+hiKlUf lq4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jpU72TyPHN6zJzxCNkmBsvv6TRVB9VWRZKNVG3pRfD8=; b=Hk1F/n6BBJUALgADqje3V1t89RM64CfJyfEkD22w4o7FOBRUR0niQnvq8LLR//YV2R QMSJohS2xbDSQQKJaqhZgyCbti4DFtotbOs4202R2/MwjC5BDn+GzoHL9hGYwlJcmxai 4cSrNOXWiFMyco0b8qrMk9Y9oatzXM6KraLh6t5ptBbD76SMJbGmPYFUTkG+KdkxET0A +VuD0IwpSAaL+Me/Nrb36fxxzAR56/eXD7yvGGKDs2OgizMTDKnAKY92aYVflhYag11I cMm6Unu4Li02Lv31wbG5tP1LdZzPMtpj0UtnTITx5DdfFh6nFFYZ3Nbd422dy3kG2gDV Q8rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kb4XDSzv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n8si16518599plh.598.2022.01.24.13.16.29; Mon, 24 Jan 2022 13:16:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kb4XDSzv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1392262AbiAXUu4 (ORCPT + 99 others); Mon, 24 Jan 2022 15:50:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383657AbiAXU1e (ORCPT ); Mon, 24 Jan 2022 15:27:34 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F799C08254D; Mon, 24 Jan 2022 11:41:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3FAF261551; Mon, 24 Jan 2022 19:41:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06C37C340E5; Mon, 24 Jan 2022 19:41:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643053306; bh=lDnMZdm1qIoBNi8zGpb9L19ogrWHp8r6Rf4WFn0gvus=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kb4XDSzvDrg9iabil5PzGCxkFqC7UxkzNGEKZ3HqgV2AqNdqhuhUotTKhLKr3WUVK sQoh6e6PDfn3IMVKxJ21W0PNANn2h97V+OkiZiK1eg5qRCjXKUFMxyqMzeOc1IyY3G OOi9U2OWEztgYbItzuMmBJbnScZD4nCie1hcEjWQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 5.10 022/563] media: em28xx: fix control-message timeouts Date: Mon, 24 Jan 2022 19:36:27 +0100 Message-Id: <20220124184025.187005090@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184024.407936072@linuxfoundation.org> References: <20220124184024.407936072@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit d9b7e8df3aa9b8c10708aab60e72e79ac08237e4 upstream. USB control-message timeouts are specified in milliseconds and should specifically not vary with CONFIG_HZ. Fixes: a6c2ba283565 ("[PATCH] v4l: 716: support for em28xx board family") Cc: stable@vger.kernel.org # 2.6.16 Signed-off-by: Johan Hovold Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/em28xx/em28xx-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/media/usb/em28xx/em28xx-core.c +++ b/drivers/media/usb/em28xx/em28xx-core.c @@ -89,7 +89,7 @@ int em28xx_read_reg_req_len(struct em28x mutex_lock(&dev->ctrl_urb_lock); ret = usb_control_msg(udev, pipe, req, USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE, - 0x0000, reg, dev->urb_buf, len, HZ); + 0x0000, reg, dev->urb_buf, len, 1000); if (ret < 0) { em28xx_regdbg("(pipe 0x%08x): IN: %02x %02x %02x %02x %02x %02x %02x %02x failed with error %i\n", pipe, @@ -158,7 +158,7 @@ int em28xx_write_regs_req(struct em28xx memcpy(dev->urb_buf, buf, len); ret = usb_control_msg(udev, pipe, req, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, - 0x0000, reg, dev->urb_buf, len, HZ); + 0x0000, reg, dev->urb_buf, len, 1000); mutex_unlock(&dev->ctrl_urb_lock); if (ret < 0) {