Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3602837pxb; Mon, 24 Jan 2022 13:16:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJye1UDpX6Z4VwkgsJp2fT5veC9HotT7jPljIqKybCmCwoJFLQXuoXR7szFQNwPLAfGBTn9J X-Received: by 2002:a17:90b:1c03:: with SMTP id oc3mr211787pjb.27.1643059007898; Mon, 24 Jan 2022 13:16:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643059007; cv=none; d=google.com; s=arc-20160816; b=eSdwOqqiwnUYkhxNw2gbLDdnEohoeT3p3ygFM9/3FLKT9PTrFWA3Di0ONahu4MDNoo i57FXnKi22tzHQRuoXgZPgcwr+8AXU7PeA3xP3ybgerYAPOFCY0invzDq1usI7q07qUa ZeN7PBX067ziZA4cEP9QBlFlb3B6VYpya/g6moo6iHBguzmjUExq9NNSjVc671iY0gYq DAe6+WWsNQys/r0NrfTHNmItmREsi1ljPl3T+GOVUO4QcS6tIl9jkEgiDvThaSIs/nFT oJ3Hd0WSabRdNs4Fuci/jVbxo0CO83UNzzzgQd3w+eZw45Ptj4UMYz1af1uUOR1DTGN/ j09g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EgNEoO3u88A4rFO6s3gAIc1Q1wy4TM3dqdpDSFR7kPQ=; b=e7SPwjp6iKaknUxqMJeXdfq8nPJRykC4aZKja2cLT/hn0Ej+CpPg9a0SbOMCuBNQeC ZXpjE7lL7p91UGBB/vzTulVkXhHS0XlQA4qEkbYRlg+PbmCAkIVEkm11hfXxOkkgXsHL VkoZiH3aKEIsdKs7l5q2mteDG9X8GMn8sFEI0qorkXHKwihE/EiXxfutXLonpnwC1w5a DkeZLZUnqCNlcweyrbvEdrsEYGbhUapKRu28Ma1Gr2qsO/NWop3HpeQFycc9ndDTELzD CV9acByj0ikwn6TjqQYN44weOrZZvHwCwdvQEetd7utvDhN4b0MDu3gBn5w3RKpkH9f8 pLKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oPNc2suX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 43si383260pjz.148.2022.01.24.13.16.35; Mon, 24 Jan 2022 13:16:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oPNc2suX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351939AbiAXUnH (ORCPT + 99 others); Mon, 24 Jan 2022 15:43:07 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:32782 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354711AbiAXUX7 (ORCPT ); Mon, 24 Jan 2022 15:23:59 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B472BB8119E; Mon, 24 Jan 2022 20:23:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7D1EC340E5; Mon, 24 Jan 2022 20:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643055835; bh=/bLI7PY8b0pniFdtjS+4UE+h+UAG8zivzIo6Fo50J8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oPNc2suXpKqou3OkQr8A+65ICzhmAFtJ9azTJZfX1Z5X2dSuU9iDcgVXJyb7qCbp1 UyMCREGTc/iaNKI8IqpROs79B7x47Ou49de1LtWG5M+hwVcCUgHWT9r4lKjiffDNnX wKJN7g4mgp4ViszQoc8gBc9wcn7fyyA8Lqv8417c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Al Viro , Johannes Berg , Richard Weinberger , Sasha Levin Subject: [PATCH 5.15 281/846] lib/logic_iomem: Fix 32-bit build Date: Mon, 24 Jan 2022 19:36:38 +0100 Message-Id: <20220124184110.622146104@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184100.867127425@linuxfoundation.org> References: <20220124184100.867127425@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johannes Berg [ Upstream commit 4e84139e14af5ea60772cc4f33d7059aec76e0eb ] On a 32-bit build, the (unsigned long long) casts throw warnings (or errors) due to being to a different integer size. Cast to uintptr_t first (with the __force for sparse) and then further to get the consistent print on 32 and 64-bit. Fixes: ca2e334232b6 ("lib: add iomem emulation (logic_iomem)") Reported-by: Al Viro Signed-off-by: Johannes Berg Signed-off-by: Richard Weinberger Signed-off-by: Sasha Levin --- lib/logic_iomem.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/logic_iomem.c b/lib/logic_iomem.c index 9bdfde0c0f86d..54fa601f3300b 100644 --- a/lib/logic_iomem.c +++ b/lib/logic_iomem.c @@ -79,7 +79,7 @@ static void __iomem *real_ioremap(phys_addr_t offset, size_t size) static void real_iounmap(void __iomem *addr) { WARN(1, "invalid iounmap for addr 0x%llx\n", - (unsigned long long __force)addr); + (unsigned long long)(uintptr_t __force)addr); } #endif /* CONFIG_LOGIC_IOMEM_FALLBACK */ @@ -173,7 +173,7 @@ EXPORT_SYMBOL(iounmap); static u##sz real_raw_read ## op(const volatile void __iomem *addr) \ { \ WARN(1, "Invalid read" #op " at address %llx\n", \ - (unsigned long long __force)addr); \ + (unsigned long long)(uintptr_t __force)addr); \ return (u ## sz)~0ULL; \ } \ \ @@ -181,7 +181,8 @@ static void real_raw_write ## op(u ## sz val, \ volatile void __iomem *addr) \ { \ WARN(1, "Invalid writeq" #op " of 0x%llx at address %llx\n", \ - (unsigned long long)val, (unsigned long long __force)addr);\ + (unsigned long long)val, \ + (unsigned long long)(uintptr_t __force)addr);\ } \ MAKE_FALLBACK(b, 8); @@ -194,14 +195,14 @@ MAKE_FALLBACK(q, 64); static void real_memset_io(volatile void __iomem *addr, int value, size_t size) { WARN(1, "Invalid memset_io at address 0x%llx\n", - (unsigned long long __force)addr); + (unsigned long long)(uintptr_t __force)addr); } static void real_memcpy_fromio(void *buffer, const volatile void __iomem *addr, size_t size) { WARN(1, "Invalid memcpy_fromio at address 0x%llx\n", - (unsigned long long __force)addr); + (unsigned long long)(uintptr_t __force)addr); memset(buffer, 0xff, size); } @@ -210,7 +211,7 @@ static void real_memcpy_toio(volatile void __iomem *addr, const void *buffer, size_t size) { WARN(1, "Invalid memcpy_toio at address 0x%llx\n", - (unsigned long long __force)addr); + (unsigned long long)(uintptr_t __force)addr); } #endif /* CONFIG_LOGIC_IOMEM_FALLBACK */ -- 2.34.1