Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3602948pxb; Mon, 24 Jan 2022 13:16:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyB2JHZ0fHVTgqjBdqczZxMEfBdQjnCo8nM8WvOHYHKYivGXGZalqQfH6CIhzbKtcxPCB0t X-Received: by 2002:a63:9d8a:: with SMTP id i132mr12785826pgd.329.1643059016883; Mon, 24 Jan 2022 13:16:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643059016; cv=none; d=google.com; s=arc-20160816; b=lUcD4354e9hBQx1hcaw514FY2GKrVDZMidTzTZ0WuUt/bDsw5CDurym3PDvP8xfUe9 fT5F7usUH05Fr+huFnmRMYlhcqwyvGtQnfAmqTd1BxEhga7KdG3qRFQkeRxNzXgCciNJ ogMOcOE1k/bahpUQm7KSJV+U96FKI7EECu7SltCh0HMMKW9qRAJx6C4SzWdnD/tnkY5a il4U9r48Qt1nnFzWXNSviDlRfgnCtVqbLOO9yYT1iNZZIjDPG5XMutYKRIxbr5/jpjVq 17PSaou6ZrUNbVOFOik2KPpqvpePMWxBh4IPru6j5X8jUuE4FIBVZTEYhzSDX9NH9np/ hEqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=reIrG3a2NIwNfH97H5l2EWW40jyQz30Majok6Nwolzg=; b=bzYK4UIzCFTRE0PE81c82rU7xiXMwXq/4I6hPtJK2ji4IDN3dpvVOb5kPpLeQt/vQ7 BPcchfPw3Qxe+VNNbvr6xNOCDUoKMdGGxYqrvC9y9wYzVSq8FfH9mLpelY9WACjOSOVT 2ArwfedgoUVJWwNYEiwwENLZrmrAFpk00tCFdc6KmQZrm5tVkCQK1Es3EMiHO5ymy46k znxE3nyPvjbFvsvrtMDreEEGoOcpd3g39QOog1IcvpPtQ/2hCujbCmRtWXkLjaD/VVCp 0YQqwyDdV1aUxgKt/Ak3et2IoBlTLgV5zc+JoyMsxNKsnjXHjpknUFN/rZpVXu6D/adm ZurQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Mawaqr07; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z6si3136513pfe.233.2022.01.24.13.16.44; Mon, 24 Jan 2022 13:16:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Mawaqr07; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348434AbiAXUlk (ORCPT + 99 others); Mon, 24 Jan 2022 15:41:40 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:58724 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355702AbiAXUWQ (ORCPT ); Mon, 24 Jan 2022 15:22:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 133DBB811F9; Mon, 24 Jan 2022 20:22:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 492FDC340E5; Mon, 24 Jan 2022 20:22:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643055733; bh=WuhYVlVH6hrjU6oz3Z+NaALUBIDERrBjbaDwmauXbdc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mawaqr07xcI5LaBgxiRYFrtefp+/9UKO5nVy2gLy6tgQUrVe7h6AZr74KouPujQvJ c/NX/zYpPNK7sT7KD7cFbnED+roi+RKw+dlA4kXY5meNGAF24IBndaf8/qpf+kGJnd LyDG3D5UHd2cEBOViFbqe3gZaaQYWslHqW5h07hI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kurt Kanzenbach , Vladimir Oltean , Richard Cochran , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 247/846] net: dsa: hellcreek: Fix insertion of static FDB entries Date: Mon, 24 Jan 2022 19:36:04 +0100 Message-Id: <20220124184109.470704169@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184100.867127425@linuxfoundation.org> References: <20220124184100.867127425@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kurt Kanzenbach [ Upstream commit 4db4c3ea56978086ca367a355e440de17d534827 ] The insertion of static FDB entries ignores the pass_blocked bit. That bit is evaluated with regards to STP. Add the missing functionality. Fixes: e4b27ebc780f ("net: dsa: Add DSA driver for Hirschmann Hellcreek switches") Signed-off-by: Kurt Kanzenbach Reviewed-by: Vladimir Oltean Acked-by: Richard Cochran Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/dsa/hirschmann/hellcreek.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c index 354655f9ed003..2afd6a4f02b88 100644 --- a/drivers/net/dsa/hirschmann/hellcreek.c +++ b/drivers/net/dsa/hirschmann/hellcreek.c @@ -710,8 +710,9 @@ static int __hellcreek_fdb_add(struct hellcreek *hellcreek, u16 meta = 0; dev_dbg(hellcreek->dev, "Add static FDB entry: MAC=%pM, MASK=0x%02x, " - "OBT=%d, REPRIO_EN=%d, PRIO=%d\n", entry->mac, entry->portmask, - entry->is_obt, entry->reprio_en, entry->reprio_tc); + "OBT=%d, PASS_BLOCKED=%d, REPRIO_EN=%d, PRIO=%d\n", entry->mac, + entry->portmask, entry->is_obt, entry->pass_blocked, + entry->reprio_en, entry->reprio_tc); /* Add mac address */ hellcreek_write(hellcreek, entry->mac[1] | (entry->mac[0] << 8), HR_FDBWDH); @@ -722,6 +723,8 @@ static int __hellcreek_fdb_add(struct hellcreek *hellcreek, meta |= entry->portmask << HR_FDBWRM0_PORTMASK_SHIFT; if (entry->is_obt) meta |= HR_FDBWRM0_OBT; + if (entry->pass_blocked) + meta |= HR_FDBWRM0_PASS_BLOCKED; if (entry->reprio_en) { meta |= HR_FDBWRM0_REPRIO_EN; meta |= entry->reprio_tc << HR_FDBWRM0_REPRIO_TC_SHIFT; -- 2.34.1