Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3603211pxb; Mon, 24 Jan 2022 13:17:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJwG6R2N2NG/zCSmnxJt+FMCDde6xwoht9E8lVquC5dG013PYN9/B3DKND44hooHqspXbAmm X-Received: by 2002:a17:902:b083:b0:14a:f06c:aa6b with SMTP id p3-20020a170902b08300b0014af06caa6bmr15895023plr.147.1643059037232; Mon, 24 Jan 2022 13:17:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643059037; cv=none; d=google.com; s=arc-20160816; b=oyFQdkU3QT8CzQTW4sk836RLyJ8p7zlJhHcnCgop0X7fP21VNLsxTDqfZfUb65aOK1 7FrKJB8mzI9PA8cie599wEgUI6BMe8JGwbayE1avgyd+xlKy+evsg45jYlrrPnk/5k0g 66eFjivWUCt4FUKELEunN3VDcVYLvHq3wQsdzyu/fT1GASqxn4ZJ+iKphrh7EB2mF+2W d0e8sy+QQyrE34ByKLW3qa3h9J2klrEIpKoR750/fU9ECJ+4ELjo6xlBijnufA6i66Fp oqbUUZy6GDtcXm9ZlB2ybqBnVs2nl6J2pM7wHlxE0K0832as8VpK5OUiY5eJLHmhrXML /g5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iu3f8mlmXMHo4QmZEWRSunbmHHVdnGBOUQjtcI9MEpY=; b=IRu7Yo2qNBvqZi35lG5c1k1bZfKZyRihQ6rddXe70R4r6FALJPj4yaoB7wQa5pj6Ux dP3YWTr0SWvwuLxwJ+vR3srNHOANzgj+YCZBN2ol9GlslBGeJQb8RMR4hB0gMck1hDVn NPbBxgp0xaK8IEB2h7JJgsaDXaOyQLIbOnFKJKUd7LZpQKANwm6X4Y1un+1tzNYIhE5u /IiDTK2bAiDoI+SKFiaXsI8df/b31MCQbIw9vHfB9awieEhMj3jg4RcD/mhmupccXkML d6Mt/zA55SoIFFE2VPaQf287rZm9U2ZLFSHfwJSQvjMx9ChM3lOgHWJ8kjFOu9Q571RI k83w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=DUrWJvmJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s15si354508pjg.109.2022.01.24.13.17.02; Mon, 24 Jan 2022 13:17:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=DUrWJvmJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1390377AbiAXUpO (ORCPT + 99 others); Mon, 24 Jan 2022 15:45:14 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:45828 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381739AbiAXUWq (ORCPT ); Mon, 24 Jan 2022 15:22:46 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: detlev) with ESMTPSA id CA2881F43F0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1643055758; bh=GSNEWPnRJLYM9HcdPN2TTX4m27DGQnVdB0QfH3N3Syc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DUrWJvmJXDk944dJo8YvSY2F65VFBtgApUNnZkEKR+F/ZnUD+jXt2aNI73eFKEPt4 bZy/J75hQXpRxQfiCK8xeXMapkeJWPODVicoluPrnfi9joOwgKrfVT+CPd5HaxElDL GF8mKXeE4UVQqdU1ZdE3I3r3RGH76wqiQ4WVxph9Y/IXNCITyXgVYIV8+wN/d+ENcb f0YG0pDZOCQGEQOPm/2YDRA9u2pXOqXhrEtS22LMFaUuAVtHHnytE2dBuI6bU22XOf bz6ldXAbfwrAPLbf4wyeJI+jmDdeOkwxeKz34Xhyq3VWIqbm/Nhj3EUtVIk1GLWVRe DYZbnBIvplBsg== From: Detlev Casanova To: Mark Brown Cc: linux-kernel@vger.kernel.org, Dave Stevenson , Liam Girdwood Subject: Re: [PATCH v2 8/9] regulator/rpi-panel-attiny: Don't read the LCD power status Date: Mon, 24 Jan 2022 15:22:35 -0500 Message-ID: <5533342.DvuYhMxLoT@falcon9> In-Reply-To: References: <20220121152056.2044551-1-detlev.casanova@collabora.com> <20220121152056.2044551-9-detlev.casanova@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, January 21, 2022 11:30:39 A.M. EST Mark Brown wrote: > On Fri, Jan 21, 2022 at 10:20:55AM -0500, Detlev Casanova wrote: > > From: Dave Stevenson > > > > The I2C to the Atmel is very fussy, and locks up easily on > > Pi0-3 particularly on reads. > > > > The LCD power status is controlled solely by this driver, so > > rather than reading it back from the Atmel, use the cached > > status last set. > > If that's the case since you're using regmap would it not make sense to > enable caching in order to minimise reads in general. Would caching avoid all reads if the values are written at least once before? The idea here is to make sure they are never read, I'm not sure if the regmap cache ensures no read in this situation.