Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3610099pxb; Mon, 24 Jan 2022 13:28:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJyzUfbB2JDIb07ieThozjTirHbrO5Mw9CnXg2Ss3wWfPME7/Br0nXsTZ1QCynbFOX4paJCQ X-Received: by 2002:a17:902:e5cf:b0:14b:8a7:b26d with SMTP id u15-20020a170902e5cf00b0014b08a7b26dmr15592686plf.80.1643059693165; Mon, 24 Jan 2022 13:28:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643059693; cv=none; d=google.com; s=arc-20160816; b=EYrQgzzoWQT8YEWsG09I/SANGk2FYbE0Fr4s00PeWq3PDQ6MFp0zq4EiRzeSyTT5bp 3Br7xd4MCok3Cy7m5AhC9cQPnbH0YN7Y1ZWzvh304lInVRNIe50hjduz8QzlWGfN2Y7R 71/MCUI0KxJS8vJA2rUyEkOomXDrfmZHgwAPuH6zy6tZhUTxmOoxo4+xZt6qLrsMYOFc w3uDP5Cgl/SdqbsPT8X0cSxkkG3OHTR9/e31RxpRO4EeM8AijXHgEzwHWs+aWHz0g7m2 M03pe1cU9Zb2fdKaQOPTzCWXC6GABuS/8tYGT+KnEYByAu8GJFO90qr3YYl6bXhHoXdd HaVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=l8Q9aM2vOX8pWwtMEcv2FGx0t1fFtp5tzaP5hl8TPIw=; b=S6YAOL9U0CtvfM8ZXq5vzWQm9igwX3AYJ+IqKFqIcp0rwRddSb8BOyYzkwFs33Pp4b +TeO3CZSNWCASIiWDY4ZFc3BY7IarvCr5sOz9KGgli2M8JdX8C5pCfginrE6Zg/Sfsn2 MlF6CtKA79UkRhiKv5pKmv6p2J7g2P8IR/F5iEB25jdJCLGPWfkBlmAubnQD2wtDhQyn o6HfetlDjrb2Dua/U1exb/UTbx+nyiQW+cOa49W/YbzujYWeR82Vc1nMNlF2W8j6PNtl 0DIGxcHFkGl+nhS00GOFeVz+/icJHkuxpz3jUk2QyaZA58yKP2l5kSMKqMt45AwSb494 AxNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xGRqnIcN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g4si563028pfj.285.2022.01.24.13.28.01; Mon, 24 Jan 2022 13:28:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xGRqnIcN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444494AbiAXVBD (ORCPT + 99 others); Mon, 24 Jan 2022 16:01:03 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:39958 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1387203AbiAXUgi (ORCPT ); Mon, 24 Jan 2022 15:36:38 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 624EEB811FB; Mon, 24 Jan 2022 20:36:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89735C340E5; Mon, 24 Jan 2022 20:36:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643056595; bh=Uxs0Gx+3NmFC6BXoIOxZxNJaR0wXchGDKw1i4wsCkHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xGRqnIcNW8yFaOgvD4oge97fW3j3D2ofdiD28hGfzdEePW/M/BVELJIGpn579yaRJ z+Zh3p38kCTlvdMTGQF5kD3NKgyaycP7k5I6ilVAcSf2hDtxnyytJum6fOhNB+t/PG 8yp7icnlrY3prTYG4NtE4I1ICl0On3x3Ky4XBCmI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Antoine Tenart , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 535/846] net-sysfs: update the queue counts in the unregistration path Date: Mon, 24 Jan 2022 19:40:52 +0100 Message-Id: <20220124184119.458435129@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184100.867127425@linuxfoundation.org> References: <20220124184100.867127425@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Antoine Tenart [ Upstream commit d7dac083414eb5bb99a6d2ed53dc2c1b405224e5 ] When updating Rx and Tx queue kobjects, the queue count should always be updated to match the queue kobjects count. This was not done in the net device unregistration path, fix it. Tracking all queue count updates will allow in a following up patch to detect illegal updates. Signed-off-by: Antoine Tenart Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/core/net-sysfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index dfa5ecff7f738..a4ae652633844 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -1820,6 +1820,9 @@ static void remove_queue_kobjects(struct net_device *dev) net_rx_queue_update_kobjects(dev, real_rx, 0); netdev_queue_update_kobjects(dev, real_tx, 0); + + dev->real_num_rx_queues = 0; + dev->real_num_tx_queues = 0; #ifdef CONFIG_SYSFS kset_unregister(dev->queues_kset); #endif -- 2.34.1