Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3618448pxb; Mon, 24 Jan 2022 13:38:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJwbEK2neHc7KxLQNOftasHCiv6cNJSTmTxjdkYcpVq128+7WhHOGSJm3i2umdSXzE+z5oCR X-Received: by 2002:a05:6a00:a90:b0:4bd:320a:d579 with SMTP id b16-20020a056a000a9000b004bd320ad579mr15732703pfl.47.1643060313755; Mon, 24 Jan 2022 13:38:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643060313; cv=none; d=google.com; s=arc-20160816; b=GCGUhZLlA7J1cMtlprolOzt0WD0VLJ3kG1izsUCZ5pMwpRfed6ISxzHAvCazwBWuyW 5zol/nG0Bo4BjReAF4ITbv4+e5Kbkc9dkPsqUeiIokLiUj0TJMaUKkStrALhnQVxA0GM yD5XxY7DobuYB43jXtuxzAxJSwR8WaZTmiZ5UGTwqI+71q6bHmesYXVqusvxUhtNtbB2 m7LrsjId1h7l8Pk6v1hsk4gVOq0yqVtm+YhUE+oZeKyFqaMmctEXtXftZaEJwFVRcUch +catQ5waA/TeQRaUsc0M3syxqONct7ary2JfcPqBlI7qAahV6J11soVf2ZxTdybkPaMJ 0fyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IuV0U9cs2FG7ppV8Kdya8YYbxPY18ZzWvsuZz3bDOCM=; b=NIQt4NsV4M200Vq8MQlNyi822kEOjqeMmn5bDWnpIohv8IO403u2ueqvQCNJEIiYjz bOPJ9zicrpHhbBD4fDUa0akePcC02qWJXxl7GYaoc8QPragluvqKAT0/CmxwV97bq9yt WsAqM/rkd8IDTDF+1lUhv6x1Q9/dz17oZd0ohP8GwaTU8HpzJZhAWJIz03z7HdtkxpdE uowu686Xt5VWV89uGS1rJWpYd/l03bLJkM2PQ1HZowJtiqrqBZABUa9L10hjvagukk68 TOC3hSmU5fGNWPcCrNrvSPA1+ydgujP8HkHncj20RQ2eDPlIzCWUD1NvJ3sd8NSFBzW9 Pd3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UKigDxf+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d184si13309728pfa.118.2022.01.24.13.38.21; Mon, 24 Jan 2022 13:38:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UKigDxf+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1449857AbiAXVRK (ORCPT + 99 others); Mon, 24 Jan 2022 16:17:10 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:44116 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1392181AbiAXUuf (ORCPT ); Mon, 24 Jan 2022 15:50:35 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B03160C3F; Mon, 24 Jan 2022 20:50:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E55F4C340E7; Mon, 24 Jan 2022 20:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643057434; bh=Qlp85fVLXFysxne0M7vox7TTGm1Wpc/6yq/GnOLNTws=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UKigDxf+TK0J+0oR1pY6dz/DBZmOhFzrI2m3sCmnhuTfXl3IyaAg/uelvigrs2v7Y u/AzyU7LDremVf2fHX7gm6RYPWlv+wZDqq8mDDUszjLvxikxVsOcwIU7MXilbw/f13 4QImHrya8THZDQW/LBAw6bchphSgxNiJWihWhaLM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Si-Wei Liu , Jason Wang , Eli Cohen , "Michael S. Tsirkin" Subject: [PATCH 5.15 811/846] vdpa/mlx5: Restore cur_num_vqs in case of failure in change_num_qps() Date: Mon, 24 Jan 2022 19:45:28 +0100 Message-Id: <20220124184128.895154057@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184100.867127425@linuxfoundation.org> References: <20220124184100.867127425@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eli Cohen commit 37e07e705888e4c3502f204e9c6785c9c2d6d86a upstream. Restore ndev->cur_num_vqs to the original value in case change_num_qps() fails. Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support") Reviewed-by: Si-Wei Liu Acked-by: Jason Wang Signed-off-by: Eli Cohen Link: https://lore.kernel.org/r/20220105114646.577224-10-elic@nvidia.com Signed-off-by: Michael S. Tsirkin Signed-off-by: Greg Kroah-Hartman --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -1510,9 +1510,11 @@ static int change_num_qps(struct mlx5_vd return 0; clean_added: - for (--i; i >= cur_qps; --i) + for (--i; i >= 2 * cur_qps; --i) teardown_vq(ndev, &ndev->vqs[i]); + ndev->cur_num_vqs = 2 * cur_qps; + return err; }