Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3618687pxb; Mon, 24 Jan 2022 13:38:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxvDdqoC8H4iiYh8fvwcpOWHs2YCk09vsnFnGjNT51yGeGVUpqBwgFgHM11P/ReM8VKcQgG X-Received: by 2002:a63:6905:: with SMTP id e5mr12973462pgc.543.1643060330511; Mon, 24 Jan 2022 13:38:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643060330; cv=none; d=google.com; s=arc-20160816; b=v19eIYxgYArcftmauCmvJZPt6auoNmcPKqcrMCOvqieAhcxZ9ziTVwMHB8/IxABiZi 7L9vbUKlZb4CvSwG2/1QUsyKurzS7BCUCz182po9WPYz/6baE3i8ndnv6uae4rAYXDGR wd0hBfPxuIndSsRaLAkqGaeRCaLMVI88NfOp2IG1WhOE4K/56gUga5TOxfr+E5NqVNeR ocshXww4lbugv92rnlWjMb4GdFgPnLsaLvFXAB4m/sKMJ84wp1qTKS7t4jl5iTnOoXnR FSJABXM0OwKK/z4+QuY/JBKoJSNRvM62UHMjEGVIv1ZGg8MLZQzZDiKzJNuTM7TrNj4m SF+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1DGwqu+sL38MnRYoA1057SU2uz12s7H5KFyk79YR4+8=; b=WistvAr4BthxHcrH+Gaf8JL1Ggs0Km5ZouIftOlmx8kKm4Mw/jzKzExN6kVu6EkCqK 27ID7ZuQC9X/vjQC8HojPM4RHgTvY08sDCchFkVNG+7LS8tpQHFGxSIio/mwqOpA9cC2 ETeDXMrls8Q/VhVDTUcxKmGnHGwdgVEAPw02nubo67+yC5QLA5DfGyBve3oJGjVcw1N6 OhcyIaD3Zmb9pAu7orBDGr1nnZfsp3VNBBkDxRyv66n3cGmCyTXKT6Gxtyh3Y+ZzMpjH JmfXfJ2QFJQDR1pzBk7HN4RmJlkTLAROZJE3UTzwIqyQl5v+DOfp6PTVAx5YB1Ti0+RI 0sdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=C7kLsUK2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i1si12337184pfb.52.2022.01.24.13.38.37; Mon, 24 Jan 2022 13:38:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=C7kLsUK2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377788AbiAXVTh (ORCPT + 99 others); Mon, 24 Jan 2022 16:19:37 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:44502 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1392408AbiAXUvK (ORCPT ); Mon, 24 Jan 2022 15:51:10 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2663860C44; Mon, 24 Jan 2022 20:51:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6E5AC340E5; Mon, 24 Jan 2022 20:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643057467; bh=fhcehs13K324S4NcYX+VvjBRl1SSEGNfMfH7EvgCHdk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C7kLsUK20rDWue9Uyg1ZVFrQZ7nwBRiLVWup05cwTaffk4DFKiQhByxotCWEQpsKG BMFWgwW5wPbLWy9Lb9N+nRRfkG/R8nJk2+/Am5UfWDvwEcC4vKVa2jslN5J8NhQ4I7 RFWWsyWZ/2lhgaasPBJyExU1gOzRawFEcjdSs+Qk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, James Clark , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Adrian Bunk , Alexander Shishkin , Branislav Rankov , Diederik de Haas , Jiri Olsa , Mark Rutland , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: [PATCH 5.15 821/846] perf tools: Drop requirement for libstdc++.so for libopencsd check Date: Mon, 24 Jan 2022 19:45:38 +0100 Message-Id: <20220124184129.225160788@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184100.867127425@linuxfoundation.org> References: <20220124184100.867127425@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Uwe Kleine-König commit ed17b1914978eddb2b01f2d34577f1c82518c650 upstream. It's possible to link against libopencsd_c_api without having libstdc++.so available, only libstdc++.so.6.0.28 (or whatever version is in use) needs to be available. The same holds true for libopencsd.so. When -lstdc++ (or -lopencsd) is explicitly passed to the linker however the .so file must be available. So wrap adding the dependencies into a check for static linking that actually requires adding them all. The same construct is already used for some other tests in the same file to reduce dependencies in the dynamic linking case. Fixes: 573cf5c9a152 ("perf build: Add missing -lstdc++ when linking with libopencsd") Reviewed-by: James Clark Signed-off-by: Uwe Kleine-König Cc: Adrian Bunk Cc: Alexander Shishkin Cc: Branislav Rankov Cc: Diederik de Haas Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Cc: Peter Zijlstra Link: https://lore.kernel.org/all/20211203210544.1137935-1-uwe@kleine-koenig.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Greg Kroah-Hartman --- tools/perf/Makefile.config | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -143,7 +143,10 @@ FEATURE_CHECK_LDFLAGS-libcrypto = -lcryp ifdef CSINCLUDES LIBOPENCSD_CFLAGS := -I$(CSINCLUDES) endif -OPENCSDLIBS := -lopencsd_c_api -lopencsd -lstdc++ +OPENCSDLIBS := -lopencsd_c_api +ifeq ($(findstring -static,${LDFLAGS}),-static) + OPENCSDLIBS += -lopencsd -lstdc++ +endif ifdef CSLIBS LIBOPENCSD_LDFLAGS := -L$(CSLIBS) endif