Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933014AbXBFR1H (ORCPT ); Tue, 6 Feb 2007 12:27:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933002AbXBFR1H (ORCPT ); Tue, 6 Feb 2007 12:27:07 -0500 Received: from omx1-ext.sgi.com ([192.48.179.11]:32891 "EHLO omx1.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932999AbXBFR1F (ORCPT ); Tue, 6 Feb 2007 12:27:05 -0500 Date: Tue, 6 Feb 2007 09:26:53 -0800 (PST) From: Christoph Lameter To: KAMEZAWA Hiroyuki cc: LKML , GOTO , Christoph Lameter , Andrew Morton Subject: Re: [2.6.20][PATCH] fix mempolicy error check on a system with memory-less-node In-Reply-To: <20070206202312.4f979bcf.kamezawa.hiroyu@jp.fujitsu.com> Message-ID: References: <20070206202312.4f979bcf.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1204 Lines: 39 On Tue, 6 Feb 2007, KAMEZAWA Hiroyuki wrote: > This means an access to NULL,here. > == > unsigned slab_node(struct mempolicy *policy) > { > case MPOL_BIND: > /* > * Follow bind policy behavior and start allocation at the > * first node. > */ > return zone_to_nid(policy->v.zonelist->zones[0]); > } > == > length of this zonelist was 0. > It seems fixing a NULL access here is also O.K. > This patch is just an idea. Hmmm... Remove the node from the node_online_map instead? > } > - return nodes_subset(*nodes, node_online_map) ? 0 : -EINVAL; > + nodes_clear(node_with_memory); > + for_each_online_node(nd) { > + if (node_present_pages(nd)) > + node_set(nd, node_with_memory); > + } > + return nodes_subset(*nodes, node_with_memory) ? 0 : -EINVAL; > } Uhh. No loops here please. If we really need this then we need to have some sort of set operation here. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/