Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3643215pxb; Mon, 24 Jan 2022 14:14:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJyPbAsIei9UYXk/+yL/WPBjxRwUMraAVdFnPzRUOnT0eJjzfuCQfDEMrw4LnThNzQQzdD1u X-Received: by 2002:a17:90a:ec02:: with SMTP id l2mr392907pjy.61.1643062483296; Mon, 24 Jan 2022 14:14:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643062483; cv=none; d=google.com; s=arc-20160816; b=bPfF8kdsHAnGvJmvDtqYskEXDuo3T+XkHVT8luzKPJJOPjxysz8qIy2JY/aXn+JdEG HWomfguv2fzyHA+YM4xMD6HXwB4m6BAcPUdMooNN4kxVgVF+BPwdxMQJS6fphUeJ9qSk OCx3WgI0haUT3M1r43IxG5bYw5GNJGpUrgLzERY6VhScn3+2g55SUC6TAIbe94SxfoAd 5dwXfrDatViuVhTybElR0UVgj30jf6MVn7+J/9+qHf8bx1e6uBMdKxFR8xRWAPd+1tR3 LkgD4vq8wlh4/LIhK12s196l53K4ATuEBYsxKLdNen68IHg9eDZ8dJ1EEriuuwLV9QdS PxZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gmUfoLBonp2GzQb+ELK9Di2TXy4TXAJI4QD6FiC5gc0=; b=P5Bp9Cy2knt039shiOMggl6jhn6tW/MX2zx5CuI9roEAMRwk07q0d55aOyzb6X35S6 e8EBfhhoSyLEA9mQviXcSFeN1LaAzlXhbrS6d6XFaHzYo9c+qEs8LwWiDAJXRLwg6zNN B6XbchLM25kevwK7pIWy1h8xYzD8ZZ0mZGTZl8TV3OB6EHbmctLfEBx+StcauYPZQMs8 mCiuniNllmN12Mbh/JZdtmPsa1GDWE2u7A0atwXHSlC2Dq1hG1FJ+ITHpsDQK8K5wAz1 HS7Yizw6JoUb2GOxkYyZx51CU3AI53D6iPihh0EKMHR8VptldoY93ZVGx4YGs61BesHA 3mNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gNk40Hvl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q20si8354957plk.608.2022.01.24.14.14.23; Mon, 24 Jan 2022 14:14:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gNk40Hvl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1579502AbiAXWFt (ORCPT + 99 others); Mon, 24 Jan 2022 17:05:49 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:40378 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1451683AbiAXVXV (ORCPT ); Mon, 24 Jan 2022 16:23:21 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 14973B812A5; Mon, 24 Jan 2022 21:23:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CABFC340E4; Mon, 24 Jan 2022 21:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643059398; bh=AXo2SKIfBrFl+rOiVbbS6B5EIC7YCr/SvPrUDVh/G4E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gNk40HvlRwkbemebPbUe1fIVVztT8DPR/kxwCVbMwTEJF4WtpMKEMNSxxoJhygzcM 4yCp4vCO8ijXQrSvSKPzGXz6aGUm+D3ORZaUJcHq6fjn4BRqcbwSVRH6ajObM+vT2A dGQZG16nIX/ErapTrJFvsIt7ui6vmJdXRTX8Rvt0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Adam Ward , Mark Brown , Sasha Levin Subject: [PATCH 5.16 0602/1039] regulator: da9121: Prevent current limit change when enabled Date: Mon, 24 Jan 2022 19:39:51 +0100 Message-Id: <20220124184145.573533146@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184125.121143506@linuxfoundation.org> References: <20220124184125.121143506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Adam Ward [ Upstream commit 24f0853228f3b98f1ef08d5824376c69bb8124d2 ] Prevent changing current limit when enabled as a precaution against possibile instability due to tight integration with switching cycle Signed-off-by: Adam Ward Link: https://lore.kernel.org/r/52ee682476004a1736c1e0293358987319c1c415.1638223185.git.Adam.Ward.opensource@diasemi.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/da9121-regulator.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/regulator/da9121-regulator.c b/drivers/regulator/da9121-regulator.c index e669250902580..0a4fd449c27d1 100644 --- a/drivers/regulator/da9121-regulator.c +++ b/drivers/regulator/da9121-regulator.c @@ -253,6 +253,11 @@ static int da9121_set_current_limit(struct regulator_dev *rdev, goto error; } + if (rdev->desc->ops->is_enabled(rdev)) { + ret = -EBUSY; + goto error; + } + ret = da9121_ceiling_selector(rdev, min_ua, max_ua, &sel); if (ret < 0) goto error; -- 2.34.1