Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3644799pxb; Mon, 24 Jan 2022 14:17:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJz58AjTNHYrRZMT1e45+RYLepIS4hlJ7OQHKzWj/Y4UqrsZ5M5EgjcRaqWx18NJOK8HHPgU X-Received: by 2002:a17:90a:7e90:: with SMTP id j16mr431339pjl.30.1643062625300; Mon, 24 Jan 2022 14:17:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643062625; cv=none; d=google.com; s=arc-20160816; b=xwb7e97T4hKhhzyvgz7tuwXUVFjFuD/TDXRKLD1B85f2FPa4HqPEr7eTuE1/Km4imT 4dUuvoA9LqbaNlwCCLj3dZ0g7EHu2h4Baxh0EXt7NpToU9EWUi091iPDABmFUG5zs6i6 JTozTyYKEVTQS/xsMWEg5Oi3H1tBkJ2yM4kmm52igBq4c/abkwBt35KbGFsNyDVbKzaL zuO2FiS2yBsdzq8nPXgnVQUvhcpyGVUByWRYVngwf7AlGf+YbBWn+USesd6kx6+6rDjj tntcf2JC2vElTKjDK1jj0FRSZc9cgDsGKRSNzBKLJ0J/hbOCWhCxSWHsvWbSYPwlRB6A QWzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F6vvjv6ihaZsi4z/ywsss+uVR51lgyE5N8LuMaTW1WU=; b=TO1oMnoZwHKnwnd6e0JfZX1B5y/dDvHSvcyhyrh0bc77k4g7FZ4C4sC/+/TEIkUike Cmfph8e9tR4afli9iDbzBn7UuA3qd29l4xOdTDgCWgOjqpxHTIEqRRRqF2tmdJA205Lq jCCbIYeeAK9e3Mv9iIbCImVgq7mkTsEz72y398W1RfWj+sEwZBREBOyrEOQNAG1tTfc0 XYjq7706LEHh/hJr+z8rrLEKbR2JmodTcYZeZVxnvvW7+U9AmxdGewkNrMZhxDc0x+uy DkzZc4PT8NIT2+/f4fscV1NkX1Aam+IhU1sx+7V9QsNjM1pafmLkVKL499UE7EA4wpNF jVAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KR9e1Fkt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b7si13862230pfm.25.2022.01.24.14.16.52; Mon, 24 Jan 2022 14:17:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KR9e1Fkt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1581420AbiAXWLp (ORCPT + 99 others); Mon, 24 Jan 2022 17:11:45 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:40736 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1452694AbiAXV0O (ORCPT ); Mon, 24 Jan 2022 16:26:14 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B538CB8123D; Mon, 24 Jan 2022 21:26:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D213CC340E4; Mon, 24 Jan 2022 21:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643059572; bh=s1+wA1K07F5Sne0E08ebjE9IXHWGC4ncgOKASX8xlfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KR9e1FktBstZNU5hntWtg5b3UdE9B8vQYoDWfhR0ScnNNOcxTJjUVnK2mPY6FAtlb PVG4xVyMpKmK34IM/ZslucWs3SLfukAvzOnh3XsIcZ2VDNtOBWdcD9Lgv5O5Pm1Ryt ljLj2/naK9/2VPmkurBElPB3XGyOO0j/9TDohLqQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mikhail Rudenko , Ezequiel Garcia , Kieran Bingham , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.16 0653/1039] media: rockchip: rkisp1: use device name for debugfs subdir name Date: Mon, 24 Jan 2022 19:40:42 +0100 Message-Id: <20220124184147.316019682@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184125.121143506@linuxfoundation.org> References: <20220124184125.121143506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mikhail Rudenko [ Upstream commit c2611e479f5d9b05108270e1ab423955486b4457 ] While testing Rockchip RK3399 with both ISPs enabled, a dmesg error was observed: ``` [ 15.559141] debugfs: Directory 'rkisp1' with parent '/' already present! ``` Fix it by using the device name for the debugfs subdirectory name instead of the driver name, thus preventing name collision. Link: https://lore.kernel.org/linux-media/20211010175457.438627-1-mike.rudenko@gmail.com Signed-off-by: Mikhail Rudenko Reviewed-by: Ezequiel Garcia Reviewed-by: Kieran Bingham Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c index 50b166c49a03a..3f5cfa7eb9372 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c @@ -462,7 +462,7 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1) { struct rkisp1_debug *debug = &rkisp1->debug; - debug->debugfs_dir = debugfs_create_dir(RKISP1_DRIVER_NAME, NULL); + debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL); debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir, &debug->data_loss); debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir, -- 2.34.1