Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <28734c1c-a30c-d47f-3fc1-95035adcd33d@quicinc.com>
Date:   Mon, 24 Jan 2022 13:24:25 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] drm/msm/dp: always add fail-safe mode into connector mode
 list
Content-Language: en-US
To:     Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>,
        <airlied@linux.ie>, <bjorn.andersson@linaro.org>,
        <daniel@ffwll.ch>, <dmitry.baryshkov@linaro.org>,
        <robdclark@gmail.com>, <sean@poorly.run>, <vkoul@kernel.org>
CC:     <quic_abhinavk@quicinc.com>, <aravindh@codeaurora.org>,
        <freedreno@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1643057170-10413-1-git-send-email-quic_khsieh@quicinc.com>
 <CAE-0n53nFcMzuKfqVRac6PRTkoPrftXL+uVK56ZQsHVWHmivkQ@mail.gmail.com>
From:   Kuogee Hsieh <quic_khsieh@quicinc.com>
In-Reply-To: <CAE-0n53nFcMzuKfqVRac6PRTkoPrftXL+uVK56ZQsHVWHmivkQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/24/2022 1:04 PM, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2022-01-24 12:46:10)
>> Some of DP link compliant test expects to return fail-safe mode
>> if prefer detailed timing mode can not be supported by mainlink's
>> lane and rate after link training. Therefore add fail-safe mode
>> into connector mode list as backup mode. This patch fixes test
>> case 4.2.2.1.
>>
>> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
> Any Fixes tag? I also wonder why this isn't pushed into the DP core code
> somehow. Wouldn't every device need to add a 640x480 mode by default?

Original test case 4.2.2.1 always passed until we did firmware upgrade 
of our compliance test tester (Unigraph) recently.

The new firmware of tester use newer edid contains 1080p with 145.7 mhz 
which can not be supported by 2 lanes with 1.6G rate. Hence we failed 
this test case.

After discuss with Vendor, they claims we have to return fail-safe mode 
if prefer detailed timing mode can not be supported.

I think would be good to add fail-safe mode into connector mode list.


> we just run into this problem recently.
>> ---
>>   drivers/gpu/drm/msm/dp/dp_panel.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
>> index 3b02922..7743b45 100644
>> --- a/drivers/gpu/drm/msm/dp/dp_panel.c
>> +++ b/drivers/gpu/drm/msm/dp/dp_panel.c
>> @@ -221,6 +221,11 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel,
>>                  if (drm_add_modes_noedid(connector, 640, 480))
>>                          drm_set_preferred_mode(connector, 640, 480);
>>                  mutex_unlock(&connector->dev->mode_config.mutex);
>> +       } else {
>> +               /* always add fail-safe mode as backup mode */
>> +               mutex_lock(&connector->dev->mode_config.mutex);
>> +               drm_add_modes_noedid(connector, 640, 480);
>> +               mutex_unlock(&connector->dev->mode_config.mutex);
>>          }
>>
>>          if (panel->aux_cfg_update_done) {
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>