Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3661418pxb; Mon, 24 Jan 2022 14:44:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzDDzIu+FQYLg6hcqdfkTMQ5AzxvK07rVJOSdYuOqSU9xtNJyQWSEX7rmEXNQLWd/7Y3Cm+ X-Received: by 2002:a17:90a:6409:: with SMTP id g9mr509041pjj.108.1643064263213; Mon, 24 Jan 2022 14:44:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643064263; cv=none; d=google.com; s=arc-20160816; b=ImV0Em4vgMs9yvbOT+BeZs8zxwtRKbaZRfAoRqxEWmE6DbvIv8J3oHJ70nO7TFKNNB rPneeeorvAClu5FQBfvb8QaOdoai5BzxRCc6+2KCZR9FF5gZQ1ub/pFeEDObBg+NfCCj +xPJ6icI9beDhac7YutWn5NDXfofCi1ZQq4ruZ9XMZYdRG1nedVuIXUrO665E8/nUe04 TzU8D6sSvaYxfGazaZFgCjOHxuzA+rjBjFmaSPQ5V995invVflvpYzjU/WVOsMVHcdXj kDNIjbNWINs6N+z8Y+eKnKi/nFURQnzQNo4welVyF7cS5t1FeFpTxzqoea4sv6PiVynH 05BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EIV/c5UVAMcpaOX2ishPtTciTTvH/v91fD6+n6EHYjs=; b=rBO5K0w0A0E5jyaKySK1v/1GBj/+38+nBPWcfUF5YVnK7dxyvFMnMoXKw8RQ6ufBBb +EjvEorE6vYyKOKNQbcoEUIY5BE3MgyIOV4kYVNNFNB1jg0nmHk21UGiGDNfJoIhfv1o W0ebxuwig6ASQSMQM/cykdtZuTsQ3kBhSeVsFpb8FfgnrLgKMMlqER3+OMBvu2vkhNab AmugmbMPTqTUAXzvneM9YpwR6nIJ5yeDRmRhyf1sO9MG8/Affs/XaphnGoH2ihYxAi+F rF9SdoLWooFE/RhMBOYiCGj8ahBeWfjI9Lf/JtEpoNVWHSbD2lwcSTtisMubqJ3sX5+g ZHXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0CZzCyw6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si13187764plr.104.2022.01.24.14.44.11; Mon, 24 Jan 2022 14:44:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0CZzCyw6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1835899AbiAXWmf (ORCPT + 99 others); Mon, 24 Jan 2022 17:42:35 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:50934 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378386AbiAXVjU (ORCPT ); Mon, 24 Jan 2022 16:39:20 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DC0FAB8123D; Mon, 24 Jan 2022 21:39:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F19EFC340E4; Mon, 24 Jan 2022 21:39:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643060345; bh=bPj+/VtfiWo0N44MEdLgqfeCoWwdaSWRHiXq8k/ovb4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0CZzCyw6Sj65epi5f9E3DSPO6UAJS09tvnhTJb/gJefUXmzBUS0s2N7QGfFPEZ3nw zrhe02AoKjU7IReVe8jOUbUgQUvtSloyp/hnWlGgNXir4uvbmMV07PSP2s2IG+sDkL kprulooWGCMyldK1QWZI7QEB8/VRcag4Pd5oWFfw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gabriel Hojda , Markus Reichl , Alexander Stein , "David S. Miller" Subject: [PATCH 5.16 0918/1039] net: usb: Correct reset handling of smsc95xx Date: Mon, 24 Jan 2022 19:45:07 +0100 Message-Id: <20220124184156.151964131@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184125.121143506@linuxfoundation.org> References: <20220124184125.121143506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Reichl commit 0bf3885324a8599e3af4c7379b8d4f621c9bbffa upstream. On boards with LAN9514 and no preconfigured MAC address we don't get an ip address from DHCP after commit a049a30fc27c ("net: usb: Correct PHY handling of smsc95xx") anymore. Adding an explicit reset before starting the phy fixes the issue. [1] https://lore.kernel.org/netdev/199eebbd6b97f52b9119c9fa4fd8504f8a34de18.camel@collabora.com/ From: Gabriel Hojda Fixes: a049a30fc27c ("net: usb: Correct PHY handling of smsc95xx") Signed-off-by: Gabriel Hojda Signed-off-by: Markus Reichl Tested-by: Alexander Stein Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/smsc95xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -1962,7 +1962,8 @@ static const struct driver_info smsc95xx .bind = smsc95xx_bind, .unbind = smsc95xx_unbind, .link_reset = smsc95xx_link_reset, - .reset = smsc95xx_start_phy, + .reset = smsc95xx_reset, + .check_connect = smsc95xx_start_phy, .stop = smsc95xx_stop, .rx_fixup = smsc95xx_rx_fixup, .tx_fixup = smsc95xx_tx_fixup,