Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3663999pxb; Mon, 24 Jan 2022 14:48:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQKjbqvQyZUrg8Es3Wg9lzJLsYfvlLx+QXJPUqeqyZU4tnifW1q8dVceD141SSigNzGUDs X-Received: by 2002:a17:902:b414:b0:142:431f:3d1c with SMTP id x20-20020a170902b41400b00142431f3d1cmr16472802plr.32.1643064512140; Mon, 24 Jan 2022 14:48:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643064512; cv=none; d=google.com; s=arc-20160816; b=VI/YjY8iq/xPJy46dGwj5nS4Q09HrXG1eczlodSsMwrxgaTckGYTkmdS9OuGBiZPf4 qeklUNTdlxzzOwM8h9ttPjsr54cKgCPqMw9ddgwnUKTYL9JrWAVxVPU6eZdyTGIfTH2l h+z9WlS3QAiz9huvI9D07n4uW+tYrqtGIfQB9gY19vu6J1ER/wsAaUZnLTZDkGoC/Uep KnvuOSxTDk4ODzhE+06ZqFOez4ygZsVGODyZJmQBo0y7rLfrf+UM0PcMML3PNEmLpp+Y AOiQCAQ9NIGhRGUX4TrPYiKti+pmmYQE0y9cEBlGRMn8MjGd6KueOvWUA3UgwcUgwYr/ +QUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=p0gEKl5MYv+9ZzQxCNaoAg6NJNNr4JP0ip4ueYeZfpM=; b=iTtMu8DomhwpZ2Uu9Ps4tocqr/UrBI8j+yFYhMeakPyfkp/hiZzBHTwhL4xfYd6XFG T37vlbWCRaggeRMKuNjO/RFx/iNif/XVjIpwILDodMf1/G+0JJbM1n2HuzjXBsfq4Dgk zOWljW+WYGTwF/ChCju0d+gIcyqiuHKnPPdbRuqaf6LqZnkbQVW3wQyeEU+9jKps1WIs TtMRMG2pO4ERtfwIfSnKtj5dn0sWt8ojD1M1JlD5vxTcwpBXq/KMU+pHAo0dZ8Uf4Qym qvJQYS7P7TMc28HB6HELH6I/9GafTZ2Le/dVmvm7vChY2o39t1acM/linhGof1brcVkw +h5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c6comMHN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x184si8988809pgd.280.2022.01.24.14.48.20; Mon, 24 Jan 2022 14:48:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c6comMHN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1838213AbiAXWqF (ORCPT + 99 others); Mon, 24 Jan 2022 17:46:05 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:52066 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1457381AbiAXVld (ORCPT ); Mon, 24 Jan 2022 16:41:33 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2A81BB811FC; Mon, 24 Jan 2022 21:41:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 804F2C340E4; Mon, 24 Jan 2022 21:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643060490; bh=EtWA7L7BqdpMoJktY/5B7XDbMJPG7DdHQWCd5GNvgoU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c6comMHNeu4CT1rHyCM3kaHIu63EOlQfy/T2qE31EGGVrRivTFWz34SQAQU6c/CLJ 5rceZjERHwYfCBp8ATYsLGzA6mQvlwKbzoFhZA0XmvOKaDwx6auq5PZy2A8xHpuBpE 8NqpcdfpUgG7cc1VSHmmwZiAejeFdxIx2xN+2VfM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Linus Walleij , Bartosz Golaszewski Subject: [PATCH 5.16 0965/1039] gpio: idt3243x: Fix IRQ check in idt_gpio_probe Date: Mon, 24 Jan 2022 19:45:54 +0100 Message-Id: <20220124184157.726618119@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184125.121143506@linuxfoundation.org> References: <20220124184125.121143506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin commit 30fee1d7462a446ade399c0819717a830cbdca69 upstream. platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example: int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Fix the check of return value to catch errors correctly. Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller") Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-idt3243x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpio/gpio-idt3243x.c +++ b/drivers/gpio/gpio-idt3243x.c @@ -164,8 +164,8 @@ static int idt_gpio_probe(struct platfor return PTR_ERR(ctrl->pic); parent_irq = platform_get_irq(pdev, 0); - if (!parent_irq) - return -EINVAL; + if (parent_irq < 0) + return parent_irq; girq = &ctrl->gc.irq; girq->chip = &idt_gpio_irqchip;