Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965376AbXBFTaS (ORCPT ); Tue, 6 Feb 2007 14:30:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965375AbXBFTaR (ORCPT ); Tue, 6 Feb 2007 14:30:17 -0500 Received: from smtp.osdl.org ([65.172.181.24]:47423 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965379AbXBFTaP (ORCPT ); Tue, 6 Feb 2007 14:30:15 -0500 Date: Tue, 6 Feb 2007 11:29:49 -0800 From: Andrew Morton To: Alan , David Woodhouse Cc: Robert Hancock , linux-kernel , drzeus-wbsd@drzeus.cx, wbsd-devel@list.drzeus.cx Subject: Re: [PATCH] kernel: shut up the IRQ mismatch messages (Re: wbsd: IRQ handler type mismatch) Message-Id: <20070206112949.1fc99299.akpm@linux-foundation.org> In-Reply-To: <20070206113023.3c845bb2@localhost.localdomain> References: <45C7F32B.1060402@shaw.ca> <20070206113023.3c845bb2@localhost.localdomain> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1858 Lines: 50 On Tue, 6 Feb 2007 11:30:23 +0000 Alan wrote: > On Mon, 05 Feb 2007 21:16:59 -0600 > Robert Hancock wrote: > > > I'm seeing this on bootup on my laptop with recent kernels (currently > > 2.6.20-rc6-mm3): > > The problem is various drivers legally validly and sensibly try to claim > IRQs but the kernel insists on vomiting forth a giant irrelevant > debugging spew when the types clash. > > Edit kernel/irq/manage.c go down to mismatch: in setup_irq() and ifdef > out the if clause that checks for mismatches. It'll then just do the > right thing and work sanely. > > For the current -mm kernel this will do the trick (and moves it into > shared irq debugging as in debug mode the info spew is useful). I've had > a variant of this in my private tree for some time as I got fed up on the > mess on boxes where old legacy IRQs get reused. > > Signed-off-by: Alan Cox > > --- linux.vanilla-2.6.20-rc6-mm3/kernel/irq/manage.c 2007-01-31 14:20:43.000000000 +0000 > +++ linux-2.6.20-rc6-mm3/kernel/irq/manage.c 2007-02-06 11:01:00.796928504 +0000 > @@ -372,12 +372,14 @@ > return 0; > > mismatch: > +#ifdef CONFIG_DEBUG_SHIRQ > if (!(new->flags & IRQF_PROBE_SHARED)) { > printk(KERN_ERR "IRQ handler type mismatch for IRQ %d\n", irq); > if (old_name) > printk(KERN_ERR "current handler: %s\n", old_name); > dump_stack(); > } > +#endif > spin_unlock_irqrestore(&desc->lock, flags); > return -EBUSY; > } hm, well, it's dependent upon dwmw2's generate-a-spurious-irq-at-request_irq-time patch. Do we want to merge that? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/